diff mbox

[v2,2/2] drm/i915: print warning if vmi915_gem_fault error is not handled

Message ID 1349273727-14362-2-git-send-email-mika.kuoppala@intel.com (mailing list archive)
State New, archived
Headers show

Commit Message

Mika Kuoppala Oct. 3, 2012, 2:15 p.m. UTC 
From: Mika Kuoppala <mika.kuoppala@intel.com>

Falling into default case in vmi915_gem_fault is a bug. Be more
verbose about it.

Signed-off-by: Mika Kuoppala <mika.kuoppala@intel.com>
---
 drivers/gpu/drm/i915/i915_gem.c |    1 +
 1 file changed, 1 insertion(+)

Comments

Chris Wilson Oct. 3, 2012, 2:25 p.m. UTC | #1 
On Wed,  3 Oct 2012 17:15:27 +0300, mika.kuoppala@intel.com wrote:
> From: Mika Kuoppala <mika.kuoppala@intel.com>
> 
> Falling into default case in vmi915_gem_fault is a bug. Be more
> verbose about it.
> 
> Signed-off-by: Mika Kuoppala <mika.kuoppala@intel.com>

Once? Fair enough.
Reviewed-by: Chris Wilson <chris@chris-wilson.co.uk>
-Chris
diff mbox

Patch

diff --git a/drivers/gpu/drm/i915/i915_gem.c b/drivers/gpu/drm/i915/i915_gem.c
index 2b14716..1826ac2 100644
--- a/drivers/gpu/drm/i915/i915_gem.c
+++ b/drivers/gpu/drm/i915/i915_gem.c
@@ -1167,6 +1167,7 @@  out:
 	case -ENOMEM:
 		return VM_FAULT_OOM;
 	default:
+		WARN_ON_ONCE(ret);
 		return VM_FAULT_SIGBUS;
 	}
 }