diff mbox

drm/i915: Missed "ret" initialization on gem_context_size

Message ID 1349804946-4502-1-git-send-email-rodrigo.vivi@gmail.com (mailing list archive)
State New, archived
Headers show

Commit Message

Rodrigo Vivi Oct. 9, 2012, 5:49 p.m. UTC
Although default case is a bug, being conservative on the initialization helps to shut up coverity scan.

Signed-off-by: Rodrigo Vivi <rodrigo.vivi@gmail.com>
---
 drivers/gpu/drm/i915/i915_gem_context.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Chris Wilson Oct. 9, 2012, 6:04 p.m. UTC | #1
On Tue,  9 Oct 2012 14:49:06 -0300, Rodrigo Vivi <rodrigo.vivi@gmail.com> wrote:
> Although default case is a bug, being conservative on the initialization helps to shut up coverity scan.
> 
So many more issues would be resolved if you taught coverity that BUG()
was noreturn. :-p
-Chris
diff mbox

Patch

diff --git a/drivers/gpu/drm/i915/i915_gem_context.c b/drivers/gpu/drm/i915/i915_gem_context.c
index 4aa7ecf..bf78882 100644
--- a/drivers/gpu/drm/i915/i915_gem_context.c
+++ b/drivers/gpu/drm/i915/i915_gem_context.c
@@ -102,7 +102,7 @@  static int do_switch(struct i915_hw_context *to);
 static int get_context_size(struct drm_device *dev)
 {
 	struct drm_i915_private *dev_priv = dev->dev_private;
-	int ret;
+	int ret = 0;
 	u32 reg;
 
 	switch (INTEL_INFO(dev)->gen) {