| Message ID | 201210111141.27270.arnd@arndb.de (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
Thanks Arnd, On 2012-10-11 13:41, Arnd Bergmann wrote: > On Tuesday 09 October 2012, Markus F.X.J. Oberhumer wrote: >>> >>> : This commit updates the kernel LZO code to the current upsteam version >>> : which features a significant speed improvement - benchmarking the Calgary >>> : and Silesia test corpora typically shows a doubled performance in >>> : both compression and decompression on modern i386/x86_64/powerpc machines. >>> >>> There are significant clients of the LZO library - crypto, btrfs, >>> jffs2, ubifs, squashfs and zcache. So let's give all those people a cc >>> and ask that they test the LZO changes once they land in linux-next. >>> For correctness and performance, please. >> >> The core compression and decompression code has been thoroughly tested, so I >> do not expect major problems. >> >> Good testing after the merge and feedback about build or performance issues >> (and improvements!) is highly appreciated. > > The addition of the lzo tree to linux-next caused this problem for ARM > imx_v6_v7_defconfig: > > In file included from /home/arnd/linux-arm/arch/arm/boot/compressed/decompress.c:40:0: > /home/arnd/linux-arm/arch/arm/boot/compressed/../../../../lib/decompress_unlzo.c:34:34: fatal error: lzo/lzo1x_decompress.c: No such file or directory > > Since the file was renamed, anything including it needs to be updated to the > new file name. I will add that patch to my tree. Cheers, Markus > > Signed-off-by: Arnd Bergmann <arnd@arndb.de> > > diff --git a/lib/decompress_unlzo.c b/lib/decompress_unlzo.c > index 4531294..960183d 100644 > --- a/lib/decompress_unlzo.c > +++ b/lib/decompress_unlzo.c > @@ -31,7 +31,7 @@ > */ > > #ifdef STATIC > -#include "lzo/lzo1x_decompress.c" > +#include "lzo/lzo1x_decompress_safe.c" > #else > #include <linux/decompress/unlzo.h> > #endif
> From: Markus F.X.J. Oberhumer [mailto:markus@oberhumer.com] > Subject: Re: [PATCH 0/3] Update LZO compression > > Thanks Arnd, > > On 2012-10-11 13:41, Arnd Bergmann wrote: > > On Tuesday 09 October 2012, Markus F.X.J. Oberhumer wrote: > >>> > >>> : This commit updates the kernel LZO code to the current upsteam version > >>> : which features a significant speed improvement - benchmarking the Calgary > >>> : and Silesia test corpora typically shows a doubled performance in > >>> : both compression and decompression on modern i386/x86_64/powerpc machines. > >>> > >>> There are significant clients of the LZO library - crypto, btrfs, > >>> jffs2, ubifs, squashfs and zcache. So let's give all those people a cc > >>> and ask that they test the LZO changes once they land in linux-next. > >>> For correctness and performance, please. > >> > >> The core compression and decompression code has been thoroughly tested, so I > >> do not expect major problems. > >> > >> Good testing after the merge and feedback about build or performance issues > >> (and improvements!) is highly appreciated. > > > > The addition of the lzo tree to linux-next caused this problem for ARM > > imx_v6_v7_defconfig: > > > > In file included from /home/arnd/linux-arm/arch/arm/boot/compressed/decompress.c:40:0: > > /home/arnd/linux-arm/arch/arm/boot/compressed/../../../../lib/decompress_unlzo.c:34:34: fatal error: > lzo/lzo1x_decompress.c: No such file or directory > > > > Since the file was renamed, anything including it needs to be updated to the > > new file name. > > I will add that patch to my tree. > > Cheers, > Markus Sorry if I missed it (bad connectivity this week), but is someone going to send a pull request to get this LZO update from linux-next into Linus's tree? The window is closing soon isn't it? Dan -- To unsubscribe from this list: send the line "unsubscribe linux-btrfs" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
diff --git a/lib/decompress_unlzo.c b/lib/decompress_unlzo.c index 4531294..960183d 100644 --- a/lib/decompress_unlzo.c +++ b/lib/decompress_unlzo.c @@ -31,7 +31,7 @@ */ #ifdef STATIC -#include "lzo/lzo1x_decompress.c" +#include "lzo/lzo1x_decompress_safe.c" #else #include <linux/decompress/unlzo.h> #endif