diff mbox

DRM/i915: Don't clone SDVO LVDS with analog.

Message ID 1350131415-1311-1-git-send-email-eich@suse.de (mailing list archive)
State New, archived
Headers show

Commit Message

Egbert Eich Oct. 13, 2012, 12:30 p.m. UTC 
SDVO LVDS are not clonable as the input mode gets adjusted by
the LVDS encoder.

Signed-off-by: Egbert Eich <eich@suse.de>
---
 drivers/gpu/drm/i915/intel_sdvo.c |    6 ++----
 1 files changed, 2 insertions(+), 4 deletions(-)

Comments

Daniel Vetter Oct. 16, 2012, 7:36 a.m. UTC | #1 
On Sat, Oct 13, 2012 at 02:30:15PM +0200, Egbert Eich wrote:
> SDVO LVDS are not clonable as the input mode gets adjusted by
> the LVDS encoder.
> 
> Signed-off-by: Egbert Eich <eich@suse.de>

Imo cloning should simply die outright. Patch applied, thanks.
-Daniel
diff mbox

Patch

diff --git a/drivers/gpu/drm/i915/intel_sdvo.c b/drivers/gpu/drm/i915/intel_sdvo.c
index d192ce4..d2e8c9f 100644
--- a/drivers/gpu/drm/i915/intel_sdvo.c
+++ b/drivers/gpu/drm/i915/intel_sdvo.c
@@ -2286,10 +2286,8 @@  intel_sdvo_lvds_init(struct intel_sdvo *intel_sdvo, int device)
 		intel_sdvo_connector->output_flag = SDVO_OUTPUT_LVDS1;
 	}
 
-	/* SDVO LVDS is cloneable because the SDVO encoder does the upscaling,
-	 * as opposed to native LVDS, where we upscale with the panel-fitter
-	 * (and hence only the native LVDS resolution could be cloned). */
-	intel_sdvo->base.cloneable = true;
+	/* SDVO LVDS is not cloneable because the input mode gets adjusted by the encoder */
+	intel_sdvo->base.cloneable = false;
 
 	intel_sdvo_connector_init(intel_sdvo_connector, intel_sdvo);
 	if (!intel_sdvo_create_enhance_property(intel_sdvo, intel_sdvo_connector))