| Message ID | FCCFB4CDC6E5564B9182F639FC35608702EA9675F9@dbde02.ent.ti.com (mailing list archive) |
|---|---|
| State | Accepted |
| Commit | 210d83e199f47b5aecce8cbb2bddb2554460afae |
| Headers | show |
Ping. Any inputs on number of gpio's wrongly defined for OMAP34xx? >-----Original Message----- >From: linux-omap-owner@vger.kernel.org [mailto:linux-omap-owner@vger.kernel.org] On Behalf Of >Pandita, Vikram >Sent: Monday, April 06, 2009 6:40 PM >To: linux-omap@vger.kernel.org >Subject: Query: Num GPIO lines > > >Why for OMAP34xx is number of GPIO's 160? >As per 3430 TRM, there are 6 banks [0 to 191] > >Signed-off-by: Tom Rix <Tom.Rix@windriver.com> >Signed-off-by: Vikram Pandita <vikram.pandita@ti.com> >--- >diff --git a/arch/arm/plat-omap/gpio.c b/arch/arm/plat-omap/gpio.c >index 17d7afe..ee0b21f 100644 >--- a/arch/arm/plat-omap/gpio.c >+++ b/arch/arm/plat-omap/gpio.c >@@ -307,7 +307,7 @@ static inline int gpio_valid(int gpio) > return 0; > if (cpu_is_omap24xx() && gpio < 128) > return 0; >- if (cpu_is_omap34xx() && gpio < 160) >+ if (cpu_is_omap34xx() && gpio < 192) > return 0; > return -1; > } >-- >To unsubscribe from this list: send the line "unsubscribe linux-omap" in >the body of a message to majordomo@vger.kernel.org >More majordomo info at http://vger.kernel.org/majordomo-info.html -- To unsubscribe from this list: send the line "unsubscribe linux-omap" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
* Pandita, Vikram <vikram.pandita@ti.com> [090422 18:17]: > > Ping. Any inputs on number of gpio's wrongly defined for OMAP34xx? Sounds like a good bug fix! I'll add it to omap-fixes queue. Tony > > >-----Original Message----- > >From: linux-omap-owner@vger.kernel.org [mailto:linux-omap-owner@vger.kernel.org] On Behalf Of > >Pandita, Vikram > >Sent: Monday, April 06, 2009 6:40 PM > >To: linux-omap@vger.kernel.org > >Subject: Query: Num GPIO lines > > > > > >Why for OMAP34xx is number of GPIO's 160? > >As per 3430 TRM, there are 6 banks [0 to 191] > > > >Signed-off-by: Tom Rix <Tom.Rix@windriver.com> > >Signed-off-by: Vikram Pandita <vikram.pandita@ti.com> > >--- > >diff --git a/arch/arm/plat-omap/gpio.c b/arch/arm/plat-omap/gpio.c > >index 17d7afe..ee0b21f 100644 > >--- a/arch/arm/plat-omap/gpio.c > >+++ b/arch/arm/plat-omap/gpio.c > >@@ -307,7 +307,7 @@ static inline int gpio_valid(int gpio) > > return 0; > > if (cpu_is_omap24xx() && gpio < 128) > > return 0; > >- if (cpu_is_omap34xx() && gpio < 160) > >+ if (cpu_is_omap34xx() && gpio < 192) > > return 0; > > return -1; > > } > >-- > >To unsubscribe from this list: send the line "unsubscribe linux-omap" in > >the body of a message to majordomo@vger.kernel.org > >More majordomo info at http://vger.kernel.org/majordomo-info.html > > -- > To unsubscribe from this list: send the line "unsubscribe linux-omap" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html -- To unsubscribe from this list: send the line "unsubscribe linux-omap" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
This patch has been applied to the linux-omap by youw fwiendly patch wobot. Initial commit ID (Likely to change): 210d83e199f47b5aecce8cbb2bddb2554460afae PatchWorks http://patchwork.kernel.org/patch/16691/ Git (Likely to change, and takes a while to get mirrored) http://git.kernel.org/?p=linux/kernel/git/tmlind/linux-omap-2.6.git;a=commit;h=210d83e199f47b5aecce8cbb2bddb2554460afae -- To unsubscribe from this list: send the line "unsubscribe linux-omap" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
diff --git a/arch/arm/plat-omap/gpio.c b/arch/arm/plat-omap/gpio.c index 17d7afe..ee0b21f 100644 --- a/arch/arm/plat-omap/gpio.c +++ b/arch/arm/plat-omap/gpio.c @@ -307,7 +307,7 @@ static inline int gpio_valid(int gpio) return 0; if (cpu_is_omap24xx() && gpio < 128) return 0; - if (cpu_is_omap34xx() && gpio < 160) + if (cpu_is_omap34xx() && gpio < 192) return 0; return -1; }