From patchwork Wed Oct 31 09:11:49 2012 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Daniel Vetter X-Patchwork-Id: 1676861 Return-Path: X-Original-To: patchwork-dri-devel@patchwork.kernel.org Delivered-To: patchwork-process-083081@patchwork2.kernel.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) by patchwork2.kernel.org (Postfix) with ESMTP id A28FDDF2F6 for ; Wed, 31 Oct 2012 09:22:18 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 7192EA0A83 for ; Wed, 31 Oct 2012 02:22:18 -0700 (PDT) X-Original-To: dri-devel@lists.freedesktop.org Delivered-To: dri-devel@lists.freedesktop.org Received: from mail-ee0-f49.google.com (mail-ee0-f49.google.com [74.125.83.49]) by gabe.freedesktop.org (Postfix) with ESMTP id E736F9F651 for ; Wed, 31 Oct 2012 02:20:22 -0700 (PDT) Received: by mail-ee0-f49.google.com with SMTP id c1so618176eek.36 for ; Wed, 31 Oct 2012 02:20:22 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ffwll.ch; s=google; h=from:to:cc:subject:date:message-id:x-mailer:in-reply-to:references; bh=Pk7luVDszDk5d4bftTvVKCz51rlG043D0XOSJO6YRMM=; b=TtW6cjOlWWSbAD80GiAGA7QNX46gKFPTzJx+brM/jyRthNYxLtY5SMpY1sw3eT93eW NpQLhFi+nChJWgHpuKCryNB925mK10uLlr9OUYPhdAfYMSgiAjasDO5o54Sj+1toxCN7 +aFgP7o4lXTlCg/Cr4+efrfEScv/h75hN8C38= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20120113; h=from:to:cc:subject:date:message-id:x-mailer:in-reply-to:references :x-gm-message-state; bh=Pk7luVDszDk5d4bftTvVKCz51rlG043D0XOSJO6YRMM=; b=oJWTT35uKOnQUkQWSz/xAVnGzG7ugM/JCZ5i0dNZutDUrSYJlr6GjUDQ8RSyIkclEO wf5ziYzMGQJxVoE6hUgn1VEre5vAopY3/TEDqZB+NjBdBW9ab9yAr3C2Nc6bgrFavswv 2s8wLJIqGdI7Uy7pClyE4qIDnp53R8wmtzP/wIdYvsNRZYWBz27jGwuAtuE6NXZFXjy5 0WhwcR8lbJ2N2Y81Z2Og+CNqMse6F5vNm9ypgwFUbbFGCU/dDRt70kLRxWTZIBbqY1Qc ySGB64WYUMAFnPJcE1WMyws6nFpmY0kvlSsuwV6WTtZWDKvXCIoVKeD0T1ZsNKSIfWVw SJgQ== Received: by 10.14.173.71 with SMTP id u47mr83132495eel.20.1351675222684; Wed, 31 Oct 2012 02:20:22 -0700 (PDT) Received: from wespe.ffwll.local (178-83-130-250.dynamic.hispeed.ch. [178.83.130.250]) by mx.google.com with ESMTPS id f3sm6784078eeo.13.2012.10.31.02.20.21 (version=TLSv1/SSLv3 cipher=OTHER); Wed, 31 Oct 2012 02:20:22 -0700 (PDT) From: Daniel Vetter To: DRI Development Subject: [PATCH 3/4] drm/doc: integrate fb helper reference into docs Date: Wed, 31 Oct 2012 10:11:49 +0100 Message-Id: <1351674710-11629-3-git-send-email-daniel.vetter@ffwll.ch> X-Mailer: git-send-email 1.7.11.7 In-Reply-To: <1351674710-11629-1-git-send-email-daniel.vetter@ffwll.ch> References: <3853113.57kDjBA5be@avalon> <1351674710-11629-1-git-send-email-daniel.vetter@ffwll.ch> X-Gm-Message-State: ALoCoQk8/PSLkumaYUfbnAjSNm+SnK6AL5YvR4x9d56IaoQVBkdEIeTUgG7UGp1MuFMDEhKPasBv Cc: Daniel Vetter , Intel Graphics Development , Laurent Pinchart X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Sender: dri-devel-bounces+patchwork-dri-devel=patchwork.kernel.org@lists.freedesktop.org Errors-To: dri-devel-bounces+patchwork-dri-devel=patchwork.kernel.org@lists.freedesktop.org Again only minimal changes to make kerneldoc no longer shout. Plus a little introduction in the form of a inline DOC: section to quickly explain what this is all about. Signed-off-by: Daniel Vetter Acked-by: Laurent Pinchart --- Documentation/DocBook/drm.tmpl | 5 +++++ drivers/gpu/drm/drm_fb_helper.c | 19 ++++++++++++++----- 2 files changed, 19 insertions(+), 5 deletions(-) diff --git a/Documentation/DocBook/drm.tmpl b/Documentation/DocBook/drm.tmpl index 43e706e..15729eb 100644 --- a/Documentation/DocBook/drm.tmpl +++ b/Documentation/DocBook/drm.tmpl @@ -2110,6 +2110,11 @@ void intel_crt_init(struct drm_device *dev) Modeset Helper Functions Reference !Edrivers/gpu/drm/drm_crtc_helper.c + + fbdev Helper Functions Reference +!Pdrivers/gpu/drm/drm_fb_helper.c fbdev helpers +!Edrivers/gpu/drm/drm_fb_helper.c + diff --git a/drivers/gpu/drm/drm_fb_helper.c b/drivers/gpu/drm/drm_fb_helper.c index 4d58d7e..b6e9893 100644 --- a/drivers/gpu/drm/drm_fb_helper.c +++ b/drivers/gpu/drm/drm_fb_helper.c @@ -41,7 +41,14 @@ MODULE_AUTHOR("David Airlie, Jesse Barnes"); MODULE_DESCRIPTION("DRM KMS helper"); MODULE_LICENSE("GPL and additional rights"); -static LIST_HEAD(kernel_fb_helper_list); +/** + * DOC: fbdev helpers + * + * The fb helper functions are useful to provide an fbdev on top of a drm kernel + * mode setting driver. They can be used mostly independantely from the crtc + * helper functions used by many drivers to implement the kernel mode setting + * interfaces. static LIST_HEAD(kernel_fb_helper_list). + */ /* simple single crtc case helper function */ int drm_fb_helper_single_add_all_connectors(struct drm_fb_helper *fb_helper) @@ -1291,12 +1298,14 @@ static void drm_setup_crtcs(struct drm_fb_helper *fb_helper) /** * drm_helper_initial_config - setup a sane initial connector configuration - * @dev: DRM device + * @fb_helper: fb_helper device struct + * @bpp_sel: bpp value to use for the framebuffer configuration * * LOCKING: - * Called at init time, must take mode config lock. + * Called at init time by the driver to set up the @fb_helper initial + * configuration, must take mode config lock. * - * Scan the CRTCs and connectors and try to put together an initial setup. + * Scans the CRTCs and connectors and tries to put together an initial setup. * At the moment, this is a cloned configuration across all heads with * a new framebuffer object as the backing store. * @@ -1330,7 +1339,7 @@ EXPORT_SYMBOL(drm_fb_helper_initial_config); /** * drm_fb_helper_hotplug_event - respond to a hotplug notification by - * probing all the outputs attached to the fb. + * probing all the outputs attached to the fb * @fb_helper: the drm_fb_helper * * LOCKING: