[prio] Memory leak if failed to do RTPG.

Commit Message

Konrad Rzeszutek April 8, 2009, 10:11 p.m. UTC

We don't de-alloc the buf variable if we fail on the first
do_rtpg call.
---
 libmultipath/prioritizers/alua_rtpg.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

Patch

diff --git a/libmultipath/prioritizers/alua_rtpg.c b/libmultipath/prioritizers/alua_rtpg.c
index 7151cdd..5a8a59f 100644
--- a/libmultipath/prioritizers/alua_rtpg.c
+++ b/libmultipath/prioritizers/alua_rtpg.c
@@ -263,7 +263,7 @@  get_asymmetric_access_state(int fd, unsigned int tpg)
 	}
 	rc = do_rtpg(fd, buf, buflen);
 	if (rc < 0)
-		return rc;
+		goto out;
 	scsi_buflen = buf[0] << 24 | buf[1] << 16 | buf[2] << 8 | buf[3];
 	if (buflen < (scsi_buflen + 4)) {
 		free(buf);