Patchwork mfd: tps65910: Select REGMAP_IRQ in Kconfig to fix build error

login
register
mail settings
Submitter AnilKumar, Chimata
Date Dec. 10, 2012, 11:14 a.m.
Message ID <1355138096-7702-1-git-send-email-anilkumar@ti.com>
Download mbox | patch
Permalink /patch/1857701/
State New, archived
Headers show

Comments

AnilKumar, Chimata - Dec. 10, 2012, 11:14 a.m.
TPS65910 mfd driver uses functions that are only avaiable when
REGMAP_IRQ is enabled. So "select REGMAP_IRQ" is added to mfd
Kconfig to fix below build error:

drivers/built-in.o: In function `tps65910_irq_exit':
/media/anil/kernel/drivers/mfd/tps65910.c:265: undefined reference to `regmap_del_irq_chip'
drivers/built-in.o: In function `tps65910_irq_init':
/media/anil/kernel/drivers/mfd/tps65910.c:254: undefined reference to `regmap_add_irq_chip'
drivers/built-in.o: In function `tps65910_i2c_probe':
/media/anil/kernel/drivers/mfd/tps65910.c:509: undefined reference to `regmap_irq_get_domain'
make: *** [vmlinux] Error 1

Signed-off-by: AnilKumar Ch <anilkumar@ti.com>
---
 drivers/mfd/Kconfig |    1 +
 1 file changed, 1 insertion(+)
AnilKumar, Chimata - Dec. 17, 2012, 5:58 a.m.
On Mon, Dec 10, 2012 at 16:44:56, AnilKumar, Chimata wrote:
> TPS65910 mfd driver uses functions that are only avaiable when
> REGMAP_IRQ is enabled. So "select REGMAP_IRQ" is added to mfd
> Kconfig to fix below build error:
> 
> drivers/built-in.o: In function `tps65910_irq_exit':
> /media/anil/kernel/drivers/mfd/tps65910.c:265: undefined reference to `regmap_del_irq_chip'
> drivers/built-in.o: In function `tps65910_irq_init':
> /media/anil/kernel/drivers/mfd/tps65910.c:254: undefined reference to `regmap_add_irq_chip'
> drivers/built-in.o: In function `tps65910_i2c_probe':
> /media/anil/kernel/drivers/mfd/tps65910.c:509: undefined reference to `regmap_irq_get_domain'
> make: *** [vmlinux] Error 1
> 
> Signed-off-by: AnilKumar Ch <anilkumar@ti.com>
> ---
>  drivers/mfd/Kconfig |    1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/mfd/Kconfig b/drivers/mfd/Kconfig
> index 1c0abd4..01413a2 100644
> --- a/drivers/mfd/Kconfig
> +++ b/drivers/mfd/Kconfig
> @@ -237,6 +237,7 @@ config MFD_TPS65910
>  	depends on I2C=y && GPIOLIB
>  	select MFD_CORE
>  	select REGMAP_I2C
> +	select REGMAP_IRQ
>  	select IRQ_DOMAIN
>  	help
>  	  if you say yes here you get support for the TPS65910 series of

Hi Samuel,

If there are no comments on this patch could you please pull?

Thanks
AnilKumar
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/
AnilKumar, Chimata - Jan. 2, 2013, 10:15 a.m.
On Mon, Dec 10, 2012 at 16:44:56, AnilKumar, Chimata wrote:
> TPS65910 mfd driver uses functions that are only avaiable when
> REGMAP_IRQ is enabled. So "select REGMAP_IRQ" is added to mfd
> Kconfig to fix below build error:
> 
> drivers/built-in.o: In function `tps65910_irq_exit':
> /media/anil/kernel/drivers/mfd/tps65910.c:265: undefined reference to `regmap_del_irq_chip'
> drivers/built-in.o: In function `tps65910_irq_init':
> /media/anil/kernel/drivers/mfd/tps65910.c:254: undefined reference to `regmap_add_irq_chip'
> drivers/built-in.o: In function `tps65910_i2c_probe':
> /media/anil/kernel/drivers/mfd/tps65910.c:509: undefined reference to `regmap_irq_get_domain'
> make: *** [vmlinux] Error 1
> 
> Signed-off-by: AnilKumar Ch <anilkumar@ti.com>
> ---
>  drivers/mfd/Kconfig |    1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/mfd/Kconfig b/drivers/mfd/Kconfig
> index 1c0abd4..01413a2 100644
> --- a/drivers/mfd/Kconfig
> +++ b/drivers/mfd/Kconfig
> @@ -237,6 +237,7 @@ config MFD_TPS65910
>  	depends on I2C=y && GPIOLIB
>  	select MFD_CORE
>  	select REGMAP_I2C
> +	select REGMAP_IRQ
>  	select IRQ_DOMAIN
>  	help
>  	  if you say yes here you get support for the TPS65910 series of

Hi Samuel,

Could you please pull this fix?

Thanks
AnilKumar
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/
Matt Porter - Jan. 9, 2013, 4:52 p.m.
On Wed, Jan 02, 2013 at 10:15:39AM +0000, AnilKumar wrote:
> On Mon, Dec 10, 2012 at 16:44:56, AnilKumar, Chimata wrote:
> > TPS65910 mfd driver uses functions that are only avaiable when
> > REGMAP_IRQ is enabled. So "select REGMAP_IRQ" is added to mfd
> > Kconfig to fix below build error:
> > 
> > drivers/built-in.o: In function `tps65910_irq_exit':
> > /media/anil/kernel/drivers/mfd/tps65910.c:265: undefined reference to `regmap_del_irq_chip'
> > drivers/built-in.o: In function `tps65910_irq_init':
> > /media/anil/kernel/drivers/mfd/tps65910.c:254: undefined reference to `regmap_add_irq_chip'
> > drivers/built-in.o: In function `tps65910_i2c_probe':
> > /media/anil/kernel/drivers/mfd/tps65910.c:509: undefined reference to `regmap_irq_get_domain'
> > make: *** [vmlinux] Error 1
> > 
> > Signed-off-by: AnilKumar Ch <anilkumar@ti.com>
> > ---
> >  drivers/mfd/Kconfig |    1 +
> >  1 file changed, 1 insertion(+)
> > 
> > diff --git a/drivers/mfd/Kconfig b/drivers/mfd/Kconfig
> > index 1c0abd4..01413a2 100644
> > --- a/drivers/mfd/Kconfig
> > +++ b/drivers/mfd/Kconfig
> > @@ -237,6 +237,7 @@ config MFD_TPS65910
> >  	depends on I2C=y && GPIOLIB
> >  	select MFD_CORE
> >  	select REGMAP_I2C
> > +	select REGMAP_IRQ
> >  	select IRQ_DOMAIN
> >  	help
> >  	  if you say yes here you get support for the TPS65910 series of
> 
> Hi Samuel,
> 
> Could you please pull this fix?
 
Tested-by: Matt Porter <mporter@ti.com>

Fixes broken OMAP kernel build here too.

-Matt
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/
AnilKumar, Chimata - Jan. 18, 2013, 11:12 a.m.
On Wed, Jan 09, 2013 at 22:22:35, Porter, Matt wrote:
> On Wed, Jan 02, 2013 at 10:15:39AM +0000, AnilKumar wrote:
> > On Mon, Dec 10, 2012 at 16:44:56, AnilKumar, Chimata wrote:
> > > TPS65910 mfd driver uses functions that are only avaiable when
> > > REGMAP_IRQ is enabled. So "select REGMAP_IRQ" is added to mfd
> > > Kconfig to fix below build error:
> > > 
> > > drivers/built-in.o: In function `tps65910_irq_exit':
> > > /media/anil/kernel/drivers/mfd/tps65910.c:265: undefined reference to `regmap_del_irq_chip'
> > > drivers/built-in.o: In function `tps65910_irq_init':
> > > /media/anil/kernel/drivers/mfd/tps65910.c:254: undefined reference to `regmap_add_irq_chip'
> > > drivers/built-in.o: In function `tps65910_i2c_probe':
> > > /media/anil/kernel/drivers/mfd/tps65910.c:509: undefined reference to `regmap_irq_get_domain'
> > > make: *** [vmlinux] Error 1
> > > 
> > > Signed-off-by: AnilKumar Ch <anilkumar@ti.com>
> > > ---
> > >  drivers/mfd/Kconfig |    1 +
> > >  1 file changed, 1 insertion(+)
> > > 
> > > diff --git a/drivers/mfd/Kconfig b/drivers/mfd/Kconfig
> > > index 1c0abd4..01413a2 100644
> > > --- a/drivers/mfd/Kconfig
> > > +++ b/drivers/mfd/Kconfig
> > > @@ -237,6 +237,7 @@ config MFD_TPS65910
> > >  	depends on I2C=y && GPIOLIB
> > >  	select MFD_CORE
> > >  	select REGMAP_I2C
> > > +	select REGMAP_IRQ
> > >  	select IRQ_DOMAIN
> > >  	help
> > >  	  if you say yes here you get support for the TPS65910 series of
> > 
> > Hi Samuel,
> > 
> > Could you please pull this fix?
>  
> Tested-by: Matt Porter <mporter@ti.com>
> 
> Fixes broken OMAP kernel build here too.
> 

Hi Samuel,

Could you please take this in?

Thanks
AnilKumar
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/
Samuel Ortiz - Jan. 22, 2013, 12:28 a.m.
Hi Anilkumar,

On Mon, Dec 10, 2012 at 04:44:56PM +0530, AnilKumar Ch wrote:
> TPS65910 mfd driver uses functions that are only avaiable when
> REGMAP_IRQ is enabled. So "select REGMAP_IRQ" is added to mfd
> Kconfig to fix below build error:
> 
> drivers/built-in.o: In function `tps65910_irq_exit':
> /media/anil/kernel/drivers/mfd/tps65910.c:265: undefined reference to `regmap_del_irq_chip'
> drivers/built-in.o: In function `tps65910_irq_init':
> /media/anil/kernel/drivers/mfd/tps65910.c:254: undefined reference to `regmap_add_irq_chip'
> drivers/built-in.o: In function `tps65910_i2c_probe':
> /media/anil/kernel/drivers/mfd/tps65910.c:509: undefined reference to `regmap_irq_get_domain'
> make: *** [vmlinux] Error 1
> 
> Signed-off-by: AnilKumar Ch <anilkumar@ti.com>
> ---
>  drivers/mfd/Kconfig |    1 +
>  1 file changed, 1 insertion(+)
Applied to my for-linus branch. Sorry for not carrying it with my 3.8 pull
request.

Cheers,
Samuel.

Patch

diff --git a/drivers/mfd/Kconfig b/drivers/mfd/Kconfig
index 1c0abd4..01413a2 100644
--- a/drivers/mfd/Kconfig
+++ b/drivers/mfd/Kconfig
@@ -237,6 +237,7 @@  config MFD_TPS65910
 	depends on I2C=y && GPIOLIB
 	select MFD_CORE
 	select REGMAP_I2C
+	select REGMAP_IRQ
 	select IRQ_DOMAIN
 	help
 	  if you say yes here you get support for the TPS65910 series of