Revert "drm: Add EDID_QUIRK_FORCE_REDUCED_BLANKING for ASUS VW222S"
diff mbox

Message ID 1358158009-7229-1-git-send-email-daniel.vetter@ffwll.ch
State New, archived
Headers show

Commit Message

Daniel Vetter Jan. 14, 2013, 10:06 a.m. UTC
This reverts commit 6f33814bd4d9cfe76033a31b1c0c76c960cd8e4b.

The quirk cause a regression, and it looks like the original bug was
simply a lack of FIFO bandwidth on the i915G of the reporter. Which
should eventually be fixed as soon as we get around to implemented
DSPARB FIFO reassignment on gen 3.

Bugzilla: https://bugzilla.kernel.org/show_bug.cgi?id=52281
Cc: stable@vger.kernel.org
Signed-off-by: Daniel Vetter <daniel.vetter@ffwll.ch>
---
 drivers/gpu/drm/drm_edid.c |    3 ---
 1 file changed, 3 deletions(-)

Comments

Paul Menzel Jan. 14, 2013, 2:37 p.m. UTC | #1
Am Montag, den 14.01.2013, 11:06 +0100 schrieb Daniel Vetter:
> This reverts commit 6f33814bd4d9cfe76033a31b1c0c76c960cd8e4b.
> 
> The quirk cause a regression, and it looks like the original bug was
> simply a lack of FIFO bandwidth on the i915G of the reporter. Which
> should eventually be fixed as soon as we get around to implemented
> DSPARB FIFO reassignment on gen 3.

Reported-by: Florian Mickler <florian@mickler.org>

> Bugzilla: https://bugzilla.kernel.org/show_bug.cgi?id=52281
> Cc: stable@vger.kernel.org
> Signed-off-by: Daniel Vetter <daniel.vetter@ffwll.ch>

Acked-by: Paul Menzel <paulepanter@users.sourceforge.net>

> ---
>  drivers/gpu/drm/drm_edid.c |    3 ---
>  1 file changed, 3 deletions(-)
> 
> diff --git a/drivers/gpu/drm/drm_edid.c b/drivers/gpu/drm/drm_edid.c
> index 5a3770f..39919f2 100644
> --- a/drivers/gpu/drm/drm_edid.c
> +++ b/drivers/gpu/drm/drm_edid.c
> @@ -87,9 +87,6 @@ static struct edid_quirk {
>  	int product_id;
>  	u32 quirks;
>  } edid_quirk_list[] = {
> -	/* ASUS VW222S */
> -	{ "ACI", 0x22a2, EDID_QUIRK_FORCE_REDUCED_BLANKING },
> -
>  	/* Acer AL1706 */
>  	{ "ACR", 44358, EDID_QUIRK_PREFER_LARGE_60 },
>  	/* Acer F51 */
Daniel Vetter Jan. 29, 2013, 2:13 p.m. UTC | #2
On Mon, Jan 14, 2013 at 3:37 PM, Paul Menzel
<paulepanter@users.sourceforge.net> wrote:
> Am Montag, den 14.01.2013, 11:06 +0100 schrieb Daniel Vetter:
>> This reverts commit 6f33814bd4d9cfe76033a31b1c0c76c960cd8e4b.
>>
>> The quirk cause a regression, and it looks like the original bug was
>> simply a lack of FIFO bandwidth on the i915G of the reporter. Which
>> should eventually be fixed as soon as we get around to implemented
>> DSPARB FIFO reassignment on gen 3.
>
> Reported-by: Florian Mickler <florian@mickler.org>
>
>> Bugzilla: https://bugzilla.kernel.org/show_bug.cgi?id=52281
>> Cc: stable@vger.kernel.org
>> Signed-off-by: Daniel Vetter <daniel.vetter@ffwll.ch>
>
> Acked-by: Paul Menzel <paulepanter@users.sourceforge.net>

Hm, revert hasn't landed anywhere yet :( Dave, Ajax: ping?
-Daniel
Jani Nikula Feb. 13, 2013, 10:05 a.m. UTC | #3
On Tue, 29 Jan 2013, Daniel Vetter <daniel.vetter@ffwll.ch> wrote:
> On Mon, Jan 14, 2013 at 3:37 PM, Paul Menzel
> <paulepanter@users.sourceforge.net> wrote:
>> Am Montag, den 14.01.2013, 11:06 +0100 schrieb Daniel Vetter:
>>> This reverts commit 6f33814bd4d9cfe76033a31b1c0c76c960cd8e4b.
>>>
>>> The quirk cause a regression, and it looks like the original bug was
>>> simply a lack of FIFO bandwidth on the i915G of the reporter. Which
>>> should eventually be fixed as soon as we get around to implemented
>>> DSPARB FIFO reassignment on gen 3.
>>
>> Reported-by: Florian Mickler <florian@mickler.org>
>>
>>> Bugzilla: https://bugzilla.kernel.org/show_bug.cgi?id=52281
>>> Cc: stable@vger.kernel.org
>>> Signed-off-by: Daniel Vetter <daniel.vetter@ffwll.ch>
>>
>> Acked-by: Paul Menzel <paulepanter@users.sourceforge.net>
>
> Hm, revert hasn't landed anywhere yet :( Dave, Ajax: ping?

100% packet loss... another ping.

BR,
Jani.

Patch
diff mbox

diff --git a/drivers/gpu/drm/drm_edid.c b/drivers/gpu/drm/drm_edid.c
index 5a3770f..39919f2 100644
--- a/drivers/gpu/drm/drm_edid.c
+++ b/drivers/gpu/drm/drm_edid.c
@@ -87,9 +87,6 @@  static struct edid_quirk {
 	int product_id;
 	u32 quirks;
 } edid_quirk_list[] = {
-	/* ASUS VW222S */
-	{ "ACI", 0x22a2, EDID_QUIRK_FORCE_REDUCED_BLANKING },
-
 	/* Acer AL1706 */
 	{ "ACR", 44358, EDID_QUIRK_PREFER_LARGE_60 },
 	/* Acer F51 */