| Message ID | 1358958309-5342-3-git-send-email-daniel.vetter@ffwll.ch (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
On Wed, Jan 23, 2013 at 05:25:09PM +0100, Daniel Vetter wrote: > One of the early return cases missed the mutex unlocking. Hilarity > ensued. > > This regression has been introduced in > > commit 7b24056be6db7ce907baffdd4cf142ab774ea60c > Author: Daniel Vetter <daniel.vetter@ffwll.ch> > Date: Wed Dec 12 00:35:33 2012 +0100 > > drm: don't hold crtc mutexes for connector ->detect callbacks > > Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=59750 > Signed-off-by: Daniel Vetter <daniel.vetter@ffwll.ch> Tested-by: Cancan Feng <cancan.feng@intel.com> Dave, please pick this one up for your drm-next tree since the issue only happens there due to the modeset locking rework. Thanks, Daniel
diff --git a/drivers/gpu/drm/i915/intel_display.c b/drivers/gpu/drm/i915/intel_display.c index 26df9e3..ece4afd 100644 --- a/drivers/gpu/drm/i915/intel_display.c +++ b/drivers/gpu/drm/i915/intel_display.c @@ -6522,6 +6522,7 @@ void intel_release_load_detect_pipe(struct drm_connector *connector, drm_framebuffer_unreference(old->release_fb); } + mutex_unlock(&crtc->mutex); return; }
One of the early return cases missed the mutex unlocking. Hilarity ensued. This regression has been introduced in commit 7b24056be6db7ce907baffdd4cf142ab774ea60c Author: Daniel Vetter <daniel.vetter@ffwll.ch> Date: Wed Dec 12 00:35:33 2012 +0100 drm: don't hold crtc mutexes for connector ->detect callbacks Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=59750 Signed-off-by: Daniel Vetter <daniel.vetter@ffwll.ch> --- drivers/gpu/drm/i915/intel_display.c | 1 + 1 file changed, 1 insertion(+)