x86, efi: remove attribute check from setup_efi_pci
diff mbox

Message ID 5107FE48.7080402@canonical.com
State New, archived
Headers show

Commit Message

Maarten Lankhorst Jan. 29, 2013, 4:52 p.m. UTC
It looks like the original commit that copied the rom contents from efi always copied
the rom, and the fixup in setup_efi_pci from commit 886d751a2ea99a160
("x86, efi: correct precedence of operators in setup_efi_pci") broke that.

This resulted in macbook pro's no longer finding the rom images, and thus not being able to use the radeon card any more.

The solution is to just remove the check for now, and always copy the rom if available.

Signed-off-by: Maarten Lankhorst <maarten.lankhorst@canonical.com>
---

Comments

Matt Fleming Jan. 29, 2013, 5:54 p.m. UTC | #1
On Tue, 2013-01-29 at 17:52 +0100, Maarten Lankhorst wrote:
> It looks like the original commit that copied the rom contents from efi always copied
> the rom, and the fixup in setup_efi_pci from commit 886d751a2ea99a160
> ("x86, efi: correct precedence of operators in setup_efi_pci") broke that.
> 
> This resulted in macbook pro's no longer finding the rom images, and thus not being able to use the radeon card any more.
> 
> The solution is to just remove the check for now, and always copy the rom if available.
> 
> Signed-off-by: Maarten Lankhorst <maarten.lankhorst@canonical.com>

Applied, thanks!

Patch
diff mbox

diff --git a/arch/x86/boot/compressed/eboot.c b/arch/x86/boot/compressed/eboot.c
index 18e329c..ce06324 100644
--- a/arch/x86/boot/compressed/eboot.c
+++ b/arch/x86/boot/compressed/eboot.c
@@ -302,9 +302,6 @@  static efi_status_t setup_efi_pci(struct boot_params *params)
 		if (status != EFI_SUCCESS)
 			continue;
 
-		if (!(attributes & EFI_PCI_IO_ATTRIBUTE_EMBEDDED_ROM))
-			continue;
-
 		if (!pci->romimage || !pci->romsize)
 			continue;