| Message ID | 1361516364-25810-1-git-send-email-anand.jain@oracle.com (mailing list archive) |
|---|---|
| State | Under Review, archived |
| Headers | show |
On Fri, Feb 22, 2013 at 02:59:24PM +0800, Anand Jain wrote: > --- a/utils.c > +++ b/utils.c > @@ -1192,12 +1192,13 @@ scan_again: > return -ENOENT; > } > /* skip the header */ > - for(i=0; i < 2 ; i++) > - if(!fgets(buf, 1023, proc_partitions)){ > - fprintf(stderr, "Unable to read '/proc/partitions' for scanning\n"); > - fclose(proc_partitions); > - return -ENOENT; > - } > + for (i=0; i < 2 ; i++) for (i = 0; i < 2; i++) If possible, It's good to fix these issues in one go, I'll fix it locally. david -- To unsubscribe from this list: send the line "unsubscribe linux-btrfs" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
On 02/27/2013 11:45 PM, David Sterba wrote: > On Fri, Feb 22, 2013 at 02:59:24PM +0800, Anand Jain wrote: >> --- a/utils.c >> +++ b/utils.c >> @@ -1192,12 +1192,13 @@ scan_again: >> return -ENOENT; >> } >> /* skip the header */ >> - for(i=0; i < 2 ; i++) >> - if(!fgets(buf, 1023, proc_partitions)){ >> - fprintf(stderr, "Unable to read '/proc/partitions' for scanning\n"); >> - fclose(proc_partitions); >> - return -ENOENT; >> - } >> + for (i=0; i < 2 ; i++) > > for (i = 0; i < 2; i++) > > If possible, It's good to fix these issues in one go, I'll fix it locally. Absolutely. Sorry my mistake. A new patch below if it helps. Thanks Anand -- To unsubscribe from this list: send the line "unsubscribe linux-btrfs" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
diff --git a/utils.c b/utils.c index d660507..9c2e510 100644 --- a/utils.c +++ b/utils.c @@ -1192,12 +1192,13 @@ scan_again: return -ENOENT; } /* skip the header */ - for(i=0; i < 2 ; i++) - if(!fgets(buf, 1023, proc_partitions)){ - fprintf(stderr, "Unable to read '/proc/partitions' for scanning\n"); - fclose(proc_partitions); - return -ENOENT; - } + for (i=0; i < 2 ; i++) + if (!fgets(buf, 1023, proc_partitions)) { + fprintf(stderr, + "Unable to read '/proc/partitions' for scanning\n"); + fclose(proc_partitions); + return -ENOENT; + } strcpy(fullpath,"/dev/"); while(fgets(buf, 1023, proc_partitions)) {
A trivial fix, corrects the indentation. Signed-off-by: Anand Jain <anand.jain@oracle.com> --- utils.c | 13 +++++++------ 1 file changed, 7 insertions(+), 6 deletions(-)