[1/3] ARM: dts: Add FIMD node to exynos5
diff mbox

Message ID 1361877940-8559-2-git-send-email-l.krishna@samsung.com
State New, archived
Headers show

Commit Message

Leela Krishna Amudala Feb. 26, 2013, 11:25 a.m. UTC
This adds common FIMD device node for all Exynos5 SoCs.

Signed-off-by: Leela Krishna Amudala <l.krishna@samsung.com>
---
 arch/arm/boot/dts/exynos5250.dtsi | 7 +++++++
 1 file changed, 7 insertions(+)

Comments

Vikas Sajjan Feb. 27, 2013, 8:45 a.m. UTC | #1
Hi Leela,

On Tue, Feb 26, 2013 at 4:55 PM, Leela Krishna Amudala
<l.krishna@samsung.com> wrote:
> This adds common FIMD device node for all Exynos5 SoCs.
>
> Signed-off-by: Leela Krishna Amudala <l.krishna@samsung.com>
> ---
>  arch/arm/boot/dts/exynos5250.dtsi | 7 +++++++
>  1 file changed, 7 insertions(+)
>
> diff --git a/arch/arm/boot/dts/exynos5250.dtsi b/arch/arm/boot/dts/exynos5250.dtsi
> index 3acf594..0ee4706 100644
> --- a/arch/arm/boot/dts/exynos5250.dtsi
> +++ b/arch/arm/boot/dts/exynos5250.dtsi
> @@ -583,4 +583,11 @@
>                 reg = <0x14450000 0x10000>;
>                 interrupts = <0 94 0>;
>         };
> +
> +       fimd {
> +               compatible = "samsung,exynos5-fimd";
I think we can modify this as "samsung,exynos5250-fimd", please refer
to the discussion at https://patchwork.kernel.org/patch/2144861/
> +               interrupt-parent = <&combiner>;
> +               reg = <0x14400000 0x40000>;
> +               interrupts = <18 5>, <18 4>, <18 6>;
> +       };
>  };
> --
> 1.8.0
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
--
To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Leela Krishna Amudala Feb. 27, 2013, 9:26 a.m. UTC | #2
Hello Vikas,

On Wed, Feb 27, 2013 at 2:15 PM, Vikas Sajjan <sajjan.linux@gmail.com> wrote:
>
> Hi Leela,
>
> On Tue, Feb 26, 2013 at 4:55 PM, Leela Krishna Amudala
> <l.krishna@samsung.com> wrote:
> > This adds common FIMD device node for all Exynos5 SoCs.
> >
> > Signed-off-by: Leela Krishna Amudala <l.krishna@samsung.com>
> > ---
> >  arch/arm/boot/dts/exynos5250.dtsi | 7 +++++++
> >  1 file changed, 7 insertions(+)
> >
> > diff --git a/arch/arm/boot/dts/exynos5250.dtsi
> > b/arch/arm/boot/dts/exynos5250.dtsi
> > index 3acf594..0ee4706 100644
> > --- a/arch/arm/boot/dts/exynos5250.dtsi
> > +++ b/arch/arm/boot/dts/exynos5250.dtsi
> > @@ -583,4 +583,11 @@
> >                 reg = <0x14450000 0x10000>;
> >                 interrupts = <0 94 0>;
> >         };
> > +
> > +       fimd {
> > +               compatible = "samsung,exynos5-fimd";
> I think we can modify this as "samsung,exynos5250-fimd", please refer
> to the discussion at https://patchwork.kernel.org/patch/2144861/

Then in that case this compatible string has to be modify in driver also.

Best wishes,
Leela Krishna Amudala.

> > +               interrupt-parent = <&combiner>;
> > +               reg = <0x14400000 0x40000>;
> > +               interrupts = <18 5>, <18 4>, <18 6>;
> > +       };
> >  };
> > --
> > 1.8.0
> >
> > --
> > To unsubscribe from this list: send the line "unsubscribe
> > linux-samsung-soc" in
> > the body of a message to majordomo@vger.kernel.org
> > More majordomo info at  http://vger.kernel.org/majordomo-info.html
> --
> To unsubscribe from this list: send the line "unsubscribe
> linux-samsung-soc" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
--
To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Vikas Sajjan Feb. 27, 2013, 9:48 a.m. UTC | #3
Hi Leela,

On Wed, Feb 27, 2013 at 2:56 PM, Leela Krishna Amudala
<l.krishna@samsung.com> wrote:
> Hello Vikas,
>
> On Wed, Feb 27, 2013 at 2:15 PM, Vikas Sajjan <sajjan.linux@gmail.com> wrote:
>>
>> Hi Leela,
>>
>> On Tue, Feb 26, 2013 at 4:55 PM, Leela Krishna Amudala
>> <l.krishna@samsung.com> wrote:
>> > This adds common FIMD device node for all Exynos5 SoCs.
>> >
>> > Signed-off-by: Leela Krishna Amudala <l.krishna@samsung.com>
>> > ---
>> >  arch/arm/boot/dts/exynos5250.dtsi | 7 +++++++
>> >  1 file changed, 7 insertions(+)
>> >
>> > diff --git a/arch/arm/boot/dts/exynos5250.dtsi
>> > b/arch/arm/boot/dts/exynos5250.dtsi
>> > index 3acf594..0ee4706 100644
>> > --- a/arch/arm/boot/dts/exynos5250.dtsi
>> > +++ b/arch/arm/boot/dts/exynos5250.dtsi
>> > @@ -583,4 +583,11 @@
>> >                 reg = <0x14450000 0x10000>;
>> >                 interrupts = <0 94 0>;
>> >         };
>> > +
>> > +       fimd {
>> > +               compatible = "samsung,exynos5-fimd";
>> I think we can modify this as "samsung,exynos5250-fimd", please refer
>> to the discussion at https://patchwork.kernel.org/patch/2144861/
>
> Then in that case this compatible string has to be modify in driver also.

yea, right. Will be posting the changes soon.

>
> Best wishes,
> Leela Krishna Amudala.
>
>> > +               interrupt-parent = <&combiner>;
>> > +               reg = <0x14400000 0x40000>;
>> > +               interrupts = <18 5>, <18 4>, <18 6>;
>> > +       };
>> >  };
>> > --
>> > 1.8.0
>> >
>> > --
>> > To unsubscribe from this list: send the line "unsubscribe
>> > linux-samsung-soc" in
>> > the body of a message to majordomo@vger.kernel.org
>> > More majordomo info at  http://vger.kernel.org/majordomo-info.html
>> --
>> To unsubscribe from this list: send the line "unsubscribe
>> linux-samsung-soc" in
>> the body of a message to majordomo@vger.kernel.org
>> More majordomo info at  http://vger.kernel.org/majordomo-info.html
--
To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Patch
diff mbox

diff --git a/arch/arm/boot/dts/exynos5250.dtsi b/arch/arm/boot/dts/exynos5250.dtsi
index 3acf594..0ee4706 100644
--- a/arch/arm/boot/dts/exynos5250.dtsi
+++ b/arch/arm/boot/dts/exynos5250.dtsi
@@ -583,4 +583,11 @@ 
 		reg = <0x14450000 0x10000>;
 		interrupts = <0 94 0>;
 	};
+
+	fimd {
+		compatible = "samsung,exynos5-fimd";
+		interrupt-parent = <&combiner>;
+		reg = <0x14400000 0x40000>;
+		interrupts = <18 5>, <18 4>, <18 6>;
+	};
 };