usb: phy: samsung: let it be built as a module
diff mbox

Message ID 1361962133-21296-1-git-send-email-balbi@ti.com
State New, archived
Headers show

Commit Message

Felipe Balbi Feb. 27, 2013, 10:48 a.m. UTC
There's no reason not to allow samsung PHY
drivers be built as modules. This patch changes
Kconfig to allow that.

Signed-off-by: Felipe Balbi <balbi@ti.com>
---

Hi,

I will take your patches but I'm planning to add this on top
as there is no reason not to allow these drivers being built
as modules.

cheers

 drivers/usb/phy/Kconfig | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

Comments

Vivek Gautam Feb. 27, 2013, 12:01 p.m. UTC | #1
Hi Felipe,


On Wed, Feb 27, 2013 at 4:18 PM, Felipe Balbi <balbi@ti.com> wrote:
> There's no reason not to allow samsung PHY
> drivers be built as modules. This patch changes
> Kconfig to allow that.
>
> Signed-off-by: Felipe Balbi <balbi@ti.com>
> ---
>
> Hi,
>
> I will take your patches but I'm planning to add this on top
> as there is no reason not to allow these drivers being built
> as modules.
>

aargh !! my bad :-(
actually missed exporting the symbols in drivers/usb/phy/samsung-usbphy.c
Getting compile errors.
Shall i just update the patch [PATCH v5 0/2] Adding USB 3.0 DRD-phy
support for exynos5250
or send a separate patch on top so that you can squash this change
along with. ;-)

> cheers
>
>  drivers/usb/phy/Kconfig | 6 +++---
>  1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/usb/phy/Kconfig b/drivers/usb/phy/Kconfig
> index 723d7b1..4f696d0 100644
> --- a/drivers/usb/phy/Kconfig
> +++ b/drivers/usb/phy/Kconfig
> @@ -67,7 +67,7 @@ config USB_RCAR_PHY
>           module will be called rcar-phy.
>
>  config SAMSUNG_USB2PHY
> -       bool "Samsung USB 2.0 PHY controller Driver"
> +       tristate "Samsung USB 2.0 PHY controller Driver"
>         select SAMSUNG_USBPHY
>         select USB_OTG_UTILS
>         help
> @@ -75,7 +75,7 @@ config SAMSUNG_USB2PHY
>           driver for Samsung SoCs.
>
>  config SAMSUNG_USB3PHY
> -       bool "Samsung USB 3.0 PHY controller Driver"
> +       tristate "Samsung USB 3.0 PHY controller Driver"
>         select SAMSUNG_USBPHY
>         select USB_OTG_UTILS
>         help
> @@ -83,7 +83,7 @@ config SAMSUNG_USB3PHY
>           for samsung SoCs.
>
>  config SAMSUNG_USBPHY
> -       bool "Samsung USB PHY Driver"
> +       tristate "Samsung USB PHY Driver"
>         help
>           Enable this to support Samsung USB phy helper driver for Samsung SoCs.
>           This driver provides common interface to interact, for Samsung USB 2.0 PHY
> --
> 1.8.1.rc1.5.g7e0651a
>
Felipe Balbi Feb. 27, 2013, 12:13 p.m. UTC | #2
Hi,

On Wed, Feb 27, 2013 at 05:31:53PM +0530, Vivek Gautam wrote:
> Hi Felipe,
> 
> 
> On Wed, Feb 27, 2013 at 4:18 PM, Felipe Balbi <balbi@ti.com> wrote:
> > There's no reason not to allow samsung PHY
> > drivers be built as modules. This patch changes
> > Kconfig to allow that.
> >
> > Signed-off-by: Felipe Balbi <balbi@ti.com>
> > ---
> >
> > Hi,
> >
> > I will take your patches but I'm planning to add this on top
> > as there is no reason not to allow these drivers being built
> > as modules.
> >
> 
> aargh !! my bad :-(
> actually missed exporting the symbols in drivers/usb/phy/samsung-usbphy.c
> Getting compile errors.
> Shall i just update the patch [PATCH v5 0/2] Adding USB 3.0 DRD-phy
> support for exynos5250
> or send a separate patch on top so that you can squash this change
> along with. ;-)

there's still time to update the original. I'll drop all 3 patches for
now (both of yours and mine).

cheers
Vivek Gautam Feb. 27, 2013, 12:17 p.m. UTC | #3
On Wed, Feb 27, 2013 at 5:43 PM, Felipe Balbi <balbi@ti.com> wrote:
> Hi,
>
> On Wed, Feb 27, 2013 at 05:31:53PM +0530, Vivek Gautam wrote:
>> Hi Felipe,
>>
>>
>> On Wed, Feb 27, 2013 at 4:18 PM, Felipe Balbi <balbi@ti.com> wrote:
>> > There's no reason not to allow samsung PHY
>> > drivers be built as modules. This patch changes
>> > Kconfig to allow that.
>> >
>> > Signed-off-by: Felipe Balbi <balbi@ti.com>
>> > ---
>> >
>> > Hi,
>> >
>> > I will take your patches but I'm planning to add this on top
>> > as there is no reason not to allow these drivers being built
>> > as modules.
>> >
>>
>> aargh !! my bad :-(
>> actually missed exporting the symbols in drivers/usb/phy/samsung-usbphy.c
>> Getting compile errors.
>> Shall i just update the patch [PATCH v5 0/2] Adding USB 3.0 DRD-phy
>> support for exynos5250
>> or send a separate patch on top so that you can squash this change
>> along with. ;-)
>
> there's still time to update the original. I'll drop all 3 patches for
> now (both of yours and mine).
>

Alright, i shall update the original patches and resend them after
adding this change for
EXPORT_SYMBOL_GPL() and also squashing your change for "modules".
Felipe Balbi Feb. 27, 2013, 12:24 p.m. UTC | #4
On Wed, Feb 27, 2013 at 05:47:29PM +0530, Vivek Gautam wrote:
> On Wed, Feb 27, 2013 at 5:43 PM, Felipe Balbi <balbi@ti.com> wrote:
> > Hi,
> >
> > On Wed, Feb 27, 2013 at 05:31:53PM +0530, Vivek Gautam wrote:
> >> Hi Felipe,
> >>
> >>
> >> On Wed, Feb 27, 2013 at 4:18 PM, Felipe Balbi <balbi@ti.com> wrote:
> >> > There's no reason not to allow samsung PHY
> >> > drivers be built as modules. This patch changes
> >> > Kconfig to allow that.
> >> >
> >> > Signed-off-by: Felipe Balbi <balbi@ti.com>
> >> > ---
> >> >
> >> > Hi,
> >> >
> >> > I will take your patches but I'm planning to add this on top
> >> > as there is no reason not to allow these drivers being built
> >> > as modules.
> >> >
> >>
> >> aargh !! my bad :-(
> >> actually missed exporting the symbols in drivers/usb/phy/samsung-usbphy.c
> >> Getting compile errors.
> >> Shall i just update the patch [PATCH v5 0/2] Adding USB 3.0 DRD-phy
> >> support for exynos5250
> >> or send a separate patch on top so that you can squash this change
> >> along with. ;-)
> >
> > there's still time to update the original. I'll drop all 3 patches for
> > now (both of yours and mine).
> >
> 
> Alright, i shall update the original patches and resend them after
> adding this change for
> EXPORT_SYMBOL_GPL() and also squashing your change for "modules".

k, thanks

Patch
diff mbox

diff --git a/drivers/usb/phy/Kconfig b/drivers/usb/phy/Kconfig
index 723d7b1..4f696d0 100644
--- a/drivers/usb/phy/Kconfig
+++ b/drivers/usb/phy/Kconfig
@@ -67,7 +67,7 @@  config USB_RCAR_PHY
 	  module will be called rcar-phy.
 
 config SAMSUNG_USB2PHY
-	bool "Samsung USB 2.0 PHY controller Driver"
+	tristate "Samsung USB 2.0 PHY controller Driver"
 	select SAMSUNG_USBPHY
 	select USB_OTG_UTILS
 	help
@@ -75,7 +75,7 @@  config SAMSUNG_USB2PHY
 	  driver for Samsung SoCs.
 
 config SAMSUNG_USB3PHY
-	bool "Samsung USB 3.0 PHY controller Driver"
+	tristate "Samsung USB 3.0 PHY controller Driver"
 	select SAMSUNG_USBPHY
 	select USB_OTG_UTILS
 	help
@@ -83,7 +83,7 @@  config SAMSUNG_USB3PHY
 	  for samsung SoCs.
 
 config SAMSUNG_USBPHY
-	bool "Samsung USB PHY Driver"
+	tristate "Samsung USB PHY Driver"
 	help
 	  Enable this to support Samsung USB phy helper driver for Samsung SoCs.
 	  This driver provides common interface to interact, for Samsung USB 2.0 PHY