[4/4] ARM: s3c24xx: Fix switching FIFO in arch_enable_uart_fifo function
diff mbox

Message ID 1362216174-10478-4-git-send-email-shc_work@mail.ru
State New, archived
Headers show

Commit Message

Alexander Shiyan March 2, 2013, 9:22 a.m. UTC
When CONFIG_S3C_BOOT_UART_FORCE_FIFO symbol is set, we should
enable FIFO but actually switch command is missing in the code.
This patch adds this switch.

Signed-off-by: Alexander Shiyan <shc_work@mail.ru>
---
 arch/arm/plat-samsung/include/plat/uncompress.h | 2 ++
 1 file changed, 2 insertions(+)

Comments

Kim Kukjin April 4, 2013, 1:01 a.m. UTC | #1
Alexander Shiyan wrote:
> 
> When CONFIG_S3C_BOOT_UART_FORCE_FIFO symbol is set, we should
> enable FIFO but actually switch command is missing in the code.
> This patch adds this switch.
> 
> Signed-off-by: Alexander Shiyan <shc_work@mail.ru>
> ---
>  arch/arm/plat-samsung/include/plat/uncompress.h | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/arch/arm/plat-samsung/include/plat/uncompress.h
> b/arch/arm/plat-samsung/include/plat/uncompress.h
> index 438b248..30fedd9 100644
> --- a/arch/arm/plat-samsung/include/plat/uncompress.h
> +++ b/arch/arm/plat-samsung/include/plat/uncompress.h
> @@ -130,6 +130,8 @@ static inline void arch_enable_uart_fifo(void)
>  			if (!(fifocon & S3C2410_UFCON_RESETBOTH))
>  				break;
>  		}
> +
> +		uart_wr(S3C2410_UFCON, S3C2410_UFCON_FIFOMODE);

Well, I think, if required, this should be moved into 'if (!(fifocon &
S3C2410_UFCON_FIFOMODE))'.

- Kukjin

--
To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Alexander Shiyan April 4, 2013, 6:54 p.m. UTC | #2
Hello.

> Alexander Shiyan wrote:
> > 
> > When CONFIG_S3C_BOOT_UART_FORCE_FIFO symbol is set, we should
> > enable FIFO but actually switch command is missing in the code.
> > This patch adds this switch.
> > 
> > Signed-off-by: Alexander Shiyan <shc_work@mail.ru>
> > ---
> >  arch/arm/plat-samsung/include/plat/uncompress.h | 2 ++
> >  1 file changed, 2 insertions(+)
> > 
> > diff --git a/arch/arm/plat-samsung/include/plat/uncompress.h
> > b/arch/arm/plat-samsung/include/plat/uncompress.h
> > index 438b248..30fedd9 100644
> > --- a/arch/arm/plat-samsung/include/plat/uncompress.h
> > +++ b/arch/arm/plat-samsung/include/plat/uncompress.h
> > @@ -130,6 +130,8 @@ static inline void arch_enable_uart_fifo(void)
> >  			if (!(fifocon & S3C2410_UFCON_RESETBOTH))
> >  				break;
> >  		}
> > +
> > +		uart_wr(S3C2410_UFCON, S3C2410_UFCON_FIFOMODE);
> 
> Well, I think, if required, this should be moved into 'if (!(fifocon &
> S3C2410_UFCON_FIFOMODE))'.

Already here.

---

Patch
diff mbox

diff --git a/arch/arm/plat-samsung/include/plat/uncompress.h b/arch/arm/plat-samsung/include/plat/uncompress.h
index 438b248..30fedd9 100644
--- a/arch/arm/plat-samsung/include/plat/uncompress.h
+++ b/arch/arm/plat-samsung/include/plat/uncompress.h
@@ -130,6 +130,8 @@  static inline void arch_enable_uart_fifo(void)
 			if (!(fifocon & S3C2410_UFCON_RESETBOTH))
 				break;
 		}
+
+		uart_wr(S3C2410_UFCON, S3C2410_UFCON_FIFOMODE);
 	}
 }
 #else