diff mbox

[5/8] gem_exec_nop.c: add vebox test case

Message ID 1366700809-18143-6-git-send-email-zhong.li@intel.com (mailing list archive)
State New, archived
Headers show

Commit Message

zhong.li@intel.com April 23, 2013, 7:06 a.m. UTC
Signed-off-by: Zhong Li <zhong.li@intel.com>
---
 tests/gem_exec_nop.c |    5 ++++-
 1 file changed, 4 insertions(+), 1 deletion(-)

Comments

Ben Widawsky April 27, 2013, 6:45 p.m. UTC | #1
On Tue, Apr 23, 2013 at 03:06:45PM +0800, Zhong Li wrote:
> Signed-off-by: Zhong Li <zhong.li@intel.com>
> ---
>  tests/gem_exec_nop.c |    5 ++++-
>  1 file changed, 4 insertions(+), 1 deletion(-)
> 
> diff --git a/tests/gem_exec_nop.c b/tests/gem_exec_nop.c
> index 8608592..d0fa5d5 100644
> --- a/tests/gem_exec_nop.c
> +++ b/tests/gem_exec_nop.c
> @@ -133,7 +133,10 @@ int main(int argc, char **argv)
>  	if (drmtest_run_subtest("blt"))
>  		if (HAS_BLT_RING(devid))
>  			loop(fd, handle, I915_EXEC_BLT, "blt");
> -
> +	
> +	if (drmtest_run_subtest("vebox"))
> +		if (HAS_BLT_RING(devid))
> +			loop(fd, handle, I915_EXEC_VEBOX, "vebox");
>  
>  	gem_close(fd, handle);
>  
> -- 
> 1.7.9.5
> 

Patch has the same problems as the previous ones. Fixed locally.

I don't mind so much that you made copy/paste mistakes since I do that
ALL the time too. The whitespace mistakes however should be part of your
editor setup. Please try to correct that ASAP.
zhong.li@intel.com April 28, 2013, 6:07 a.m. UTC | #2
Sorry for the copy error. In fact, I was going to send out patches which fix it.
Thanks

-----Original Message-----
From: Ben Widawsky [mailto:benjamin.widawsky@intel.com] 
Sent: Sunday, April 28, 2013 2:46 AM
To: Li, Zhong
Cc: intel-gfx@lists.freedesktop.org; Xiang, Haihao; Vetter, Daniel
Subject: Re: [PATCH 5/8] gem_exec_nop.c: add vebox test case

On Tue, Apr 23, 2013 at 03:06:45PM +0800, Zhong Li wrote:
> Signed-off-by: Zhong Li <zhong.li@intel.com>
> ---
>  tests/gem_exec_nop.c |    5 ++++-
>  1 file changed, 4 insertions(+), 1 deletion(-)
> 
> diff --git a/tests/gem_exec_nop.c b/tests/gem_exec_nop.c index 
> 8608592..d0fa5d5 100644
> --- a/tests/gem_exec_nop.c
> +++ b/tests/gem_exec_nop.c
> @@ -133,7 +133,10 @@ int main(int argc, char **argv)
>  	if (drmtest_run_subtest("blt"))
>  		if (HAS_BLT_RING(devid))
>  			loop(fd, handle, I915_EXEC_BLT, "blt");
> -
> +	
> +	if (drmtest_run_subtest("vebox"))
> +		if (HAS_BLT_RING(devid))
> +			loop(fd, handle, I915_EXEC_VEBOX, "vebox");
>  
>  	gem_close(fd, handle);
>  
> --
> 1.7.9.5
> 

Patch has the same problems as the previous ones. Fixed locally.

I don't mind so much that you made copy/paste mistakes since I do that
ALL the time too. The whitespace mistakes however should be part of your
editor setup. Please try to correct that ASAP.
diff mbox

Patch

diff --git a/tests/gem_exec_nop.c b/tests/gem_exec_nop.c
index 8608592..d0fa5d5 100644
--- a/tests/gem_exec_nop.c
+++ b/tests/gem_exec_nop.c
@@ -133,7 +133,10 @@  int main(int argc, char **argv)
 	if (drmtest_run_subtest("blt"))
 		if (HAS_BLT_RING(devid))
 			loop(fd, handle, I915_EXEC_BLT, "blt");
-
+	
+	if (drmtest_run_subtest("vebox"))
+		if (HAS_BLT_RING(devid))
+			loop(fd, handle, I915_EXEC_VEBOX, "vebox");
 
 	gem_close(fd, handle);