[-next] ia64, metag: Do not export min_low_pfn in arch-specific code
diff mbox

Message ID 1367086831-10740-1-git-send-email-geert@linux-m68k.org
State New, archived
Headers show

Commit Message

Geert Uytterhoeven April 27, 2013, 6:20 p.m. UTC
As of commit 787dcbe6984b3638e94f60d807dcb51bb8a07211 ("MIPS: Export
symbols used by KVM/MIPS module"), min_low_pfn is already exported by
the generic mm/bootmem.c, causing:

WARNING: vmlinux: 'min_low_pfn' exported twice. Previous export was in vmlinux

Signed-off-by: Geert Uytterhoeven <geert@linux-m68k.org>
---
 arch/ia64/kernel/ia64_ksyms.c   |    1 -
 arch/metag/kernel/metag_ksyms.c |    1 -
 2 files changed, 0 insertions(+), 2 deletions(-)

Comments

James Hogan April 28, 2013, 10:24 a.m. UTC | #1
On 27 April 2013 19:20, Geert Uytterhoeven <geert@linux-m68k.org> wrote:
> As of commit 787dcbe6984b3638e94f60d807dcb51bb8a07211 ("MIPS: Export
> symbols used by KVM/MIPS module"), min_low_pfn is already exported by
> the generic mm/bootmem.c, causing:
>
> WARNING: vmlinux: 'min_low_pfn' exported twice. Previous export was in vmlinux
>
> Signed-off-by: Geert Uytterhoeven <geert@linux-m68k.org>

This has been pointed out several times and needs fixing in the mips
tree where the warning was introduced.

Acked-by: James Hogan <james.hogan@imgtec.com>

Cheers
James
--
To unsubscribe from this list: send the line "unsubscribe kvm" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Ralf Baechle May 22, 2013, 5:57 p.m. UTC | #2
On Sun, Apr 28, 2013 at 11:24:35AM +0100, James Hogan wrote:

> On 27 April 2013 19:20, Geert Uytterhoeven <geert@linux-m68k.org> wrote:
> > As of commit 787dcbe6984b3638e94f60d807dcb51bb8a07211 ("MIPS: Export
> > symbols used by KVM/MIPS module"), min_low_pfn is already exported by
> > the generic mm/bootmem.c, causing:
> >
> > WARNING: vmlinux: 'min_low_pfn' exported twice. Previous export was in vmlinux
> >
> > Signed-off-by: Geert Uytterhoeven <geert@linux-m68k.org>
> 
> This has been pointed out several times and needs fixing in the mips
> tree where the warning was introduced.

I've changed the MIPS code to no longer require the export of min_low_pfn
and dropped the export of that particular file.  I still see that IA-64
and metag export min_low_pfn so maybe it should be exported from mm/
after all?

  Ralf
--
To unsubscribe from this list: send the line "unsubscribe kvm" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Patch
diff mbox

diff --git a/arch/ia64/kernel/ia64_ksyms.c b/arch/ia64/kernel/ia64_ksyms.c
index 5b7791d..ca95c8b 100644
--- a/arch/ia64/kernel/ia64_ksyms.c
+++ b/arch/ia64/kernel/ia64_ksyms.c
@@ -25,7 +25,6 @@  EXPORT_SYMBOL(copy_page);
 
 #ifdef CONFIG_VIRTUAL_MEM_MAP
 #include <linux/bootmem.h>
-EXPORT_SYMBOL(min_low_pfn);	/* defined by bootmem.c, but not exported by generic code */
 EXPORT_SYMBOL(max_low_pfn);	/* defined by bootmem.c, but not exported by generic code */
 #endif
 
diff --git a/arch/metag/kernel/metag_ksyms.c b/arch/metag/kernel/metag_ksyms.c
index ec872ef..08e9b6f 100644
--- a/arch/metag/kernel/metag_ksyms.c
+++ b/arch/metag/kernel/metag_ksyms.c
@@ -12,7 +12,6 @@  EXPORT_SYMBOL(copy_page);
 #ifdef CONFIG_FLATMEM
 /* needed for the pfn_valid macro */
 EXPORT_SYMBOL(max_pfn);
-EXPORT_SYMBOL(min_low_pfn);
 #endif
 
 /* TBI symbols */