Patchwork Btrfs: free csums when we're done scrubbing an extent

login
register
mail settings
Submitter Josef Bacik
Date June 10, 2013, 12:59 p.m.
Message ID <1370869144-1524-1-git-send-email-jbacik@fusionio.com>
Download mbox | patch
Permalink /patch/2697501/
State Accepted, archived
Headers show

Comments

Josef Bacik - June 10, 2013, 12:59 p.m.
A user reported scrub taking up an unreasonable amount of ram as it ran.  This
is because we lookup the csums for the extent we're scrubbing but don't free it
up until after we're done with the scrub, which means we can take up a whole lot
of ram.  This patch fixes this by dropping the csums once we're done with the
extent we've scrubbed.  The user reported this to fix their problem.  Thanks,

Reported-and-tested-by: Remco Hosman <remco@hosman.xs4all.nl>
Signed-off-by: Josef Bacik <jbacik@fusionio.com>
---
 fs/btrfs/scrub.c | 1 +
 1 file changed, 1 insertion(+)

Patch

diff --git a/fs/btrfs/scrub.c b/fs/btrfs/scrub.c
index d485055..63144e4 100644
--- a/fs/btrfs/scrub.c
+++ b/fs/btrfs/scrub.c
@@ -2499,6 +2499,7 @@  again:
 			if (ret)
 				goto out;
 
+			scrub_free_csums(sctx);
 			if (extent_logical + extent_len <
 			    key.objectid + bytes) {
 				logical += increment;