From patchwork Mon Jun 10 14:09:18 2013 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Alex Deucher X-Patchwork-Id: 2697681 Return-Path: X-Original-To: patchwork-intel-gfx@patchwork.kernel.org Delivered-To: patchwork-process-083081@patchwork2.kernel.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) by patchwork2.kernel.org (Postfix) with ESMTP id 2DDF3DF264 for ; Mon, 10 Jun 2013 14:10:20 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 26731E5F4C for ; Mon, 10 Jun 2013 07:10:20 -0700 (PDT) X-Original-To: intel-gfx@lists.freedesktop.org Delivered-To: intel-gfx@lists.freedesktop.org Received: from mail-vc0-f170.google.com (mail-vc0-f170.google.com [209.85.220.170]) by gabe.freedesktop.org (Postfix) with ESMTP id 28980E5C90; Mon, 10 Jun 2013 07:09:19 -0700 (PDT) Received: by mail-vc0-f170.google.com with SMTP id hf12so4469845vcb.1 for ; Mon, 10 Jun 2013 07:09:18 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :cc:content-type; bh=stqQMrSom9zCa1le3UDthLWGBMHqq9xZvOQsEWB3eLk=; b=uv96Nnq2Af7UZjcd/e8qB0s7HvQo8snMOqi8EIhDCiqkhTYUkXHlU9CmniMTkIXX73 nocBt/ar2E/KpqqzRptnFo3N1K2jlniJNolxEWKa20KgiCB4Un4QJhbVLMvvKDml/+Ne AJlW+jHPK6RjxUHbp23IUljqRLM4OUjeaOOfSaqSr5dT5ACre8I6ZzCM0sNrpjnrTl0Q HPVaB3YWwxxnX5UQxwHrY0bTicUescw3vhC5qEoni4Q0rBEpLqSOJ0VVIH0eL/7Q6bIO O11NKv1wcT8kSX+jtN6YW5XGcekhw/besPb6jwRg4uO3ayxRsTcoLoo1GSEl4x+K7mCs fIdw== MIME-Version: 1.0 X-Received: by 10.221.4.131 with SMTP id oc3mr5599371vcb.49.1370873358655; Mon, 10 Jun 2013 07:09:18 -0700 (PDT) Received: by 10.58.29.3 with HTTP; Mon, 10 Jun 2013 07:09:18 -0700 (PDT) In-Reply-To: <1370818899-8595-4-git-send-email-matthew.garrett@nebula.com> References: <1370818899-8595-1-git-send-email-matthew.garrett@nebula.com> <1370818899-8595-4-git-send-email-matthew.garrett@nebula.com> Date: Mon, 10 Jun 2013 10:09:18 -0400 Message-ID: From: Alex Deucher To: Matthew Garrett Cc: seth.forshee@canonical.com, daniel.vetter@ffwll.ch, intel-gfx@lists.freedesktop.org, linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, rjw@sisk.pl, linux-acpi@vger.kernel.org, joeyli.kernel@gmail.com, lenb@kernel.org Subject: Re: [Intel-gfx] [PATCH 3/3] i915: Don't provide ACPI backlight interface if firmware expects Windows 8 X-BeenThere: intel-gfx@lists.freedesktop.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: Intel graphics driver community testing & development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: intel-gfx-bounces+patchwork-intel-gfx=patchwork.kernel.org@lists.freedesktop.org Errors-To: intel-gfx-bounces+patchwork-intel-gfx=patchwork.kernel.org@lists.freedesktop.org Radeon probably needs something similar. See attached untested patch. Alex On Sun, Jun 9, 2013 at 7:01 PM, Matthew Garrett wrote: > Windows 8 leaves backlight control up to individual graphics drivers rather > than making ACPI calls itself. There's plenty of evidence to suggest that > the Intel driver for Windows doesn't use the ACPI interface, including the > fact that it's broken on a bunch of machines when the OS claims to support > Windows 8. The simplest thing to do appears to be to disable the ACPI > backlight interface on these systems. > > Signed-off-by: Matthew Garrett > --- > drivers/gpu/drm/i915/i915_dma.c | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/drivers/gpu/drm/i915/i915_dma.c b/drivers/gpu/drm/i915/i915_dma.c > index 3b315ba..23b6292 100644 > --- a/drivers/gpu/drm/i915/i915_dma.c > +++ b/drivers/gpu/drm/i915/i915_dma.c > @@ -1661,6 +1661,9 @@ int i915_driver_load(struct drm_device *dev, unsigned long flags) > /* Must be done after probing outputs */ > intel_opregion_init(dev); > acpi_video_register(); > + /* Don't use ACPI backlight functions on Windows 8 platforms */ > + if (acpi_osi_version() >= ACPI_OSI_WIN_8) > + acpi_video_backlight_unregister(); > } > > if (IS_GEN5(dev)) > -- > 1.8.2.1 > > _______________________________________________ > dri-devel mailing list > dri-devel@lists.freedesktop.org > http://lists.freedesktop.org/mailman/listinfo/dri-devel From c6ead3429fd3977b4b2ee5748d83c72272592b29 Mon Sep 17 00:00:00 2001 From: Alex Deucher Date: Mon, 10 Jun 2013 10:05:43 -0400 Subject: [PATCH] drm/radeon: don't provide ACPI backlight if firmware expects Windows 8 Windows 8 leaves backlight control up to individual graphics drivers rather than making ACPI calls itself. Untested. Signed-off-by: Alex Deucher --- drivers/gpu/drm/radeon/atombios_encoders.c | 4 ++++ 1 files changed, 4 insertions(+), 0 deletions(-) diff --git a/drivers/gpu/drm/radeon/atombios_encoders.c b/drivers/gpu/drm/radeon/atombios_encoders.c index 4120d35..bc9e007 100644 --- a/drivers/gpu/drm/radeon/atombios_encoders.c +++ b/drivers/gpu/drm/radeon/atombios_encoders.c @@ -233,6 +233,10 @@ void radeon_atom_backlight_init(struct radeon_encoder *radeon_encoder, DRM_INFO("radeon atom DIG backlight initialized\n"); + /* Don't use ACPI backlight functions on Windows 8 platforms */ + if (acpi_osi_version() >= ACPI_OSI_WIN_8) + acpi_video_backlight_unregister(); + return; error: -- 1.7.7.5