From patchwork Tue Jun 11 22:49:26 2013 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?St=C3=A9phane_Marchesin?= X-Patchwork-Id: 2707341 Return-Path: X-Original-To: patchwork-intel-gfx@patchwork.kernel.org Delivered-To: patchwork-parsemail@patchwork1.web.kernel.org Received: from mail.kernel.org (mail.kernel.org [198.145.19.201]) by patchwork1.web.kernel.org (Postfix) with ESMTP id 3FBC29F8E1 for ; Tue, 11 Jun 2013 22:49:56 +0000 (UTC) Received: from mail.kernel.org (localhost [127.0.0.1]) by mail.kernel.org (Postfix) with ESMTP id 5DA042038B for ; Tue, 11 Jun 2013 22:49:55 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) by mail.kernel.org (Postfix) with ESMTP id 9E69B20387 for ; Tue, 11 Jun 2013 22:49:50 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 8FDE6E6267 for ; Tue, 11 Jun 2013 15:49:50 -0700 (PDT) X-Original-To: intel-gfx@lists.freedesktop.org Delivered-To: intel-gfx@lists.freedesktop.org Received: from mail-pd0-f169.google.com (mail-pd0-f169.google.com [209.85.192.169]) by gabe.freedesktop.org (Postfix) with ESMTP id 51937E617D for ; Tue, 11 Jun 2013 15:49:40 -0700 (PDT) Received: by mail-pd0-f169.google.com with SMTP id y10so9172240pdj.0 for ; Tue, 11 Jun 2013 15:49:40 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=from:to:cc:subject:date:message-id:x-mailer:mime-version :content-type:content-transfer-encoding; bh=p0FqhB0x3zKyPtLo6igmPWPjGSDMIDH3jq8LH9LPBoQ=; b=XYELwETq+dmDWzAB/F5YeeQ+EhaR1Yj/A2Us/3pFqF21ii71Ag5kbI3sgJbMephbEc A1adwww/0ynLQGJoCZ1HMtqaR8noLbPLqnx9hbWKP7tSKNDIONcMqcr5A6nkWs6Qj4j6 vRc8yW+COyjI2hWC4GxisVS8JWtsuDI5RtdS0= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20120113; h=from:to:cc:subject:date:message-id:x-mailer:mime-version :content-type:content-transfer-encoding:x-gm-message-state; bh=p0FqhB0x3zKyPtLo6igmPWPjGSDMIDH3jq8LH9LPBoQ=; b=j7y8cGOdshoKfVu5I6l1hDh9QHMKKKy/kAgk8oKQU8R1hsDUDT1XWTYto+lOAyfQt+ NiFD/JFzQhBpb6lE2qEfO9FCoMKVKqK4KT8rAQnrbMlwN2OfrZKsVblfsmy9huc7+uJq 52um7xEX3jsB8jnHHJr0PFjmJGYw67lEgTrOu9XRvfQSkfjOu6FvhThq3ELxI6RLAT03 IwdodoVJiBPobpFFM5jt2b+pBH5JvpL0IwizcLm/KuyQM5+hetLUi48JQ5uG8lZyeRTD ZWIQbc34HOiGtNoH3oTGVR+7D0HK3tCNAzodnmkMNzbaeSkEy2lzRnwb85ApWXTaFVOd e54g== X-Received: by 10.66.162.135 with SMTP id ya7mr21074697pab.173.1370990979986; Tue, 11 Jun 2013 15:49:39 -0700 (PDT) Received: from localhost ([2620:0:1000:1b01:82c1:6eff:fef8:b068]) by mx.google.com with ESMTPSA id xj9sm9924459pbc.16.2013.06.11.15.49.38 for (version=TLSv1.2 cipher=RC4-SHA bits=128/128); Tue, 11 Jun 2013 15:49:38 -0700 (PDT) From: =?UTF-8?q?St=C3=A9phane=20Marchesin?= To: intel-gfx@lists.freedesktop.org Date: Tue, 11 Jun 2013 15:49:26 -0700 Message-Id: <1370990967-22892-1-git-send-email-marcheu@chromium.org> X-Mailer: git-send-email 1.8.3 MIME-Version: 1.0 X-Gm-Message-State: ALoCoQkzwGXR+9e3v1ZNfLuVbjI6fCrF4cwkNL+unnYgCiUIwSPp0dUuWgs5EOUVNwc37hjttgSr Cc: daniel.vetter@ffwll.ch Subject: [Intel-gfx] [PATCH 1/2] drm/i915: tune the RC6 threshold for stability X-BeenThere: intel-gfx@lists.freedesktop.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: Intel graphics driver community testing & development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: intel-gfx-bounces+patchwork-intel-gfx=patchwork.kernel.org@lists.freedesktop.org Errors-To: intel-gfx-bounces+patchwork-intel-gfx=patchwork.kernel.org@lists.freedesktop.org X-Spam-Status: No, score=-4.3 required=5.0 tests=BAYES_00,DKIM_SIGNED, RCVD_IN_DNSWL_MED,RP_MATCHES_RCVD,T_DKIM_INVALID,UNPARSEABLE_RELAY autolearn=ham version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on mail.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP It's basically the same deal as the RC6+ issues on ivy bridge except this time with RC6 on sandy bridge. Like last time the core of the issue is that the timings don't work 100% with our voltage regulator. So from time to time, the kernel will print a warning message about the GPU not getting out of RC6. In particular, I found this fairly easy to reproduce during suspend/resume. Changing the threshold to 150000 instead of 50000 seems to fix the issue. I also measured the idle power usage before/after this patch and didn't see a difference on a sandy bridge laptop. Signed-off-by: Stéphane Marchesin Acked-by: Chris Wilson --- drivers/gpu/drm/i915/intel_pm.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/i915/intel_pm.c b/drivers/gpu/drm/i915/intel_pm.c index aa01128..52fe8f7 100644 --- a/drivers/gpu/drm/i915/intel_pm.c +++ b/drivers/gpu/drm/i915/intel_pm.c @@ -2577,7 +2577,7 @@ static void gen6_enable_rps(struct drm_device *dev) I915_WRITE(GEN6_RC_SLEEP, 0); I915_WRITE(GEN6_RC1e_THRESHOLD, 1000); - I915_WRITE(GEN6_RC6_THRESHOLD, 50000); + I915_WRITE(GEN6_RC6_THRESHOLD, 150000); I915_WRITE(GEN6_RC6p_THRESHOLD, 150000); I915_WRITE(GEN6_RC6pp_THRESHOLD, 64000); /* unused */