xfstests: make the scratch device for generic/256 slightly larger
diff mbox

Message ID 1372792638-23957-1-git-send-email-jbacik@fusionio.com
State Not Applicable
Headers show

Commit Message

Josef Bacik July 2, 2013, 7:17 p.m. UTC
This is similar to a previous fix I sent.  1 gig makes us do mixed file block
groups for btrfs, so these enospc tests will usually fail because we don't have
space for metadata, which is the case for this test.  So jack the size up to
1.5gig so that btrfs can do its normal thing and pass the test.  Thanks,

Signed-off-by: Josef Bacik <jbacik@fusionio.com>
---
 tests/generic/256 |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

Comments

Ben Myers July 24, 2013, 11:07 p.m. UTC | #1
On Tue, Jul 02, 2013 at 03:17:18PM -0400, Josef Bacik wrote:
> This is similar to a previous fix I sent.  1 gig makes us do mixed file block
> groups for btrfs, so these enospc tests will usually fail because we don't have
> space for metadata, which is the case for this test.  So jack the size up to
> 1.5gig so that btrfs can do its normal thing and pass the test.  Thanks,
> 
> Signed-off-by: Josef Bacik <jbacik@fusionio.com>

Looks fine to me.  

Reviewed-by: Ben Myers <bpm@sgi.com>
--
To unsubscribe from this list: send the line "unsubscribe linux-btrfs" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Rich Johnston Aug. 16, 2013, 2:12 p.m. UTC | #2
Hey Josef,

Sorry this took so long to commit, I did not see it had been reviewed.

Thanks again for the patch
--Rich

commit 617491caf44d5e93006d774da95f532e9d7de4c4
Author: Josef Bacik <jbacik@fusionio.com>
Date:   Tue Jul 2 19:17:18 2013 +0000

--
To unsubscribe from this list: send the line "unsubscribe linux-btrfs" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Patch
diff mbox

diff --git a/tests/generic/256 b/tests/generic/256
index 4a53da8..cfe7237 100755
--- a/tests/generic/256
+++ b/tests/generic/256
@@ -165,7 +165,7 @@  _test_full_fs_punch()
 
 # Make a small file system to fill
 umount $SCRATCH_DEV &> /dev/null
-_scratch_mkfs_sized $(( 1024 * 1024 * 1024 )) &> /dev/null
+_scratch_mkfs_sized $(( 1536 * 1024 * 1024 )) &> /dev/null
 _scratch_mount
 # Test must be able to write files with non-root permissions
 chmod 777 $SCRATCH_MNT