[v2] mmc: omap_hsmmc: use the generic config for omap2plus devices
diff mbox

Message ID 1373472384-13067-1-git-send-email-a-bindra@ti.com
State New, archived
Headers show

Commit Message

a-bindra@ti.com July 10, 2013, 4:06 p.m. UTC
From: Amarinder Bindra <a-bindra@ti.com>

OMAP's hs_mmc driver is used for MMC controller operation on many
omap2plus SoCs (OMAP2430, OMAP3, 4, 5 and AM335x).

Considering that the device tree entries are already present for these,
allow the driver to be built using the config ARCH_OMAP2PLUS rather
than individually adding a config for each SoC to enable the
support.

Use COMPILE_TEST to enable the build for other platforms.

Signed-off-by: Amarinder Bindra <a-bindra@ti.com>
Cc: Ezequiel Garcia <ezequiel.garcia@free-electrons.com>
Cc: Felipe Balbi <balbi@ti.com>
Cc: Nishanth Menon <nm@ti.com>
---
Changes in v2:
- Use the config ARCH_OMAP2PLUS to enable the driver
- Use COMPILE_TEST
- Update the commit message

v1: https://patchwork.kernel.org/patch/2824632/ 

 drivers/mmc/host/Kconfig |    6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

Comments

Nishanth Menon July 10, 2013, 9:13 p.m. UTC | #1
On 21:36-20130710, a-bindra@ti.com wrote:
> From: Amarinder Bindra <a-bindra@ti.com>
> 
> OMAP's hs_mmc driver is used for MMC controller operation on many
> omap2plus SoCs (OMAP2430, OMAP3, 4, 5 and AM335x).
> 
> Considering that the device tree entries are already present for these,
> allow the driver to be built using the config ARCH_OMAP2PLUS rather
> than individually adding a config for each SoC to enable the
> support.
> 
> Use COMPILE_TEST to enable the build for other platforms.
> 
> Signed-off-by: Amarinder Bindra <a-bindra@ti.com>
> Cc: Ezequiel Garcia <ezequiel.garcia@free-electrons.com>
> Cc: Felipe Balbi <balbi@ti.com>
> Cc: Nishanth Menon <nm@ti.com>
works for O5.

Acked-by: Nishanth Menon <nm@ti.com>
Ezequiel Garcia July 10, 2013, 10:42 p.m. UTC | #2
On Wed, Jul 10, 2013 at 09:36:24PM +0530, a-bindra@ti.com wrote:
> From: Amarinder Bindra <a-bindra@ti.com>
> 
> OMAP's hs_mmc driver is used for MMC controller operation on many
> omap2plus SoCs (OMAP2430, OMAP3, 4, 5 and AM335x).
> 
> Considering that the device tree entries are already present for these,
> allow the driver to be built using the config ARCH_OMAP2PLUS rather
> than individually adding a config for each SoC to enable the
> support.
> 
> Use COMPILE_TEST to enable the build for other platforms.
> 
> Signed-off-by: Amarinder Bindra <a-bindra@ti.com>
> Cc: Ezequiel Garcia <ezequiel.garcia@free-electrons.com>
> Cc: Felipe Balbi <balbi@ti.com>
> Cc: Nishanth Menon <nm@ti.com>

Acked-by: Ezequiel Garcia <ezequiel.garcia@free-electrons.com>
Felipe Balbi July 11, 2013, 1:09 p.m. UTC | #3
On Wed, Jul 10, 2013 at 09:36:24PM +0530, a-bindra@ti.com wrote:
> From: Amarinder Bindra <a-bindra@ti.com>
> 
> OMAP's hs_mmc driver is used for MMC controller operation on many
> omap2plus SoCs (OMAP2430, OMAP3, 4, 5 and AM335x).
> 
> Considering that the device tree entries are already present for these,
> allow the driver to be built using the config ARCH_OMAP2PLUS rather
> than individually adding a config for each SoC to enable the
> support.
> 
> Use COMPILE_TEST to enable the build for other platforms.
> 
> Signed-off-by: Amarinder Bindra <a-bindra@ti.com>
> Cc: Ezequiel Garcia <ezequiel.garcia@free-electrons.com>
> Cc: Felipe Balbi <balbi@ti.com>
> Cc: Nishanth Menon <nm@ti.com>

Acked-by: Felipe Balbi <balbi@ti.com>
Balaji T K Aug. 16, 2013, 4:35 p.m. UTC | #4
On Thursday 11 July 2013 06:39 PM, Felipe Balbi wrote:
> On Wed, Jul 10, 2013 at 09:36:24PM +0530, a-bindra@ti.com wrote:
>> From: Amarinder Bindra <a-bindra@ti.com>
>>
>> OMAP's hs_mmc driver is used for MMC controller operation on many
>> omap2plus SoCs (OMAP2430, OMAP3, 4, 5 and AM335x).
>>
>> Considering that the device tree entries are already present for these,
>> allow the driver to be built using the config ARCH_OMAP2PLUS rather
>> than individually adding a config for each SoC to enable the
>> support.
>>
>> Use COMPILE_TEST to enable the build for other platforms.
>>
>> Signed-off-by: Amarinder Bindra <a-bindra@ti.com>
>> Cc: Ezequiel Garcia <ezequiel.garcia@free-electrons.com>
>> Cc: Felipe Balbi <balbi@ti.com>
>> Cc: Nishanth Menon <nm@ti.com>
>
> Acked-by: Felipe Balbi <balbi@ti.com>
>

Acked-by: Balaji T K <balajitk@ti.com>
--
To unsubscribe from this list: send the line "unsubscribe linux-omap" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Chris Ball Aug. 25, 2013, 7:51 p.m. UTC | #5
Hi,

On Wed, Jul 10 2013, a-bindra@ti.com wrote:
> From: Amarinder Bindra <a-bindra@ti.com>
>
> OMAP's hs_mmc driver is used for MMC controller operation on many
> omap2plus SoCs (OMAP2430, OMAP3, 4, 5 and AM335x).
>
> Considering that the device tree entries are already present for these,
> allow the driver to be built using the config ARCH_OMAP2PLUS rather
> than individually adding a config for each SoC to enable the
> support.
>
> Use COMPILE_TEST to enable the build for other platforms.
>
> Signed-off-by: Amarinder Bindra <a-bindra@ti.com>

Thanks, pushed to mmc-next for 3.12.

- Chris.

Patch
diff mbox

diff --git a/drivers/mmc/host/Kconfig b/drivers/mmc/host/Kconfig
index 009dabd..48f6fe7 100644
--- a/drivers/mmc/host/Kconfig
+++ b/drivers/mmc/host/Kconfig
@@ -254,11 +254,11 @@  config MMC_OMAP
 
 config MMC_OMAP_HS
 	tristate "TI OMAP High Speed Multimedia Card Interface support"
-	depends on SOC_OMAP2430 || ARCH_OMAP3 || ARCH_OMAP4
+	depends on ARCH_OMAP2PLUS || COMPILE_TEST
 	help
 	  This selects the TI OMAP High Speed Multimedia card Interface.
-	  If you have an OMAP2430 or OMAP3 board or OMAP4 board with a
-	  Multimedia Card slot, say Y or M here.
+	  If you have an omap2plus board with a Multimedia Card slot,
+	  say Y or M here.
 
 	  If unsure, say N.