diff mbox

[1/6] ARM: shmobile: ape6evm: add DMA support to MMCIF

Message ID 1374498981-5263-2-git-send-email-g.liakhovetski@gmx.de (mailing list archive)
State Superseded
Commit 7a2a7a371145e83ad60482313e8cd7501994df3a
Headers show

Commit Message

Guennadi Liakhovetski July 22, 2013, 1:16 p.m. UTC
Add DMA support for MMCIF on APE6EVM, using the shdma dmaengine driver.

Signed-off-by: Guennadi Liakhovetski <g.liakhovetski+renesas@gmail.com>
---
 arch/arm/mach-shmobile/board-ape6evm.c |    2 ++
 1 files changed, 2 insertions(+), 0 deletions(-)

Comments

Simon Horman Sept. 25, 2013, 6:09 a.m. UTC | #1
On Mon, Jul 22, 2013 at 03:16:16PM +0200, Guennadi Liakhovetski wrote:
> Add DMA support for MMCIF on APE6EVM, using the shdma dmaengine driver.
> 
> Signed-off-by: Guennadi Liakhovetski <g.liakhovetski+renesas@gmail.com>
> ---
>  arch/arm/mach-shmobile/board-ape6evm.c |    2 ++
>  1 files changed, 2 insertions(+), 0 deletions(-)
> 
> diff --git a/arch/arm/mach-shmobile/board-ape6evm.c b/arch/arm/mach-shmobile/board-ape6evm.c
> index 97c0dad..96a6994 100644
> --- a/arch/arm/mach-shmobile/board-ape6evm.c
> +++ b/arch/arm/mach-shmobile/board-ape6evm.c
> @@ -75,6 +75,8 @@ static struct regulator_consumer_supply fixed3v3_power_consumers[] =
>  /* MMCIF */
>  static struct sh_mmcif_plat_data mmcif0_pdata = {
>  	.caps		= MMC_CAP_8_BIT_DATA | MMC_CAP_NONREMOVABLE,
> +	.slave_id_tx	= SHDMA_SLAVE_MMCIF0_TX,
> +	.slave_id_rx	= SHDMA_SLAVE_MMCIF0_RX,
>  	.ccs_unsupported = true,
>  };

Thanks, I have queued this up for v3.13.
Please let me know if any other patches in this series are relevant for v3.13.
--
To unsubscribe from this list: send the line "unsubscribe linux-sh" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Guennadi Liakhovetski Sept. 25, 2013, 7:03 a.m. UTC | #2
Hi Simon

On Wed, 25 Sep 2013, Simon Horman wrote:

> On Mon, Jul 22, 2013 at 03:16:16PM +0200, Guennadi Liakhovetski wrote:
> > Add DMA support for MMCIF on APE6EVM, using the shdma dmaengine driver.
> > 
> > Signed-off-by: Guennadi Liakhovetski <g.liakhovetski+renesas@gmail.com>
> > ---
> >  arch/arm/mach-shmobile/board-ape6evm.c |    2 ++
> >  1 files changed, 2 insertions(+), 0 deletions(-)
> > 
> > diff --git a/arch/arm/mach-shmobile/board-ape6evm.c b/arch/arm/mach-shmobile/board-ape6evm.c
> > index 97c0dad..96a6994 100644
> > --- a/arch/arm/mach-shmobile/board-ape6evm.c
> > +++ b/arch/arm/mach-shmobile/board-ape6evm.c
> > @@ -75,6 +75,8 @@ static struct regulator_consumer_supply fixed3v3_power_consumers[] =
> >  /* MMCIF */
> >  static struct sh_mmcif_plat_data mmcif0_pdata = {
> >  	.caps		= MMC_CAP_8_BIT_DATA | MMC_CAP_NONREMOVABLE,
> > +	.slave_id_tx	= SHDMA_SLAVE_MMCIF0_TX,
> > +	.slave_id_rx	= SHDMA_SLAVE_MMCIF0_RX,
> >  	.ccs_unsupported = true,
> >  };
> 
> Thanks, I have queued this up for v3.13.
> Please let me know if any other patches in this series are relevant for v3.13.

I don't think so, no. Other patches in this series (apart from 2, which 
you already included from the earlier one today) require DMA DT support 
for other SoCs, which we dropped for the time being.

Thanks
Guennadi
---
Guennadi Liakhovetski, Ph.D.
Freelance Open-Source Software Developer
http://www.open-technology.de/
--
To unsubscribe from this list: send the line "unsubscribe linux-sh" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Simon Horman Sept. 25, 2013, 7:20 a.m. UTC | #3
On Wed, Sep 25, 2013 at 09:03:29AM +0200, Guennadi Liakhovetski wrote:
> Hi Simon
> 
> On Wed, 25 Sep 2013, Simon Horman wrote:
> 
> > On Mon, Jul 22, 2013 at 03:16:16PM +0200, Guennadi Liakhovetski wrote:
> > > Add DMA support for MMCIF on APE6EVM, using the shdma dmaengine driver.
> > > 
> > > Signed-off-by: Guennadi Liakhovetski <g.liakhovetski+renesas@gmail.com>
> > > ---
> > >  arch/arm/mach-shmobile/board-ape6evm.c |    2 ++
> > >  1 files changed, 2 insertions(+), 0 deletions(-)
> > > 
> > > diff --git a/arch/arm/mach-shmobile/board-ape6evm.c b/arch/arm/mach-shmobile/board-ape6evm.c
> > > index 97c0dad..96a6994 100644
> > > --- a/arch/arm/mach-shmobile/board-ape6evm.c
> > > +++ b/arch/arm/mach-shmobile/board-ape6evm.c
> > > @@ -75,6 +75,8 @@ static struct regulator_consumer_supply fixed3v3_power_consumers[] =
> > >  /* MMCIF */
> > >  static struct sh_mmcif_plat_data mmcif0_pdata = {
> > >  	.caps		= MMC_CAP_8_BIT_DATA | MMC_CAP_NONREMOVABLE,
> > > +	.slave_id_tx	= SHDMA_SLAVE_MMCIF0_TX,
> > > +	.slave_id_rx	= SHDMA_SLAVE_MMCIF0_RX,
> > >  	.ccs_unsupported = true,
> > >  };
> > 
> > Thanks, I have queued this up for v3.13.
> > Please let me know if any other patches in this series are relevant for v3.13.
> 
> I don't think so, no. Other patches in this series (apart from 2, which 
> you already included from the earlier one today) require DMA DT support 
> for other SoCs, which we dropped for the time being.

I have dropped this patch as I don't see SHDMA_SLAVE_MMCIF0_TX
anywhere in the renesas tree. Perhaps I need a dependency?
--
To unsubscribe from this list: send the line "unsubscribe linux-sh" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Guennadi Liakhovetski Sept. 25, 2013, 7:32 a.m. UTC | #4
Hi Simon

On Wed, 25 Sep 2013, Simon Horman wrote:

> On Wed, Sep 25, 2013 at 09:03:29AM +0200, Guennadi Liakhovetski wrote:
> > Hi Simon
> > 
> > On Wed, 25 Sep 2013, Simon Horman wrote:
> > 
> > > On Mon, Jul 22, 2013 at 03:16:16PM +0200, Guennadi Liakhovetski wrote:
> > > > Add DMA support for MMCIF on APE6EVM, using the shdma dmaengine driver.
> > > > 
> > > > Signed-off-by: Guennadi Liakhovetski <g.liakhovetski+renesas@gmail.com>
> > > > ---
> > > >  arch/arm/mach-shmobile/board-ape6evm.c |    2 ++
> > > >  1 files changed, 2 insertions(+), 0 deletions(-)
> > > > 
> > > > diff --git a/arch/arm/mach-shmobile/board-ape6evm.c b/arch/arm/mach-shmobile/board-ape6evm.c
> > > > index 97c0dad..96a6994 100644
> > > > --- a/arch/arm/mach-shmobile/board-ape6evm.c
> > > > +++ b/arch/arm/mach-shmobile/board-ape6evm.c
> > > > @@ -75,6 +75,8 @@ static struct regulator_consumer_supply fixed3v3_power_consumers[] =
> > > >  /* MMCIF */
> > > >  static struct sh_mmcif_plat_data mmcif0_pdata = {
> > > >  	.caps		= MMC_CAP_8_BIT_DATA | MMC_CAP_NONREMOVABLE,
> > > > +	.slave_id_tx	= SHDMA_SLAVE_MMCIF0_TX,
> > > > +	.slave_id_rx	= SHDMA_SLAVE_MMCIF0_RX,
> > > >  	.ccs_unsupported = true,
> > > >  };
> > > 
> > > Thanks, I have queued this up for v3.13.
> > > Please let me know if any other patches in this series are relevant for v3.13.
> > 
> > I don't think so, no. Other patches in this series (apart from 2, which 
> > you already included from the earlier one today) require DMA DT support 
> > for other SoCs, which we dropped for the time being.
> 
> I have dropped this patch as I don't see SHDMA_SLAVE_MMCIF0_TX
> anywhere in the renesas tree. Perhaps I need a dependency?

They are added in

[PATCH v5 5/7] ARM: shmobile: r8a73a4: add a DMAC platform device and clock for it

which you also presumably just applied.

Thanks
Guennadi
---
Guennadi Liakhovetski, Ph.D.
Freelance Open-Source Software Developer
http://www.open-technology.de/
--
To unsubscribe from this list: send the line "unsubscribe linux-sh" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Simon Horman Sept. 25, 2013, 7:55 a.m. UTC | #5
On Wed, Sep 25, 2013 at 09:32:38AM +0200, Guennadi Liakhovetski wrote:
> Hi Simon
> 
> On Wed, 25 Sep 2013, Simon Horman wrote:
> 
> > On Wed, Sep 25, 2013 at 09:03:29AM +0200, Guennadi Liakhovetski wrote:
> > > Hi Simon
> > > 
> > > On Wed, 25 Sep 2013, Simon Horman wrote:
> > > 
> > > > On Mon, Jul 22, 2013 at 03:16:16PM +0200, Guennadi Liakhovetski wrote:
> > > > > Add DMA support for MMCIF on APE6EVM, using the shdma dmaengine driver.
> > > > > 
> > > > > Signed-off-by: Guennadi Liakhovetski <g.liakhovetski+renesas@gmail.com>
> > > > > ---
> > > > >  arch/arm/mach-shmobile/board-ape6evm.c |    2 ++
> > > > >  1 files changed, 2 insertions(+), 0 deletions(-)
> > > > > 
> > > > > diff --git a/arch/arm/mach-shmobile/board-ape6evm.c b/arch/arm/mach-shmobile/board-ape6evm.c
> > > > > index 97c0dad..96a6994 100644
> > > > > --- a/arch/arm/mach-shmobile/board-ape6evm.c
> > > > > +++ b/arch/arm/mach-shmobile/board-ape6evm.c
> > > > > @@ -75,6 +75,8 @@ static struct regulator_consumer_supply fixed3v3_power_consumers[] =
> > > > >  /* MMCIF */
> > > > >  static struct sh_mmcif_plat_data mmcif0_pdata = {
> > > > >  	.caps		= MMC_CAP_8_BIT_DATA | MMC_CAP_NONREMOVABLE,
> > > > > +	.slave_id_tx	= SHDMA_SLAVE_MMCIF0_TX,
> > > > > +	.slave_id_rx	= SHDMA_SLAVE_MMCIF0_RX,
> > > > >  	.ccs_unsupported = true,
> > > > >  };
> > > > 
> > > > Thanks, I have queued this up for v3.13.
> > > > Please let me know if any other patches in this series are relevant for v3.13.
> > > 
> > > I don't think so, no. Other patches in this series (apart from 2, which 
> > > you already included from the earlier one today) require DMA DT support 
> > > for other SoCs, which we dropped for the time being.
> > 
> > I have dropped this patch as I don't see SHDMA_SLAVE_MMCIF0_TX
> > anywhere in the renesas tree. Perhaps I need a dependency?
> 
> They are added in
> 
> [PATCH v5 5/7] ARM: shmobile: r8a73a4: add a DMAC platform device and clock for it
> 
> which you also presumably just applied.

Thanks, silly me. I will re-queue this up.
--
To unsubscribe from this list: send the line "unsubscribe linux-sh" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
diff mbox

Patch

diff --git a/arch/arm/mach-shmobile/board-ape6evm.c b/arch/arm/mach-shmobile/board-ape6evm.c
index 97c0dad..96a6994 100644
--- a/arch/arm/mach-shmobile/board-ape6evm.c
+++ b/arch/arm/mach-shmobile/board-ape6evm.c
@@ -75,6 +75,8 @@  static struct regulator_consumer_supply fixed3v3_power_consumers[] =
 /* MMCIF */
 static struct sh_mmcif_plat_data mmcif0_pdata = {
 	.caps		= MMC_CAP_8_BIT_DATA | MMC_CAP_NONREMOVABLE,
+	.slave_id_tx	= SHDMA_SLAVE_MMCIF0_TX,
+	.slave_id_rx	= SHDMA_SLAVE_MMCIF0_RX,
 	.ccs_unsupported = true,
 };