[01/25] drm/omap: kill firstopen callback
diff mbox

Message ID 1375969295-18929-2-git-send-email-daniel.vetter@ffwll.ch
State Accepted
Headers show

Commit Message

Daniel Vetter Aug. 8, 2013, 1:41 p.m. UTC
KMS drivers really shouldn't need to do anything on firstopen, so kill
empty callbacks.

Signed-off-by: Daniel Vetter <daniel.vetter@ffwll.ch>
---
 drivers/gpu/drm/omapdrm/omap_drv.c | 7 -------
 1 file changed, 7 deletions(-)

Comments

Rob Clark Aug. 8, 2013, 2:04 p.m. UTC | #1
On Thu, Aug 8, 2013 at 9:41 AM, Daniel Vetter <daniel.vetter@ffwll.ch> wrote:
> KMS drivers really shouldn't need to do anything on firstopen, so kill
> empty callbacks.
>
> Signed-off-by: Daniel Vetter <daniel.vetter@ffwll.ch>

Acked-by: Rob Clark <robdclark@gmail.com>

> ---
>  drivers/gpu/drm/omapdrm/omap_drv.c | 7 -------
>  1 file changed, 7 deletions(-)
>
> diff --git a/drivers/gpu/drm/omapdrm/omap_drv.c b/drivers/gpu/drm/omapdrm/omap_drv.c
> index 2f9e22e..47e64f9 100644
> --- a/drivers/gpu/drm/omapdrm/omap_drv.c
> +++ b/drivers/gpu/drm/omapdrm/omap_drv.c
> @@ -524,12 +524,6 @@ static int dev_open(struct drm_device *dev, struct drm_file *file)
>         return 0;
>  }
>
> -static int dev_firstopen(struct drm_device *dev)
> -{
> -       DBG("firstopen: dev=%p", dev);
> -       return 0;
> -}
> -
>  /**
>   * lastclose - clean up after all DRM clients have exited
>   * @dev: DRM device
> @@ -609,7 +603,6 @@ static struct drm_driver omap_drm_driver = {
>                 .load = dev_load,
>                 .unload = dev_unload,
>                 .open = dev_open,
> -               .firstopen = dev_firstopen,
>                 .lastclose = dev_lastclose,
>                 .preclose = dev_preclose,
>                 .postclose = dev_postclose,
> --
> 1.8.3.2
>
> _______________________________________________
> dri-devel mailing list
> dri-devel@lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/dri-devel

Patch
diff mbox

diff --git a/drivers/gpu/drm/omapdrm/omap_drv.c b/drivers/gpu/drm/omapdrm/omap_drv.c
index 2f9e22e..47e64f9 100644
--- a/drivers/gpu/drm/omapdrm/omap_drv.c
+++ b/drivers/gpu/drm/omapdrm/omap_drv.c
@@ -524,12 +524,6 @@  static int dev_open(struct drm_device *dev, struct drm_file *file)
 	return 0;
 }
 
-static int dev_firstopen(struct drm_device *dev)
-{
-	DBG("firstopen: dev=%p", dev);
-	return 0;
-}
-
 /**
  * lastclose - clean up after all DRM clients have exited
  * @dev: DRM device
@@ -609,7 +603,6 @@  static struct drm_driver omap_drm_driver = {
 		.load = dev_load,
 		.unload = dev_unload,
 		.open = dev_open,
-		.firstopen = dev_firstopen,
 		.lastclose = dev_lastclose,
 		.preclose = dev_preclose,
 		.postclose = dev_postclose,