ARM: dts: Correct typo in use of samsung,pin-drv for exynos5250
diff mbox

Message ID 1378498192-5163-1-git-send-email-al.stone@linaro.org
State New, archived
Headers show

Commit Message

al.stone@linaro.org Sept. 6, 2013, 8:09 p.m. UTC
From: Al Stone <ahs3@redhat.com>

   Corrects an obvious typo in the Arndale pinctrl descriptions in DT.
   The samsung-pinctrl driver uses the correct name.

Signed-off-by: Al Stone <al.stone@linaro.org>
---
 arch/arm/boot/dts/exynos5250-pinctrl.dtsi | 44 +++++++++++++++----------------
 1 file changed, 22 insertions(+), 22 deletions(-)

Comments

Jingoo Han Sept. 9, 2013, 12:24 a.m. UTC | #1
On Saturday, September 07, 2013 5:10 AM, Al Stone wrote:
> 
> From: Al Stone <ahs3@redhat.com>
> 
>    Corrects an obvious typo in the Arndale pinctrl descriptions in DT.
>    The samsung-pinctrl driver uses the correct name.
> 
> Signed-off-by: Al Stone <al.stone@linaro.org>

CC'ed Kukjin Kim (Samsung-SoC Maintainer)

It looks good.
Reviewed-by: Jingoo Han <jg1.han@samsung.com>

Best regards,
Jingoo Han

> ---
>  arch/arm/boot/dts/exynos5250-pinctrl.dtsi | 44 +++++++++++++++----------------
>  1 file changed, 22 insertions(+), 22 deletions(-)
> 
> diff --git a/arch/arm/boot/dts/exynos5250-pinctrl.dtsi b/arch/arm/boot/dts/exynos5250-pinctrl.dtsi
> index 656e381..031e198 100644
> --- a/arch/arm/boot/dts/exynos5250-pinctrl.dtsi
> +++ b/arch/arm/boot/dts/exynos5250-pinctrl.dtsi
> @@ -210,21 +210,21 @@
>  			samsung,pins = "gpa0-2", "gpa0-3";
>  			samsung,pin-function = <2>;
>  			samsung,pin-pud = <0>;
> -			samaung,pin-drv = <0>;
> +			samsung,pin-drv = <0>;
>  		};
> 
>  		i2c2_bus: i2c2-bus {
>  			samsung,pins = "gpa0-6", "gpa0-7";
>  			samsung,pin-function = <3>;
>  			samsung,pin-pud = <3>;
> -			samaung,pin-drv = <0>;
> +			samsung,pin-drv = <0>;
>  		};
> 
>  		i2c2_hs_bus: i2c2-hs-bus {
>  			samsung,pins = "gpa0-6", "gpa0-7";
>  			samsung,pin-function = <4>;
>  			samsung,pin-pud = <3>;
> -			samaung,pin-drv = <0>;
> +			samsung,pin-drv = <0>;
>  		};
> 
>  		uart2_data: uart2-data {
> @@ -238,21 +238,21 @@
>  			samsung,pins = "gpa1-2", "gpa1-3";
>  			samsung,pin-function = <2>;
>  			samsung,pin-pud = <0>;
> -			samaung,pin-drv = <0>;
> +			samsung,pin-drv = <0>;
>  		};
> 
>  		i2c3_bus: i2c3-bus {
>  			samsung,pins = "gpa1-2", "gpa1-3";
>  			samsung,pin-function = <3>;
>  			samsung,pin-pud = <3>;
> -			samaung,pin-drv = <0>;
> +			samsung,pin-drv = <0>;
>  		};
> 
>  		i2c3_hs_bus: i2c3-hs-bus {
>  			samsung,pins = "gpa1-2", "gpa1-3";
>  			samsung,pin-function = <4>;
>  			samsung,pin-pud = <3>;
> -			samaung,pin-drv = <0>;
> +			samsung,pin-drv = <0>;
>  		};
> 
>  		uart3_data: uart3-data {
> @@ -273,14 +273,14 @@
>  			samsung,pins = "gpa2-0", "gpa2-1";
>  			samsung,pin-function = <3>;
>  			samsung,pin-pud = <3>;
> -			samaung,pin-drv = <0>;
> +			samsung,pin-drv = <0>;
>  		};
> 
>  		i2c5_bus: i2c5-bus {
>  			samsung,pins = "gpa2-2", "gpa2-3";
>  			samsung,pin-function = <3>;
>  			samsung,pin-pud = <3>;
> -			samaung,pin-drv = <0>;
> +			samsung,pin-drv = <0>;
>  		};
> 
>  		spi1_bus: spi1-bus {
> @@ -376,14 +376,14 @@
>  			samsung,pins = "gpb3-0", "gpb3-1";
>  			samsung,pin-function = <4>;
>  			samsung,pin-pud = <3>;
> -			samaung,pin-drv = <0>;
> +			samsung,pin-drv = <0>;
>  		};
> 
>  		i2c1_hs_bus: i2c1-hs-bus {
>  			samsung,pins = "gpb3-2", "gpb3-3";
>  			samsung,pin-function = <4>;
>  			samsung,pin-pud = <3>;
> -			samaung,pin-drv = <0>;
> +			samsung,pin-drv = <0>;
>  		};
> 
>  		sd0_clk: sd0-clk {
> @@ -551,14 +551,14 @@
>  			samsung,pins = "gpd0-2", "gpd0-3";
>  			samsung,pin-function = <2>;
>  			samsung,pin-pud = <0>;
> -			samaung,pin-drv = <0>;
> +			samsung,pin-drv = <0>;
>  		};
> 
>  		dp_hpd: dp_hpd {
>  			samsung,pins = "gpx0-7";
>  			samsung,pin-function = <3>;
>  			samsung,pin-pud = <0>;
> -			samaung,pin-drv = <0>;
> +			samsung,pin-drv = <0>;
>  		};
>  	};
> 
> @@ -650,42 +650,42 @@
>  				       "gpf1-0", "gpf1-1", "gpf1-2", "gpf1-3";
>  			samsung,pin-function = <3>;
>  			samsung,pin-pud = <0>;
> -			samaung,pin-drv = <0>;
> +			samsung,pin-drv = <0>;
>  		};
> 
>  		cam_i2c2_bus: cam-i2c2-bus {
>  			samsung,pins = "gpe0-6", "gpe1-0";
>  			samsung,pin-function = <4>;
>  			samsung,pin-pud = <3>;
> -			samaung,pin-drv = <0>;
> +			samsung,pin-drv = <0>;
>  		};
> 
>  		cam_spi1_bus: cam-spi1-bus {
>  			samsung,pins = "gpe0-4", "gpe0-5", "gpf0-2", "gpf0-3";
>  			samsung,pin-function = <4>;
>  			samsung,pin-pud = <0>;
> -			samaung,pin-drv = <0>;
> +			samsung,pin-drv = <0>;
>  		};
> 
>  		cam_i2c1_bus: cam-i2c1-bus {
>  			samsung,pins = "gpf0-2", "gpf0-3";
>  			samsung,pin-function = <2>;
>  			samsung,pin-pud = <3>;
> -			samaung,pin-drv = <0>;
> +			samsung,pin-drv = <0>;
>  		};
> 
>  		cam_i2c0_bus: cam-i2c0-bus {
>  			samsung,pins = "gpf0-0", "gpf0-1";
>  			samsung,pin-function = <2>;
>  			samsung,pin-pud = <3>;
> -			samaung,pin-drv = <0>;
> +			samsung,pin-drv = <0>;
>  		};
> 
>  		cam_spi0_bus: cam-spi0-bus {
>  			samsung,pins = "gpf1-0", "gpf1-1", "gpf1-2", "gpf1-3";
>  			samsung,pin-function = <2>;
>  			samsung,pin-pud = <0>;
> -			samaung,pin-drv = <0>;
> +			samsung,pin-drv = <0>;
>  		};
> 
>  		cam_bayrgb_bus: cam-bayrgb-bus {
> @@ -696,7 +696,7 @@
>  				       "gpg2-0", "gpg2-1";
>  			samsung,pin-function = <2>;
>  			samsung,pin-pud = <0>;
> -			samaung,pin-drv = <0>;
> +			samsung,pin-drv = <0>;
>  		};
> 
>  		cam_port_a: cam-port-a {
> @@ -705,7 +705,7 @@
>  				       "gph1-4", "gph1-5", "gph1-6", "gph1-7";
>  			samsung,pin-function = <2>;
>  			samsung,pin-pud = <0>;
> -			samaung,pin-drv = <0>;
> +			samsung,pin-drv = <0>;
>  		};
>  	};
> 
> @@ -757,7 +757,7 @@
>  				       "gpv1-4", "gpv1-5", "gpv1-6", "gpv1-7";
>  			samsung,pin-function = <2>;
>  			samsung,pin-pud = <0>;
> -			samaung,pin-drv = <0>;
> +			samsung,pin-drv = <0>;
>  		};
> 
>  		c2c_txd: c2c-txd {
> @@ -767,7 +767,7 @@
>  				       "gpv3-4", "gpv3-5", "gpv3-6", "gpv3-7";
>  			samsung,pin-function = <2>;
>  			samsung,pin-pud = <0>;
> -			samaung,pin-drv = <0>;
> +			samsung,pin-drv = <0>;
>  		};
>  	};
> 
> --
> 1.8.3.1
> 


--
To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Tomasz Figa Sept. 9, 2013, 9 a.m. UTC | #2
Hi Al,

On Friday 06 of September 2013 14:09:52 al.stone@linaro.org wrote:
> From: Al Stone <ahs3@redhat.com>
> 
>    Corrects an obvious typo in the Arndale pinctrl descriptions in DT.
>    The samsung-pinctrl driver uses the correct name.

Thanks for spotting this. The patch looks good to me, but is it tested on 
some Exynos 5250 based board?

With this typo activating configuration of these pinctrl groups just kept 
pin-drv at default value, as set up by bootloader, while after this patch 
it will be reconfigured with new values.

I'll try to test this patch on an Arndale later today.

Best regards,
Tomasz

> Signed-off-by: Al Stone <al.stone@linaro.org>
> ---
>  arch/arm/boot/dts/exynos5250-pinctrl.dtsi | 44
> +++++++++++++++---------------- 1 file changed, 22 insertions(+), 22
> deletions(-)
> 
> diff --git a/arch/arm/boot/dts/exynos5250-pinctrl.dtsi
> b/arch/arm/boot/dts/exynos5250-pinctrl.dtsi index 656e381..031e198
> 100644
> --- a/arch/arm/boot/dts/exynos5250-pinctrl.dtsi
> +++ b/arch/arm/boot/dts/exynos5250-pinctrl.dtsi
> @@ -210,21 +210,21 @@
>  			samsung,pins = "gpa0-2", "gpa0-3";
>  			samsung,pin-function = <2>;
>  			samsung,pin-pud = <0>;
> -			samaung,pin-drv = <0>;
> +			samsung,pin-drv = <0>;
>  		};
> 
>  		i2c2_bus: i2c2-bus {
>  			samsung,pins = "gpa0-6", "gpa0-7";
>  			samsung,pin-function = <3>;
>  			samsung,pin-pud = <3>;
> -			samaung,pin-drv = <0>;
> +			samsung,pin-drv = <0>;
>  		};
> 
>  		i2c2_hs_bus: i2c2-hs-bus {
>  			samsung,pins = "gpa0-6", "gpa0-7";
>  			samsung,pin-function = <4>;
>  			samsung,pin-pud = <3>;
> -			samaung,pin-drv = <0>;
> +			samsung,pin-drv = <0>;
>  		};
> 
>  		uart2_data: uart2-data {
> @@ -238,21 +238,21 @@
>  			samsung,pins = "gpa1-2", "gpa1-3";
>  			samsung,pin-function = <2>;
>  			samsung,pin-pud = <0>;
> -			samaung,pin-drv = <0>;
> +			samsung,pin-drv = <0>;
>  		};
> 
>  		i2c3_bus: i2c3-bus {
>  			samsung,pins = "gpa1-2", "gpa1-3";
>  			samsung,pin-function = <3>;
>  			samsung,pin-pud = <3>;
> -			samaung,pin-drv = <0>;
> +			samsung,pin-drv = <0>;
>  		};
> 
>  		i2c3_hs_bus: i2c3-hs-bus {
>  			samsung,pins = "gpa1-2", "gpa1-3";
>  			samsung,pin-function = <4>;
>  			samsung,pin-pud = <3>;
> -			samaung,pin-drv = <0>;
> +			samsung,pin-drv = <0>;
>  		};
> 
>  		uart3_data: uart3-data {
> @@ -273,14 +273,14 @@
>  			samsung,pins = "gpa2-0", "gpa2-1";
>  			samsung,pin-function = <3>;
>  			samsung,pin-pud = <3>;
> -			samaung,pin-drv = <0>;
> +			samsung,pin-drv = <0>;
>  		};
> 
>  		i2c5_bus: i2c5-bus {
>  			samsung,pins = "gpa2-2", "gpa2-3";
>  			samsung,pin-function = <3>;
>  			samsung,pin-pud = <3>;
> -			samaung,pin-drv = <0>;
> +			samsung,pin-drv = <0>;
>  		};
> 
>  		spi1_bus: spi1-bus {
> @@ -376,14 +376,14 @@
>  			samsung,pins = "gpb3-0", "gpb3-1";
>  			samsung,pin-function = <4>;
>  			samsung,pin-pud = <3>;
> -			samaung,pin-drv = <0>;
> +			samsung,pin-drv = <0>;
>  		};
> 
>  		i2c1_hs_bus: i2c1-hs-bus {
>  			samsung,pins = "gpb3-2", "gpb3-3";
>  			samsung,pin-function = <4>;
>  			samsung,pin-pud = <3>;
> -			samaung,pin-drv = <0>;
> +			samsung,pin-drv = <0>;
>  		};
> 
>  		sd0_clk: sd0-clk {
> @@ -551,14 +551,14 @@
>  			samsung,pins = "gpd0-2", "gpd0-3";
>  			samsung,pin-function = <2>;
>  			samsung,pin-pud = <0>;
> -			samaung,pin-drv = <0>;
> +			samsung,pin-drv = <0>;
>  		};
> 
>  		dp_hpd: dp_hpd {
>  			samsung,pins = "gpx0-7";
>  			samsung,pin-function = <3>;
>  			samsung,pin-pud = <0>;
> -			samaung,pin-drv = <0>;
> +			samsung,pin-drv = <0>;
>  		};
>  	};
> 
> @@ -650,42 +650,42 @@
>  				       "gpf1-0", "gpf1-1", "gpf1-2", "gpf1-3";
>  			samsung,pin-function = <3>;
>  			samsung,pin-pud = <0>;
> -			samaung,pin-drv = <0>;
> +			samsung,pin-drv = <0>;
>  		};
> 
>  		cam_i2c2_bus: cam-i2c2-bus {
>  			samsung,pins = "gpe0-6", "gpe1-0";
>  			samsung,pin-function = <4>;
>  			samsung,pin-pud = <3>;
> -			samaung,pin-drv = <0>;
> +			samsung,pin-drv = <0>;
>  		};
> 
>  		cam_spi1_bus: cam-spi1-bus {
>  			samsung,pins = "gpe0-4", "gpe0-5", "gpf0-2", "gpf0-3";
>  			samsung,pin-function = <4>;
>  			samsung,pin-pud = <0>;
> -			samaung,pin-drv = <0>;
> +			samsung,pin-drv = <0>;
>  		};
> 
>  		cam_i2c1_bus: cam-i2c1-bus {
>  			samsung,pins = "gpf0-2", "gpf0-3";
>  			samsung,pin-function = <2>;
>  			samsung,pin-pud = <3>;
> -			samaung,pin-drv = <0>;
> +			samsung,pin-drv = <0>;
>  		};
> 
>  		cam_i2c0_bus: cam-i2c0-bus {
>  			samsung,pins = "gpf0-0", "gpf0-1";
>  			samsung,pin-function = <2>;
>  			samsung,pin-pud = <3>;
> -			samaung,pin-drv = <0>;
> +			samsung,pin-drv = <0>;
>  		};
> 
>  		cam_spi0_bus: cam-spi0-bus {
>  			samsung,pins = "gpf1-0", "gpf1-1", "gpf1-2", "gpf1-3";
>  			samsung,pin-function = <2>;
>  			samsung,pin-pud = <0>;
> -			samaung,pin-drv = <0>;
> +			samsung,pin-drv = <0>;
>  		};
> 
>  		cam_bayrgb_bus: cam-bayrgb-bus {
> @@ -696,7 +696,7 @@
>  				       "gpg2-0", "gpg2-1";
>  			samsung,pin-function = <2>;
>  			samsung,pin-pud = <0>;
> -			samaung,pin-drv = <0>;
> +			samsung,pin-drv = <0>;
>  		};
> 
>  		cam_port_a: cam-port-a {
> @@ -705,7 +705,7 @@
>  				       "gph1-4", "gph1-5", "gph1-6", "gph1-7";
>  			samsung,pin-function = <2>;
>  			samsung,pin-pud = <0>;
> -			samaung,pin-drv = <0>;
> +			samsung,pin-drv = <0>;
>  		};
>  	};
> 
> @@ -757,7 +757,7 @@
>  				       "gpv1-4", "gpv1-5", "gpv1-6", "gpv1-7";
>  			samsung,pin-function = <2>;
>  			samsung,pin-pud = <0>;
> -			samaung,pin-drv = <0>;
> +			samsung,pin-drv = <0>;
>  		};
> 
>  		c2c_txd: c2c-txd {
> @@ -767,7 +767,7 @@
>  				       "gpv3-4", "gpv3-5", "gpv3-6", "gpv3-7";
>  			samsung,pin-function = <2>;
>  			samsung,pin-pud = <0>;
> -			samaung,pin-drv = <0>;
> +			samsung,pin-drv = <0>;
>  		};
>  	};

--
To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Al Stone Sept. 9, 2013, 3:11 p.m. UTC | #3
On 09/09/2013 03:00 AM, Tomasz Figa wrote:
> Hi Al,
>
> On Friday 06 of September 2013 14:09:52 al.stone@linaro.org wrote:
>> From: Al Stone <ahs3@redhat.com>
>>
>>     Corrects an obvious typo in the Arndale pinctrl descriptions in DT.
>>     The samsung-pinctrl driver uses the correct name.
>
> Thanks for spotting this. The patch looks good to me, but is it tested on
> some Exynos 5250 based board?

Only with a simple boot test on an Arndale, and making sure that dtc
could actually build the dtb.  I did not test the driver code.  I did
read through the code and it appeared to be doing the right things,
based on the content of the DT, but I did not do an active test of that.

> With this typo activating configuration of these pinctrl groups just kept
> pin-drv at default value, as set up by bootloader, while after this patch
> it will be reconfigured with new values.
>
> I'll try to test this patch on an Arndale later today.
>
> Best regards,
> Tomasz
>
>> Signed-off-by: Al Stone <al.stone@linaro.org>
>> ---
>>   arch/arm/boot/dts/exynos5250-pinctrl.dtsi | 44
>> +++++++++++++++---------------- 1 file changed, 22 insertions(+), 22
>> deletions(-)
>>
>> diff --git a/arch/arm/boot/dts/exynos5250-pinctrl.dtsi
>> b/arch/arm/boot/dts/exynos5250-pinctrl.dtsi index 656e381..031e198
>> 100644
>> --- a/arch/arm/boot/dts/exynos5250-pinctrl.dtsi
>> +++ b/arch/arm/boot/dts/exynos5250-pinctrl.dtsi
>> @@ -210,21 +210,21 @@
>>   			samsung,pins = "gpa0-2", "gpa0-3";
>>   			samsung,pin-function = <2>;
>>   			samsung,pin-pud = <0>;
>> -			samaung,pin-drv = <0>;
>> +			samsung,pin-drv = <0>;
>>   		};
>>
>>   		i2c2_bus: i2c2-bus {
>>   			samsung,pins = "gpa0-6", "gpa0-7";
>>   			samsung,pin-function = <3>;
>>   			samsung,pin-pud = <3>;
>> -			samaung,pin-drv = <0>;
>> +			samsung,pin-drv = <0>;
>>   		};
>>
>>   		i2c2_hs_bus: i2c2-hs-bus {
>>   			samsung,pins = "gpa0-6", "gpa0-7";
>>   			samsung,pin-function = <4>;
>>   			samsung,pin-pud = <3>;
>> -			samaung,pin-drv = <0>;
>> +			samsung,pin-drv = <0>;
>>   		};
>>
>>   		uart2_data: uart2-data {
>> @@ -238,21 +238,21 @@
>>   			samsung,pins = "gpa1-2", "gpa1-3";
>>   			samsung,pin-function = <2>;
>>   			samsung,pin-pud = <0>;
>> -			samaung,pin-drv = <0>;
>> +			samsung,pin-drv = <0>;
>>   		};
>>
>>   		i2c3_bus: i2c3-bus {
>>   			samsung,pins = "gpa1-2", "gpa1-3";
>>   			samsung,pin-function = <3>;
>>   			samsung,pin-pud = <3>;
>> -			samaung,pin-drv = <0>;
>> +			samsung,pin-drv = <0>;
>>   		};
>>
>>   		i2c3_hs_bus: i2c3-hs-bus {
>>   			samsung,pins = "gpa1-2", "gpa1-3";
>>   			samsung,pin-function = <4>;
>>   			samsung,pin-pud = <3>;
>> -			samaung,pin-drv = <0>;
>> +			samsung,pin-drv = <0>;
>>   		};
>>
>>   		uart3_data: uart3-data {
>> @@ -273,14 +273,14 @@
>>   			samsung,pins = "gpa2-0", "gpa2-1";
>>   			samsung,pin-function = <3>;
>>   			samsung,pin-pud = <3>;
>> -			samaung,pin-drv = <0>;
>> +			samsung,pin-drv = <0>;
>>   		};
>>
>>   		i2c5_bus: i2c5-bus {
>>   			samsung,pins = "gpa2-2", "gpa2-3";
>>   			samsung,pin-function = <3>;
>>   			samsung,pin-pud = <3>;
>> -			samaung,pin-drv = <0>;
>> +			samsung,pin-drv = <0>;
>>   		};
>>
>>   		spi1_bus: spi1-bus {
>> @@ -376,14 +376,14 @@
>>   			samsung,pins = "gpb3-0", "gpb3-1";
>>   			samsung,pin-function = <4>;
>>   			samsung,pin-pud = <3>;
>> -			samaung,pin-drv = <0>;
>> +			samsung,pin-drv = <0>;
>>   		};
>>
>>   		i2c1_hs_bus: i2c1-hs-bus {
>>   			samsung,pins = "gpb3-2", "gpb3-3";
>>   			samsung,pin-function = <4>;
>>   			samsung,pin-pud = <3>;
>> -			samaung,pin-drv = <0>;
>> +			samsung,pin-drv = <0>;
>>   		};
>>
>>   		sd0_clk: sd0-clk {
>> @@ -551,14 +551,14 @@
>>   			samsung,pins = "gpd0-2", "gpd0-3";
>>   			samsung,pin-function = <2>;
>>   			samsung,pin-pud = <0>;
>> -			samaung,pin-drv = <0>;
>> +			samsung,pin-drv = <0>;
>>   		};
>>
>>   		dp_hpd: dp_hpd {
>>   			samsung,pins = "gpx0-7";
>>   			samsung,pin-function = <3>;
>>   			samsung,pin-pud = <0>;
>> -			samaung,pin-drv = <0>;
>> +			samsung,pin-drv = <0>;
>>   		};
>>   	};
>>
>> @@ -650,42 +650,42 @@
>>   				       "gpf1-0", "gpf1-1", "gpf1-2", "gpf1-3";
>>   			samsung,pin-function = <3>;
>>   			samsung,pin-pud = <0>;
>> -			samaung,pin-drv = <0>;
>> +			samsung,pin-drv = <0>;
>>   		};
>>
>>   		cam_i2c2_bus: cam-i2c2-bus {
>>   			samsung,pins = "gpe0-6", "gpe1-0";
>>   			samsung,pin-function = <4>;
>>   			samsung,pin-pud = <3>;
>> -			samaung,pin-drv = <0>;
>> +			samsung,pin-drv = <0>;
>>   		};
>>
>>   		cam_spi1_bus: cam-spi1-bus {
>>   			samsung,pins = "gpe0-4", "gpe0-5", "gpf0-2", "gpf0-3";
>>   			samsung,pin-function = <4>;
>>   			samsung,pin-pud = <0>;
>> -			samaung,pin-drv = <0>;
>> +			samsung,pin-drv = <0>;
>>   		};
>>
>>   		cam_i2c1_bus: cam-i2c1-bus {
>>   			samsung,pins = "gpf0-2", "gpf0-3";
>>   			samsung,pin-function = <2>;
>>   			samsung,pin-pud = <3>;
>> -			samaung,pin-drv = <0>;
>> +			samsung,pin-drv = <0>;
>>   		};
>>
>>   		cam_i2c0_bus: cam-i2c0-bus {
>>   			samsung,pins = "gpf0-0", "gpf0-1";
>>   			samsung,pin-function = <2>;
>>   			samsung,pin-pud = <3>;
>> -			samaung,pin-drv = <0>;
>> +			samsung,pin-drv = <0>;
>>   		};
>>
>>   		cam_spi0_bus: cam-spi0-bus {
>>   			samsung,pins = "gpf1-0", "gpf1-1", "gpf1-2", "gpf1-3";
>>   			samsung,pin-function = <2>;
>>   			samsung,pin-pud = <0>;
>> -			samaung,pin-drv = <0>;
>> +			samsung,pin-drv = <0>;
>>   		};
>>
>>   		cam_bayrgb_bus: cam-bayrgb-bus {
>> @@ -696,7 +696,7 @@
>>   				       "gpg2-0", "gpg2-1";
>>   			samsung,pin-function = <2>;
>>   			samsung,pin-pud = <0>;
>> -			samaung,pin-drv = <0>;
>> +			samsung,pin-drv = <0>;
>>   		};
>>
>>   		cam_port_a: cam-port-a {
>> @@ -705,7 +705,7 @@
>>   				       "gph1-4", "gph1-5", "gph1-6", "gph1-7";
>>   			samsung,pin-function = <2>;
>>   			samsung,pin-pud = <0>;
>> -			samaung,pin-drv = <0>;
>> +			samsung,pin-drv = <0>;
>>   		};
>>   	};
>>
>> @@ -757,7 +757,7 @@
>>   				       "gpv1-4", "gpv1-5", "gpv1-6", "gpv1-7";
>>   			samsung,pin-function = <2>;
>>   			samsung,pin-pud = <0>;
>> -			samaung,pin-drv = <0>;
>> +			samsung,pin-drv = <0>;
>>   		};
>>
>>   		c2c_txd: c2c-txd {
>> @@ -767,7 +767,7 @@
>>   				       "gpv3-4", "gpv3-5", "gpv3-6", "gpv3-7";
>>   			samsung,pin-function = <2>;
>>   			samsung,pin-pud = <0>;
>> -			samaung,pin-drv = <0>;
>> +			samsung,pin-drv = <0>;
>>   		};
>>   	};
>
kgene@kernel.org Sept. 12, 2013, 10:23 a.m. UTC | #4
Jingoo Han wrote:
> 
> On Saturday, September 07, 2013 5:10 AM, Al Stone wrote:
> >
> > From: Al Stone <ahs3@redhat.com>
> >
> >    Corrects an obvious typo in the Arndale pinctrl descriptions in DT.
> >    The samsung-pinctrl driver uses the correct name.
> >
> > Signed-off-by: Al Stone <al.stone@linaro.org>
> 
> CC'ed Kukjin Kim (Samsung-SoC Maintainer)
> 
Thanks, Jingoo.

> It looks good.
> Reviewed-by: Jingoo Han <jg1.han@samsung.com>
> 
> Best regards,
> Jingoo Han
> 
Sigh, maybe we missed the typo :(

Will apply, but I'm not sure we need to send this to the stable. Let me
check.

Thanks,
Kukjin

> > ---
> >  arch/arm/boot/dts/exynos5250-pinctrl.dtsi | 44 +++++++++++++++---------
> -------
> >  1 file changed, 22 insertions(+), 22 deletions(-)
> >
> > diff --git a/arch/arm/boot/dts/exynos5250-pinctrl.dtsi
> b/arch/arm/boot/dts/exynos5250-pinctrl.dtsi
> > index 656e381..031e198 100644
> > --- a/arch/arm/boot/dts/exynos5250-pinctrl.dtsi
> > +++ b/arch/arm/boot/dts/exynos5250-pinctrl.dtsi
> > @@ -210,21 +210,21 @@
> >  			samsung,pins = "gpa0-2", "gpa0-3";
> >  			samsung,pin-function = <2>;
> >  			samsung,pin-pud = <0>;
> > -			samaung,pin-drv = <0>;
> > +			samsung,pin-drv = <0>;
> >  		};
> >
> >  		i2c2_bus: i2c2-bus {
> >  			samsung,pins = "gpa0-6", "gpa0-7";
> >  			samsung,pin-function = <3>;
> >  			samsung,pin-pud = <3>;
> > -			samaung,pin-drv = <0>;
> > +			samsung,pin-drv = <0>;
> >  		};
> >
> >  		i2c2_hs_bus: i2c2-hs-bus {
> >  			samsung,pins = "gpa0-6", "gpa0-7";
> >  			samsung,pin-function = <4>;
> >  			samsung,pin-pud = <3>;
> > -			samaung,pin-drv = <0>;
> > +			samsung,pin-drv = <0>;
> >  		};
> >
> >  		uart2_data: uart2-data {
> > @@ -238,21 +238,21 @@
> >  			samsung,pins = "gpa1-2", "gpa1-3";
> >  			samsung,pin-function = <2>;
> >  			samsung,pin-pud = <0>;
> > -			samaung,pin-drv = <0>;
> > +			samsung,pin-drv = <0>;
> >  		};
> >
> >  		i2c3_bus: i2c3-bus {
> >  			samsung,pins = "gpa1-2", "gpa1-3";
> >  			samsung,pin-function = <3>;
> >  			samsung,pin-pud = <3>;
> > -			samaung,pin-drv = <0>;
> > +			samsung,pin-drv = <0>;
> >  		};
> >
> >  		i2c3_hs_bus: i2c3-hs-bus {
> >  			samsung,pins = "gpa1-2", "gpa1-3";
> >  			samsung,pin-function = <4>;
> >  			samsung,pin-pud = <3>;
> > -			samaung,pin-drv = <0>;
> > +			samsung,pin-drv = <0>;
> >  		};
> >
> >  		uart3_data: uart3-data {
> > @@ -273,14 +273,14 @@
> >  			samsung,pins = "gpa2-0", "gpa2-1";
> >  			samsung,pin-function = <3>;
> >  			samsung,pin-pud = <3>;
> > -			samaung,pin-drv = <0>;
> > +			samsung,pin-drv = <0>;
> >  		};
> >
> >  		i2c5_bus: i2c5-bus {
> >  			samsung,pins = "gpa2-2", "gpa2-3";
> >  			samsung,pin-function = <3>;
> >  			samsung,pin-pud = <3>;
> > -			samaung,pin-drv = <0>;
> > +			samsung,pin-drv = <0>;
> >  		};
> >
> >  		spi1_bus: spi1-bus {
> > @@ -376,14 +376,14 @@
> >  			samsung,pins = "gpb3-0", "gpb3-1";
> >  			samsung,pin-function = <4>;
> >  			samsung,pin-pud = <3>;
> > -			samaung,pin-drv = <0>;
> > +			samsung,pin-drv = <0>;
> >  		};
> >
> >  		i2c1_hs_bus: i2c1-hs-bus {
> >  			samsung,pins = "gpb3-2", "gpb3-3";
> >  			samsung,pin-function = <4>;
> >  			samsung,pin-pud = <3>;
> > -			samaung,pin-drv = <0>;
> > +			samsung,pin-drv = <0>;
> >  		};
> >
> >  		sd0_clk: sd0-clk {
> > @@ -551,14 +551,14 @@
> >  			samsung,pins = "gpd0-2", "gpd0-3";
> >  			samsung,pin-function = <2>;
> >  			samsung,pin-pud = <0>;
> > -			samaung,pin-drv = <0>;
> > +			samsung,pin-drv = <0>;
> >  		};
> >
> >  		dp_hpd: dp_hpd {
> >  			samsung,pins = "gpx0-7";
> >  			samsung,pin-function = <3>;
> >  			samsung,pin-pud = <0>;
> > -			samaung,pin-drv = <0>;
> > +			samsung,pin-drv = <0>;
> >  		};
> >  	};
> >
> > @@ -650,42 +650,42 @@
> >  				       "gpf1-0", "gpf1-1", "gpf1-2",
"gpf1-3";
> >  			samsung,pin-function = <3>;
> >  			samsung,pin-pud = <0>;
> > -			samaung,pin-drv = <0>;
> > +			samsung,pin-drv = <0>;
> >  		};
> >
> >  		cam_i2c2_bus: cam-i2c2-bus {
> >  			samsung,pins = "gpe0-6", "gpe1-0";
> >  			samsung,pin-function = <4>;
> >  			samsung,pin-pud = <3>;
> > -			samaung,pin-drv = <0>;
> > +			samsung,pin-drv = <0>;
> >  		};
> >
> >  		cam_spi1_bus: cam-spi1-bus {
> >  			samsung,pins = "gpe0-4", "gpe0-5", "gpf0-2",
"gpf0-3";
> >  			samsung,pin-function = <4>;
> >  			samsung,pin-pud = <0>;
> > -			samaung,pin-drv = <0>;
> > +			samsung,pin-drv = <0>;
> >  		};
> >
> >  		cam_i2c1_bus: cam-i2c1-bus {
> >  			samsung,pins = "gpf0-2", "gpf0-3";
> >  			samsung,pin-function = <2>;
> >  			samsung,pin-pud = <3>;
> > -			samaung,pin-drv = <0>;
> > +			samsung,pin-drv = <0>;
> >  		};
> >
> >  		cam_i2c0_bus: cam-i2c0-bus {
> >  			samsung,pins = "gpf0-0", "gpf0-1";
> >  			samsung,pin-function = <2>;
> >  			samsung,pin-pud = <3>;
> > -			samaung,pin-drv = <0>;
> > +			samsung,pin-drv = <0>;
> >  		};
> >
> >  		cam_spi0_bus: cam-spi0-bus {
> >  			samsung,pins = "gpf1-0", "gpf1-1", "gpf1-2",
"gpf1-3";
> >  			samsung,pin-function = <2>;
> >  			samsung,pin-pud = <0>;
> > -			samaung,pin-drv = <0>;
> > +			samsung,pin-drv = <0>;
> >  		};
> >
> >  		cam_bayrgb_bus: cam-bayrgb-bus {
> > @@ -696,7 +696,7 @@
> >  				       "gpg2-0", "gpg2-1";
> >  			samsung,pin-function = <2>;
> >  			samsung,pin-pud = <0>;
> > -			samaung,pin-drv = <0>;
> > +			samsung,pin-drv = <0>;
> >  		};
> >
> >  		cam_port_a: cam-port-a {
> > @@ -705,7 +705,7 @@
> >  				       "gph1-4", "gph1-5", "gph1-6",
"gph1-7";
> >  			samsung,pin-function = <2>;
> >  			samsung,pin-pud = <0>;
> > -			samaung,pin-drv = <0>;
> > +			samsung,pin-drv = <0>;
> >  		};
> >  	};
> >
> > @@ -757,7 +757,7 @@
> >  				       "gpv1-4", "gpv1-5", "gpv1-6",
"gpv1-7";
> >  			samsung,pin-function = <2>;
> >  			samsung,pin-pud = <0>;
> > -			samaung,pin-drv = <0>;
> > +			samsung,pin-drv = <0>;
> >  		};
> >
> >  		c2c_txd: c2c-txd {
> > @@ -767,7 +767,7 @@
> >  				       "gpv3-4", "gpv3-5", "gpv3-6",
"gpv3-7";
> >  			samsung,pin-function = <2>;
> >  			samsung,pin-pud = <0>;
> > -			samaung,pin-drv = <0>;
> > +			samsung,pin-drv = <0>;
> >  		};
> >  	};
> >
> > --
> > 1.8.3.1

--
To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Tomasz Figa Sept. 12, 2013, 11:18 a.m. UTC | #5
On Monday 09 of September 2013 09:11:11 Al Stone wrote:
> On 09/09/2013 03:00 AM, Tomasz Figa wrote:
> > Hi Al,
> > 
> > On Friday 06 of September 2013 14:09:52 al.stone@linaro.org wrote:
> >> From: Al Stone <ahs3@redhat.com>
> >> 
> >>     Corrects an obvious typo in the Arndale pinctrl descriptions in
> >>     DT.
> >>     The samsung-pinctrl driver uses the correct name.
> > 
> > Thanks for spotting this. The patch looks good to me, but is it tested
> > on some Exynos 5250 based board?
> 
> Only with a simple boot test on an Arndale, and making sure that dtc
> could actually build the dtb.  I did not test the driver code.  I did
> read through the code and it appeared to be doing the right things,
> based on the content of the DT, but I did not do an active test of that.

OK. I'm able to do exactly the same testing as you did, so let's say I'm 
fine with this patch.

Acked-by: Tomasz Figa <t.figa@samsung.com>

Best regards,
Tomasz

--
To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Patch
diff mbox

diff --git a/arch/arm/boot/dts/exynos5250-pinctrl.dtsi b/arch/arm/boot/dts/exynos5250-pinctrl.dtsi
index 656e381..031e198 100644
--- a/arch/arm/boot/dts/exynos5250-pinctrl.dtsi
+++ b/arch/arm/boot/dts/exynos5250-pinctrl.dtsi
@@ -210,21 +210,21 @@ 
 			samsung,pins = "gpa0-2", "gpa0-3";
 			samsung,pin-function = <2>;
 			samsung,pin-pud = <0>;
-			samaung,pin-drv = <0>;
+			samsung,pin-drv = <0>;
 		};
 
 		i2c2_bus: i2c2-bus {
 			samsung,pins = "gpa0-6", "gpa0-7";
 			samsung,pin-function = <3>;
 			samsung,pin-pud = <3>;
-			samaung,pin-drv = <0>;
+			samsung,pin-drv = <0>;
 		};
 
 		i2c2_hs_bus: i2c2-hs-bus {
 			samsung,pins = "gpa0-6", "gpa0-7";
 			samsung,pin-function = <4>;
 			samsung,pin-pud = <3>;
-			samaung,pin-drv = <0>;
+			samsung,pin-drv = <0>;
 		};
 
 		uart2_data: uart2-data {
@@ -238,21 +238,21 @@ 
 			samsung,pins = "gpa1-2", "gpa1-3";
 			samsung,pin-function = <2>;
 			samsung,pin-pud = <0>;
-			samaung,pin-drv = <0>;
+			samsung,pin-drv = <0>;
 		};
 
 		i2c3_bus: i2c3-bus {
 			samsung,pins = "gpa1-2", "gpa1-3";
 			samsung,pin-function = <3>;
 			samsung,pin-pud = <3>;
-			samaung,pin-drv = <0>;
+			samsung,pin-drv = <0>;
 		};
 
 		i2c3_hs_bus: i2c3-hs-bus {
 			samsung,pins = "gpa1-2", "gpa1-3";
 			samsung,pin-function = <4>;
 			samsung,pin-pud = <3>;
-			samaung,pin-drv = <0>;
+			samsung,pin-drv = <0>;
 		};
 
 		uart3_data: uart3-data {
@@ -273,14 +273,14 @@ 
 			samsung,pins = "gpa2-0", "gpa2-1";
 			samsung,pin-function = <3>;
 			samsung,pin-pud = <3>;
-			samaung,pin-drv = <0>;
+			samsung,pin-drv = <0>;
 		};
 
 		i2c5_bus: i2c5-bus {
 			samsung,pins = "gpa2-2", "gpa2-3";
 			samsung,pin-function = <3>;
 			samsung,pin-pud = <3>;
-			samaung,pin-drv = <0>;
+			samsung,pin-drv = <0>;
 		};
 
 		spi1_bus: spi1-bus {
@@ -376,14 +376,14 @@ 
 			samsung,pins = "gpb3-0", "gpb3-1";
 			samsung,pin-function = <4>;
 			samsung,pin-pud = <3>;
-			samaung,pin-drv = <0>;
+			samsung,pin-drv = <0>;
 		};
 
 		i2c1_hs_bus: i2c1-hs-bus {
 			samsung,pins = "gpb3-2", "gpb3-3";
 			samsung,pin-function = <4>;
 			samsung,pin-pud = <3>;
-			samaung,pin-drv = <0>;
+			samsung,pin-drv = <0>;
 		};
 
 		sd0_clk: sd0-clk {
@@ -551,14 +551,14 @@ 
 			samsung,pins = "gpd0-2", "gpd0-3";
 			samsung,pin-function = <2>;
 			samsung,pin-pud = <0>;
-			samaung,pin-drv = <0>;
+			samsung,pin-drv = <0>;
 		};
 
 		dp_hpd: dp_hpd {
 			samsung,pins = "gpx0-7";
 			samsung,pin-function = <3>;
 			samsung,pin-pud = <0>;
-			samaung,pin-drv = <0>;
+			samsung,pin-drv = <0>;
 		};
 	};
 
@@ -650,42 +650,42 @@ 
 				       "gpf1-0", "gpf1-1", "gpf1-2", "gpf1-3";
 			samsung,pin-function = <3>;
 			samsung,pin-pud = <0>;
-			samaung,pin-drv = <0>;
+			samsung,pin-drv = <0>;
 		};
 
 		cam_i2c2_bus: cam-i2c2-bus {
 			samsung,pins = "gpe0-6", "gpe1-0";
 			samsung,pin-function = <4>;
 			samsung,pin-pud = <3>;
-			samaung,pin-drv = <0>;
+			samsung,pin-drv = <0>;
 		};
 
 		cam_spi1_bus: cam-spi1-bus {
 			samsung,pins = "gpe0-4", "gpe0-5", "gpf0-2", "gpf0-3";
 			samsung,pin-function = <4>;
 			samsung,pin-pud = <0>;
-			samaung,pin-drv = <0>;
+			samsung,pin-drv = <0>;
 		};
 
 		cam_i2c1_bus: cam-i2c1-bus {
 			samsung,pins = "gpf0-2", "gpf0-3";
 			samsung,pin-function = <2>;
 			samsung,pin-pud = <3>;
-			samaung,pin-drv = <0>;
+			samsung,pin-drv = <0>;
 		};
 
 		cam_i2c0_bus: cam-i2c0-bus {
 			samsung,pins = "gpf0-0", "gpf0-1";
 			samsung,pin-function = <2>;
 			samsung,pin-pud = <3>;
-			samaung,pin-drv = <0>;
+			samsung,pin-drv = <0>;
 		};
 
 		cam_spi0_bus: cam-spi0-bus {
 			samsung,pins = "gpf1-0", "gpf1-1", "gpf1-2", "gpf1-3";
 			samsung,pin-function = <2>;
 			samsung,pin-pud = <0>;
-			samaung,pin-drv = <0>;
+			samsung,pin-drv = <0>;
 		};
 
 		cam_bayrgb_bus: cam-bayrgb-bus {
@@ -696,7 +696,7 @@ 
 				       "gpg2-0", "gpg2-1";
 			samsung,pin-function = <2>;
 			samsung,pin-pud = <0>;
-			samaung,pin-drv = <0>;
+			samsung,pin-drv = <0>;
 		};
 
 		cam_port_a: cam-port-a {
@@ -705,7 +705,7 @@ 
 				       "gph1-4", "gph1-5", "gph1-6", "gph1-7";
 			samsung,pin-function = <2>;
 			samsung,pin-pud = <0>;
-			samaung,pin-drv = <0>;
+			samsung,pin-drv = <0>;
 		};
 	};
 
@@ -757,7 +757,7 @@ 
 				       "gpv1-4", "gpv1-5", "gpv1-6", "gpv1-7";
 			samsung,pin-function = <2>;
 			samsung,pin-pud = <0>;
-			samaung,pin-drv = <0>;
+			samsung,pin-drv = <0>;
 		};
 
 		c2c_txd: c2c-txd {
@@ -767,7 +767,7 @@ 
 				       "gpv3-4", "gpv3-5", "gpv3-6", "gpv3-7";
 			samsung,pin-function = <2>;
 			samsung,pin-pud = <0>;
-			samaung,pin-drv = <0>;
+			samsung,pin-drv = <0>;
 		};
 	};