[v2,2/3] ARM: bcm281xx: Turn on Thermal and HWMON drivers.
diff mbox

Message ID 1380321454-16216-3-git-send-email-wendy.ng@broadcom.com
State Changes Requested
Delegated to: Eduardo Valentin
Headers show

Commit Message

Wendy Ng Sept. 27, 2013, 10:37 p.m. UTC
This enables the thermal and HWMON drivers for Broadcom bcm281xx SoCs.

Signed-off-by: Wendy Ng <wendy.ng@broadcom.com>
Reviewed-by: Markus Mayer <mmayer@broadcom.com>
Reviewed-by: Christian Daudt <csd@broadcom.com>
---
 arch/arm/configs/bcm_defconfig |    3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

Comments

Eduardo Valentin Oct. 13, 2013, 10:16 p.m. UTC | #1
Wendy,

On 27-09-2013 18:37, Wendy Ng wrote:
> This enables the thermal and HWMON drivers for Broadcom bcm281xx SoCs.
> 
> Signed-off-by: Wendy Ng <wendy.ng@broadcom.com>
> Reviewed-by: Markus Mayer <mmayer@broadcom.com>
> Reviewed-by: Christian Daudt <csd@broadcom.com>
> ---
>  arch/arm/configs/bcm_defconfig |    3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/arch/arm/configs/bcm_defconfig b/arch/arm/configs/bcm_defconfig
> index 6e49310..1474661 100644
> --- a/arch/arm/configs/bcm_defconfig
> +++ b/arch/arm/configs/bcm_defconfig
> @@ -83,7 +83,8 @@ CONFIG_SERIAL_8250_DW=y
>  CONFIG_HW_RANDOM=y
>  CONFIG_I2C=y
>  CONFIG_I2C_CHARDEV=y
> -# CONFIG_HWMON is not set
> +CONFIG_THERMAL=y

Maybe you also wanted to
CONFIG_BCM_THERMAL=y
?

> +CONFIG_HWMON=y
>  CONFIG_VIDEO_OUTPUT_CONTROL=y
>  CONFIG_FB=y
>  CONFIG_BACKLIGHT_LCD_SUPPORT=y
>
Wendy Ng Oct. 16, 2013, 9:18 p.m. UTC | #2
On 10/13/2013 3:16 PM, Eduardo Valentin wrote:
> Wendy,
>
> On 27-09-2013 18:37, Wendy Ng wrote:
>> This enables the thermal and HWMON drivers for Broadcom bcm281xx SoCs.
>>
>> Signed-off-by: Wendy Ng <wendy.ng@broadcom.com>
>> Reviewed-by: Markus Mayer <mmayer@broadcom.com>
>> Reviewed-by: Christian Daudt <csd@broadcom.com>
>> ---
>>   arch/arm/configs/bcm_defconfig |    3 ++-
>>   1 file changed, 2 insertions(+), 1 deletion(-)
>>
>> diff --git a/arch/arm/configs/bcm_defconfig b/arch/arm/configs/bcm_defconfig
>> index 6e49310..1474661 100644
>> --- a/arch/arm/configs/bcm_defconfig
>> +++ b/arch/arm/configs/bcm_defconfig
>> @@ -83,7 +83,8 @@ CONFIG_SERIAL_8250_DW=y
>>   CONFIG_HW_RANDOM=y
>>   CONFIG_I2C=y
>>   CONFIG_I2C_CHARDEV=y
>> -# CONFIG_HWMON is not set
>> +CONFIG_THERMAL=y
>
> Maybe you also wanted to
> CONFIG_BCM_THERMAL=y
> ?
>
This is not required as I have default BCM_THERMAL to 'y' in Kconfig file.

>> +CONFIG_HWMON=y
>>   CONFIG_VIDEO_OUTPUT_CONTROL=y
>>   CONFIG_FB=y
>>   CONFIG_BACKLIGHT_LCD_SUPPORT=y
>>
>
>

Patch
diff mbox

diff --git a/arch/arm/configs/bcm_defconfig b/arch/arm/configs/bcm_defconfig
index 6e49310..1474661 100644
--- a/arch/arm/configs/bcm_defconfig
+++ b/arch/arm/configs/bcm_defconfig
@@ -83,7 +83,8 @@  CONFIG_SERIAL_8250_DW=y
 CONFIG_HW_RANDOM=y
 CONFIG_I2C=y
 CONFIG_I2C_CHARDEV=y
-# CONFIG_HWMON is not set
+CONFIG_THERMAL=y
+CONFIG_HWMON=y
 CONFIG_VIDEO_OUTPUT_CONTROL=y
 CONFIG_FB=y
 CONFIG_BACKLIGHT_LCD_SUPPORT=y