[6/7] arm: dts: add tmp102 i2c sensor node on dra7-evm
diff mbox

Message ID 1380652344-18819-7-git-send-email-eduardo.valentin@ti.com
State Accepted
Delegated to: Eduardo Valentin
Headers show

Commit Message

Eduardo Valentin Oct. 1, 2013, 6:32 p.m. UTC
On dra7-evm there is an tmp102 temperature sensor on i2c bus 1.
This patch adds its device tree node.

Signed-off-by: Eduardo Valentin <eduardo.valentin@ti.com>
---
 arch/arm/boot/dts/dra7-evm.dts | 8 ++++++++
 1 file changed, 8 insertions(+)

Comments

Nishanth Menon Oct. 1, 2013, 10:51 p.m. UTC | #1
On 14:32-20131001, Eduardo Valentin wrote:
> On dra7-evm there is an tmp102 temperature sensor on i2c bus 1.
> This patch adds its device tree node.
> 
> Signed-off-by: Eduardo Valentin <eduardo.valentin@ti.com>
> ---
>  arch/arm/boot/dts/dra7-evm.dts | 8 ++++++++
>  1 file changed, 8 insertions(+)
> 
> diff --git a/arch/arm/boot/dts/dra7-evm.dts b/arch/arm/boot/dts/dra7-evm.dts
> index 21fe16b..3b6c16a 100644
> --- a/arch/arm/boot/dts/dra7-evm.dts
> +++ b/arch/arm/boot/dts/dra7-evm.dts
> @@ -7,6 +7,8 @@
>   */
>  /dts-v1/;
>  
> +#include <dt-bindings/thermal/thermal.h>
> +

^^ needed?

>  #include "dra7.dtsi"
>  
>  / {
> @@ -93,6 +95,12 @@
>  	pinctrl-names = "default";
>  	pinctrl-0 = <&i2c1_pins>;
>  	clock-frequency = <400000>;
could you add an EOL here?
> +	tmp102: tmp102@48{
	a space before the {?
> +		compatible = "ti,tmp102";
> +		reg = <0x48>;
> +
> +		#thermal-sensor-cells = <0>;
> +	};
>  };
>  
>  &i2c2 {
> -- 
> 1.8.2.1.342.gfa7285d
> 
> --
> To unsubscribe from this list: send the line "unsubscribe linux-pm" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
Eduardo Valentin Oct. 2, 2013, 1:32 a.m. UTC | #2
On 01-10-2013 18:51, Nishanth Menon wrote:
> On 14:32-20131001, Eduardo Valentin wrote:
>> On dra7-evm there is an tmp102 temperature sensor on i2c bus 1.
>> This patch adds its device tree node.
>>
>> Signed-off-by: Eduardo Valentin <eduardo.valentin@ti.com>
>> ---
>>  arch/arm/boot/dts/dra7-evm.dts | 8 ++++++++
>>  1 file changed, 8 insertions(+)
>>
>> diff --git a/arch/arm/boot/dts/dra7-evm.dts b/arch/arm/boot/dts/dra7-evm.dts
>> index 21fe16b..3b6c16a 100644
>> --- a/arch/arm/boot/dts/dra7-evm.dts
>> +++ b/arch/arm/boot/dts/dra7-evm.dts
>> @@ -7,6 +7,8 @@
>>   */
>>  /dts-v1/;
>>  
>> +#include <dt-bindings/thermal/thermal.h>
>> +
> 
> ^^ needed?

In  fact this is left over from previous local versions and can be
removed from this patch.

However, depending on how patch 7 evolves, it could be needed, yes.

> 
>>  #include "dra7.dtsi"
>>  
>>  / {
>> @@ -93,6 +95,12 @@
>>  	pinctrl-names = "default";
>>  	pinctrl-0 = <&i2c1_pins>;
>>  	clock-frequency = <400000>;
> could you add an EOL here?
>> +	tmp102: tmp102@48{
> 	a space before the {?

ok for both cosmetic comments.

>> +		compatible = "ti,tmp102";
>> +		reg = <0x48>;
>> +
>> +		#thermal-sensor-cells = <0>;
>> +	};
>>  };
>>  
>>  &i2c2 {
>> -- 
>> 1.8.2.1.342.gfa7285d
>>
>> --
>> To unsubscribe from this list: send the line "unsubscribe linux-pm" in
>> the body of a message to majordomo@vger.kernel.org
>> More majordomo info at  http://vger.kernel.org/majordomo-info.html
>

Patch
diff mbox

diff --git a/arch/arm/boot/dts/dra7-evm.dts b/arch/arm/boot/dts/dra7-evm.dts
index 21fe16b..3b6c16a 100644
--- a/arch/arm/boot/dts/dra7-evm.dts
+++ b/arch/arm/boot/dts/dra7-evm.dts
@@ -7,6 +7,8 @@ 
  */
 /dts-v1/;
 
+#include <dt-bindings/thermal/thermal.h>
+
 #include "dra7.dtsi"
 
 / {
@@ -93,6 +95,12 @@ 
 	pinctrl-names = "default";
 	pinctrl-0 = <&i2c1_pins>;
 	clock-frequency = <400000>;
+	tmp102: tmp102@48{
+		compatible = "ti,tmp102";
+		reg = <0x48>;
+
+		#thermal-sensor-cells = <0>;
+	};
 };
 
 &i2c2 {