[OPW,kernel] staging: silicom: fix space prohibited before semicolon
diff mbox

Message ID 20131002213401.GA21796@gmail.com
State Changes Requested
Headers show

Commit Message

Tugce Sirin Oct. 2, 2013, 9:34 p.m. UTC
Signed-off-by: Tugce Sirin <ztugcesirin@gmail.com>

---
 drivers/staging/silicom/bp_mod.h |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Sarah Sharp Oct. 2, 2013, 9:52 p.m. UTC | #1
Please make sure to add a revision number to your patchsets when you
modify it.  The subject should start with [PATCH v2].  You can add
version numbers in mutt before you send the mail, or by using
git-format patch -v<number> when you generate the patch file.

On Thu, Oct 03, 2013 at 12:34:05AM +0300, Tugce Sirin wrote:
> Signed-off-by: Tugce Sirin <ztugcesirin@gmail.com>

When Josh said:

> Other than that, this looks good; once you've made that change:
> Reviewed-by: Josh Triplett <josh@joshtriplett.org>

What he was asking you to do was add the Reviewed-by line to the next
version of your patch.  That will tell the kernel maintainer that Josh
reviewed your patch and it seems fine to him.  There are also other
patch 'tags' that people use, like 'Suggested-by', 'Acked-by', etc.

So, can you send a v3 with Josh's Reviewed-by line below your
Signed-off-by line?

Sarah Sharp

> 
> ---
>  drivers/staging/silicom/bp_mod.h |    2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/staging/silicom/bp_mod.h b/drivers/staging/silicom/bp_mod.h
> index cfa1f43..8154a7b 100644
> --- a/drivers/staging/silicom/bp_mod.h
> +++ b/drivers/staging/silicom/bp_mod.h
> @@ -22,7 +22,7 @@ do {						\
>  	int  i;					\
>  	if (1) {				\
>  		for (i = 0; i < 1000; i++) {	\
> -			udelay(x) ;		\
> +			udelay(x);		\
>  		}				\
>  	} else {				\
>  		msleep(x);			\
> -- 
> 1.7.9.5
> 
> -- 
> You received this message because you are subscribed to the Google Groups "opw-kernel" group.
> To unsubscribe from this group and stop receiving emails from it, send an email to opw-kernel+unsubscribe@googlegroups.com.
> For more options, visit https://groups.google.com/groups/opt_out.

Patch
diff mbox

diff --git a/drivers/staging/silicom/bp_mod.h b/drivers/staging/silicom/bp_mod.h
index cfa1f43..8154a7b 100644
--- a/drivers/staging/silicom/bp_mod.h
+++ b/drivers/staging/silicom/bp_mod.h
@@ -22,7 +22,7 @@  do {						\
 	int  i;					\
 	if (1) {				\
 		for (i = 0; i < 1000; i++) {	\
-			udelay(x) ;		\
+			udelay(x);		\
 		}				\
 	} else {				\
 		msleep(x);			\