[OPW,kernel] Fix checkpatch.pl issues with braces {} are not necessary for single statement blocks
diff mbox

Message ID 1380965958-4545-1-git-send-email-ebru.akagunduz@gmail.com
State Changes Requested
Headers show

Commit Message

Ebru Akagündüz Oct. 5, 2013, 9:39 a.m. UTC
---
 drivers/staging/xgifb/vb_setmode.c | 6 ++----
 1 file changed, 2 insertions(+), 4 deletions(-)

Comments

Josh Triplett Oct. 5, 2013, 6:02 p.m. UTC | #1
On Sat, Oct 05, 2013 at 12:39:18PM +0300, Ebru Akagunduz wrote:

The patch looks good, but you need a Signed-off-by.

Once you have that:
Reviewed-by: Josh Triplett <josh@joshtriplett.org>

> ---
>  drivers/staging/xgifb/vb_setmode.c | 6 ++----
>  1 file changed, 2 insertions(+), 4 deletions(-)
> 
> diff --git a/drivers/staging/xgifb/vb_setmode.c b/drivers/staging/xgifb/vb_setmode.c
> index 46dea3f..eed58f9 100644
> --- a/drivers/staging/xgifb/vb_setmode.c
> +++ b/drivers/staging/xgifb/vb_setmode.c
> @@ -5274,9 +5274,8 @@ void XGI_SenseCRT1(struct vb_device_info *pVBInfo)
>  
>  	outb(0x00, pVBInfo->P3c8);
>  
> -	for (i = 0; i < 256 * 3; i++) {
> +	for (i = 0; i < 256 * 3; i++)
>  		outb(0x0F, (pVBInfo->P3c8 + 1)); /* DAC_TEST_PARMS */
> -	}
>  
>  	mdelay(1);
>  
> @@ -5291,9 +5290,8 @@ void XGI_SenseCRT1(struct vb_device_info *pVBInfo)
>  	/* avoid display something, set BLACK DAC if not restore DAC */
>  	outb(0x00, pVBInfo->P3c8);
>  
> -	for (i = 0; i < 256 * 3; i++) {
> +	for (i = 0; i < 256 * 3; i++)
>  		outb(0, (pVBInfo->P3c8 + 1));
> -	}
>  
>  	xgifb_reg_set(pVBInfo->P3c4, 0x01, SR01);
>  	xgifb_reg_set(pVBInfo->P3d4, 0x63, CR63);
> -- 
> 1.8.1.2
> 
> -- 
> You received this message because you are subscribed to the Google Groups "opw-kernel" group.
> To unsubscribe from this group and stop receiving emails from it, send an email to opw-kernel+unsubscribe@googlegroups.com.
> For more options, visit https://groups.google.com/groups/opt_out.

Patch
diff mbox

diff --git a/drivers/staging/xgifb/vb_setmode.c b/drivers/staging/xgifb/vb_setmode.c
index 46dea3f..eed58f9 100644
--- a/drivers/staging/xgifb/vb_setmode.c
+++ b/drivers/staging/xgifb/vb_setmode.c
@@ -5274,9 +5274,8 @@  void XGI_SenseCRT1(struct vb_device_info *pVBInfo)
 
 	outb(0x00, pVBInfo->P3c8);
 
-	for (i = 0; i < 256 * 3; i++) {
+	for (i = 0; i < 256 * 3; i++)
 		outb(0x0F, (pVBInfo->P3c8 + 1)); /* DAC_TEST_PARMS */
-	}
 
 	mdelay(1);
 
@@ -5291,9 +5290,8 @@  void XGI_SenseCRT1(struct vb_device_info *pVBInfo)
 	/* avoid display something, set BLACK DAC if not restore DAC */
 	outb(0x00, pVBInfo->P3c8);
 
-	for (i = 0; i < 256 * 3; i++) {
+	for (i = 0; i < 256 * 3; i++)
 		outb(0, (pVBInfo->P3c8 + 1));
-	}
 
 	xgifb_reg_set(pVBInfo->P3c4, 0x01, SR01);
 	xgifb_reg_set(pVBInfo->P3d4, 0x63, CR63);