[OPW,kernel] Fix checkpatch.pl issues with braces {} are not necessary for any arm of this statement in vb_setmode.c
diff mbox

Message ID 1380966323-4719-1-git-send-email-ebru.akagunduz@gmail.com
State Changes Requested
Headers show

Commit Message

Ebru Akagündüz Oct. 5, 2013, 9:45 a.m. UTC
---
 drivers/staging/xgifb/vb_setmode.c | 5 ++---
 1 file changed, 2 insertions(+), 3 deletions(-)

Comments

Josh Triplett Oct. 5, 2013, 6:03 p.m. UTC | #1
On Sat, Oct 05, 2013 at 12:45:23PM +0300, Ebru Akagunduz wrote:

The patch looks good, but you need a Signed-off-by.

Once you have that:
Reviewed-by: Josh Triplett <josh@joshtriplett.org>

> ---
>  drivers/staging/xgifb/vb_setmode.c | 5 ++---
>  1 file changed, 2 insertions(+), 3 deletions(-)
> 
> diff --git a/drivers/staging/xgifb/vb_setmode.c b/drivers/staging/xgifb/vb_setmode.c
> index eed58f9..400c726 100644
> --- a/drivers/staging/xgifb/vb_setmode.c
> +++ b/drivers/staging/xgifb/vb_setmode.c
> @@ -845,11 +845,10 @@ static unsigned short XGI_GetVCLK2Ptr(unsigned short ModeIdIndex,
>  			VCLKIndex = TVCLKBASE_315_25 + HiTVVCLK;
>  
>  		if (pVBInfo->SetFlag & TVSimuMode) {
> -			if (modeflag & Charx8Dot) {
> +			if (modeflag & Charx8Dot)
>  				VCLKIndex = TVCLKBASE_315_25 + HiTVSimuVCLK;
> -			} else {
> +			else
>  				VCLKIndex = TVCLKBASE_315_25 + HiTVTextVCLK;
> -			}
>  		}
>  
>  		/* 301lv */
> -- 
> 1.8.1.2
> 
> -- 
> You received this message because you are subscribed to the Google Groups "opw-kernel" group.
> To unsubscribe from this group and stop receiving emails from it, send an email to opw-kernel+unsubscribe@googlegroups.com.
> For more options, visit https://groups.google.com/groups/opt_out.

Patch
diff mbox

diff --git a/drivers/staging/xgifb/vb_setmode.c b/drivers/staging/xgifb/vb_setmode.c
index eed58f9..400c726 100644
--- a/drivers/staging/xgifb/vb_setmode.c
+++ b/drivers/staging/xgifb/vb_setmode.c
@@ -845,11 +845,10 @@  static unsigned short XGI_GetVCLK2Ptr(unsigned short ModeIdIndex,
 			VCLKIndex = TVCLKBASE_315_25 + HiTVVCLK;
 
 		if (pVBInfo->SetFlag & TVSimuMode) {
-			if (modeflag & Charx8Dot) {
+			if (modeflag & Charx8Dot)
 				VCLKIndex = TVCLKBASE_315_25 + HiTVSimuVCLK;
-			} else {
+			else
 				VCLKIndex = TVCLKBASE_315_25 + HiTVTextVCLK;
-			}
 		}
 
 		/* 301lv */