[OPW,kernel] Fix checkpatch.pl issues with quoted string split across lines in hfa384x_usb.c
diff mbox

Message ID 1380967665-5059-1-git-send-email-ebru.akagunduz@gmail.com
State Changes Requested
Headers show

Commit Message

Ebru Akagündüz Oct. 5, 2013, 10:07 a.m. UTC
---
 drivers/staging/wlan-ng/hfa384x_usb.c | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

Comments

Josh Triplett Oct. 5, 2013, 6:03 p.m. UTC | #1
On Sat, Oct 05, 2013 at 01:07:45PM +0300, Ebru Akagunduz wrote:

The patch looks good, but you need a Signed-off-by.

Once you have that:
Reviewed-by: Josh Triplett <josh@joshtriplett.org>

> ---
>  drivers/staging/wlan-ng/hfa384x_usb.c | 8 ++++----
>  1 file changed, 4 insertions(+), 4 deletions(-)
> 
> diff --git a/drivers/staging/wlan-ng/hfa384x_usb.c b/drivers/staging/wlan-ng/hfa384x_usb.c
> index c1a8cb6..c0e3ec9 100644
> --- a/drivers/staging/wlan-ng/hfa384x_usb.c
> +++ b/drivers/staging/wlan-ng/hfa384x_usb.c
> @@ -4139,13 +4139,13 @@ static int hfa384x_isgood_pdrcode(u16 pdrcode)
>  	default:
>  		if (pdrcode < 0x1000) {
>  			/* code is OK, but we don't know exactly what it is */
> -			pr_debug("Encountered unknown PDR#=0x%04x, "
> -				 "assuming it's ok.\n", pdrcode);
> +			pr_debug("Encountered unknown PDR#=0x%04x, assuming it's ok.\n",
> +				 pdrcode);
>  			return 1;
>  		} else {
>  			/* bad code */
> -			pr_debug("Encountered unknown PDR#=0x%04x, "
> -				 "(>=0x1000), assuming it's bad.\n", pdrcode);
> +			pr_debug("Encountered unknown PDR#=0x%04x, (>=0x1000), assuming it's bad.\n",
> +				 pdrcode);
>  			return 0;
>  		}
>  		break;
> -- 
> 1.8.1.2
> 
> -- 
> You received this message because you are subscribed to the Google Groups "opw-kernel" group.
> To unsubscribe from this group and stop receiving emails from it, send an email to opw-kernel+unsubscribe@googlegroups.com.
> For more options, visit https://groups.google.com/groups/opt_out.

Patch
diff mbox

diff --git a/drivers/staging/wlan-ng/hfa384x_usb.c b/drivers/staging/wlan-ng/hfa384x_usb.c
index c1a8cb6..c0e3ec9 100644
--- a/drivers/staging/wlan-ng/hfa384x_usb.c
+++ b/drivers/staging/wlan-ng/hfa384x_usb.c
@@ -4139,13 +4139,13 @@  static int hfa384x_isgood_pdrcode(u16 pdrcode)
 	default:
 		if (pdrcode < 0x1000) {
 			/* code is OK, but we don't know exactly what it is */
-			pr_debug("Encountered unknown PDR#=0x%04x, "
-				 "assuming it's ok.\n", pdrcode);
+			pr_debug("Encountered unknown PDR#=0x%04x, assuming it's ok.\n",
+				 pdrcode);
 			return 1;
 		} else {
 			/* bad code */
-			pr_debug("Encountered unknown PDR#=0x%04x, "
-				 "(>=0x1000), assuming it's bad.\n", pdrcode);
+			pr_debug("Encountered unknown PDR#=0x%04x, (>=0x1000), assuming it's bad.\n",
+				 pdrcode);
 			return 0;
 		}
 		break;