[OPW,kernel] Staging: rmgr: quoted string split across lines
diff mbox

Message ID 1380975002-6454-1-git-send-email-ebru.akagunduz@gmail.com
State Changes Requested
Headers show

Commit Message

Ebru Akagündüz Oct. 5, 2013, 12:10 p.m. UTC
Fix checkpatch.pl issues quoted string split across lines in drivers/staging/tidspbridge/rmgr/mgr.c
---
 drivers/staging/tidspbridge/rmgr/mgr.c | 9 +++++----
 1 file changed, 5 insertions(+), 4 deletions(-)

Comments

Ebru Akagündüz Oct. 5, 2013, 12:20 p.m. UTC | #1
I'm sorry, I wrote wrong subject, it should be "Staging:  tidspbridge: .."
and I can avoid 80 character warning writing "__func__" below line, so I
will resend it.
Xenia Ragiadakou Oct. 5, 2013, 12:29 p.m. UTC | #2
Hi Ebru,

I noticed that there is not Signed-off-by in your patches. You will need 
to fix this for all the patches you have sent untill now that do not 
have your signature.
Do you use commit -s -v to commit your changes?

ksenia

On 10/05/2013 03:10 PM, Ebru Akagunduz wrote:
> Fix checkpatch.pl issues quoted string split across lines in drivers/staging/tidspbridge/rmgr/mgr.c
> ---
>   drivers/staging/tidspbridge/rmgr/mgr.c | 9 +++++----
>   1 file changed, 5 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/staging/tidspbridge/rmgr/mgr.c b/drivers/staging/tidspbridge/rmgr/mgr.c
> index b32ba0a..158a17c 100644
> --- a/drivers/staging/tidspbridge/rmgr/mgr.c
> +++ b/drivers/staging/tidspbridge/rmgr/mgr.c
> @@ -266,15 +266,16 @@ int mgr_enum_processor_info(u32 processor_id,
>   			 * this is a clumsy overwrite */
>   			processor_info->processor_type = DSPTYPE64;
>   		} else {
> -			dev_dbg(bridge, "%s: Failed to get DCD processor info "
> -				"%x\n", __func__, status2);
> +			dev_dbg(bridge,
> +				"%s: Failed to get DCD processor info %x\n", __func__,
> +				status2);
>   			status = -EPERM;
>   		}
>   	}
>   	*pu_num_procs = proc_index;
>   	if (proc_detect == false) {
> -		dev_dbg(bridge, "%s: Failed to get proc info from DCD, so use "
> -			"CFG registry\n", __func__);
> +		dev_dbg(bridge,
> +			"%s: Failed to get proc info from DCD, so use CFG registry\n", __func__);
>   		processor_info->processor_type = DSPTYPE64;
>   	}
>   func_end:
Ebru Akagündüz Oct. 5, 2013, 12:38 p.m. UTC | #3
You are right, I forgot to add Signed-off. I will resend adding Signed-off
to all my pathces. Thanks. I don't use -s, -v option. I write commits using
nano editor.
Jasna Ben?i? Oct. 5, 2013, 1 p.m. UTC | #4
Ebru,

Minor suggestion. You should consider setting up Vim editor as on kernel
newbies site http://kernelnewbies.org/OPWfirstpatch. It will save you a lot
of effort now and in the future. And send patches via mutt or git send-mail
as on tutorial otherwise you'll burn yourself out.


2013/10/5 Ebru Akagunduz <ebru.akagunduz@gmail.com>

> You are right, I forgot to add Signed-off. I will resend adding Signed-off
> to all my pathces. Thanks. I don't use -s, -v option. I write commits using
> nano editor.
> --
> *Ebru
>
> *
> *http://www.ebruakagunduz.com/
> *
>
> --
> You received this message because you are subscribed to the Google Groups
> "opw-kernel" group.
> To unsubscribe from this group and stop receiving emails from it, send an
> email to opw-kernel+unsubscribe@googlegroups.com.
> For more options, visit https://groups.google.com/groups/opt_out.
>
Ebru Akagündüz Oct. 5, 2013, 1:27 p.m. UTC | #5
Actually,  I use git send-mail, I will fix my patch using git rebase for
old commits.
http://darrinholst.com/post/359817782
Xenia Ragiadakou Oct. 5, 2013, 1:55 p.m. UTC | #6
On 10/05/2013 03:38 PM, Ebru Akagunduz wrote:
> You are right, I forgot to add Signed-off. I will resend adding 
> Signed-off to all my pathces. Thanks. I don't use -s, -v option. I 
> write commits using nano editor.
> -- 
> /Ebru
>
> /
> /http://www.ebruakagunduz.com/
> /

Why you don't use -s option? is there a reason that you prefer to edit 
it manually? That way is no possible to forget it.

ksenia
Ebru Akagündüz Oct. 5, 2013, 2:03 p.m. UTC | #7
No, I will use -s option anymore.
Greg Kroah-Hartman Oct. 7, 2013, 5:56 a.m. UTC | #8
On Sat, Oct 05, 2013 at 03:10:02PM +0300, Ebru Akagunduz wrote:
> Fix checkpatch.pl issues quoted string split across lines in drivers/staging/tidspbridge/rmgr/mgr.c
> ---

You are missing a signed-off-by line :(

Patch
diff mbox

diff --git a/drivers/staging/tidspbridge/rmgr/mgr.c b/drivers/staging/tidspbridge/rmgr/mgr.c
index b32ba0a..158a17c 100644
--- a/drivers/staging/tidspbridge/rmgr/mgr.c
+++ b/drivers/staging/tidspbridge/rmgr/mgr.c
@@ -266,15 +266,16 @@  int mgr_enum_processor_info(u32 processor_id,
 			 * this is a clumsy overwrite */
 			processor_info->processor_type = DSPTYPE64;
 		} else {
-			dev_dbg(bridge, "%s: Failed to get DCD processor info "
-				"%x\n", __func__, status2);
+			dev_dbg(bridge,
+				"%s: Failed to get DCD processor info %x\n", __func__,
+				status2);
 			status = -EPERM;
 		}
 	}
 	*pu_num_procs = proc_index;
 	if (proc_detect == false) {
-		dev_dbg(bridge, "%s: Failed to get proc info from DCD, so use "
-			"CFG registry\n", __func__);
+		dev_dbg(bridge,
+			"%s: Failed to get proc info from DCD, so use CFG registry\n", __func__);
 		processor_info->processor_type = DSPTYPE64;
 	}
 func_end: