[OPW,kernel] Staging: tidspbridge: fix quoted string split across lines
diff mbox

Message ID 1380976026-6675-1-git-send-email-ebru.akagunduz@gmail.com
State Changes Requested
Headers show

Commit Message

Ebru Akagündüz Oct. 5, 2013, 12:27 p.m. UTC
Fix checkpatch.pl issues quoted string split across lines in mgr.c
---
 drivers/staging/tidspbridge/rmgr/mgr.c | 9 ++++-----
 1 file changed, 4 insertions(+), 5 deletions(-)

Comments

Josh Triplett Oct. 5, 2013, 6:57 p.m. UTC | #1
On Sat, Oct 05, 2013 at 03:27:06PM +0300, Ebru Akagunduz wrote:
> Fix checkpatch.pl issues quoted string split across lines in mgr.c
> ---

These are actually false positives; the quoted string isn't split across
lines, it's just not on the same line as the dev_dbg.  You can ignore
these.

(Also, you missed the Signed-off-by.)

- Josh Triplett

>  drivers/staging/tidspbridge/rmgr/mgr.c | 9 ++++-----
>  1 file changed, 4 insertions(+), 5 deletions(-)
> 
> diff --git a/drivers/staging/tidspbridge/rmgr/mgr.c b/drivers/staging/tidspbridge/rmgr/mgr.c
> index 158a17c..6f8d629 100644
> --- a/drivers/staging/tidspbridge/rmgr/mgr.c
> +++ b/drivers/staging/tidspbridge/rmgr/mgr.c
> @@ -266,16 +266,15 @@ int mgr_enum_processor_info(u32 processor_id,
>  			 * this is a clumsy overwrite */
>  			processor_info->processor_type = DSPTYPE64;
>  		} else {
> -			dev_dbg(bridge,
> -				"%s: Failed to get DCD processor info %x\n", __func__,
> -				status2);
> +			dev_dbg(bridge, "%s: Failed to get DCD processor info %x\n",
> +				__func__, status2);
>  			status = -EPERM;
>  		}
>  	}
>  	*pu_num_procs = proc_index;
>  	if (proc_detect == false) {
> -		dev_dbg(bridge,
> -			"%s: Failed to get proc info from DCD, so use CFG registry\n", __func__);
> +		dev_dbg(bridge, "%s: Failed to get proc info from DCD, so use CFG registry\n",
> +			__func__);
>  		processor_info->processor_type = DSPTYPE64;
>  	}
>  func_end:
> -- 
> 1.8.1.2
> 
> -- 
> You received this message because you are subscribed to the Google Groups "opw-kernel" group.
> To unsubscribe from this group and stop receiving emails from it, send an email to opw-kernel+unsubscribe@googlegroups.com.
> For more options, visit https://groups.google.com/groups/opt_out.
Ebru Akagündüz Oct. 8, 2013, 3:19 p.m. UTC | #2
I'll add Signed-off-by and resend this patch.

Patch
diff mbox

diff --git a/drivers/staging/tidspbridge/rmgr/mgr.c b/drivers/staging/tidspbridge/rmgr/mgr.c
index 158a17c..6f8d629 100644
--- a/drivers/staging/tidspbridge/rmgr/mgr.c
+++ b/drivers/staging/tidspbridge/rmgr/mgr.c
@@ -266,16 +266,15 @@  int mgr_enum_processor_info(u32 processor_id,
 			 * this is a clumsy overwrite */
 			processor_info->processor_type = DSPTYPE64;
 		} else {
-			dev_dbg(bridge,
-				"%s: Failed to get DCD processor info %x\n", __func__,
-				status2);
+			dev_dbg(bridge, "%s: Failed to get DCD processor info %x\n",
+				__func__, status2);
 			status = -EPERM;
 		}
 	}
 	*pu_num_procs = proc_index;
 	if (proc_detect == false) {
-		dev_dbg(bridge,
-			"%s: Failed to get proc info from DCD, so use CFG registry\n", __func__);
+		dev_dbg(bridge, "%s: Failed to get proc info from DCD, so use CFG registry\n",
+			__func__);
 		processor_info->processor_type = DSPTYPE64;
 	}
 func_end: