[OPW,kernel] Staging: Removal of Unnecessary white spaces
diff mbox

Message ID 20131005124047.GA4934@gmail.com
State Changes Requested
Headers show

Commit Message

Rashika Oct. 5, 2013, 12:40 p.m. UTC
The patch fixes the WARNING: unnecessary whitespace before a quoted
newline detected via checkpatch.pl

Signed-off-by: Rashika <rashika.kheria@gmail.com>
---
 drivers/staging/btmtk_usb/btmtk_usb.c |    4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

Comments

Xenia Ragiadakou Oct. 5, 2013, 1:44 p.m. UTC | #1
Hi Rashika,

On 10/05/2013 03:40 PM, Rashika wrote:
> The patch fixes the WARNING: unnecessary whitespace before a quoted
> newline detected via checkpatch.pl
>
> Signed-off-by: Rashika <rashika.kheria@gmail.com>
> ---

One more thing, that i did not notice before is that you do not sign 
your patches with your full name.
That may be a problem, so etup youn name in git to correspond to your 
full name.

Other than that (and the subject line that doesnot report the driver) 
the last two patches of yours look fine to me.

ksenia

>   drivers/staging/btmtk_usb/btmtk_usb.c |    4 ++--
>   1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/staging/btmtk_usb/btmtk_usb.c b/drivers/staging/btmtk_usb/btmtk_usb.c
> index 9386b93..1a31f68 100644
> --- a/drivers/staging/btmtk_usb/btmtk_usb.c
> +++ b/drivers/staging/btmtk_usb/btmtk_usb.c
> @@ -191,7 +191,7 @@ static void btmtk_usb_cap_init(struct btmtk_usb_data *data)
>   		ret = request_firmware(&firmware, MT7650_FIRMWARE, &udev->dev);
>   		if (ret < 0) {
>   			if (ret == -ENOENT) {
> -				BT_ERR("Firmware file \"%s\" not found \n",
> +				BT_ERR("Firmware file \"%s\" not found\n",
>   						MT7650_FIRMWARE);
>   			} else {
>   				BT_ERR("Firmware file \"%s\" request failed
> @@ -199,7 +199,7 @@ static void btmtk_usb_cap_init(struct btmtk_usb_data *data)
>   						ret);
>   			}
>   		} else {
> -			BT_DBG("Firmware file \"%s\" Found \n",
> +			BT_DBG("Firmware file \"%s\" Found\n",
>   					MT7650_FIRMWARE);
>   			/* load firmware here */
>   			data->firmware = firmware;
Rashika Oct. 5, 2013, 4:56 p.m. UTC | #2
Hi Ksenia,

Since now all the changes made in the entire file btmtk_usb.c are already
committed and the patches were stored in /tmp folder therefore I cannot
resend the rest of three patches with correct subject. Will that be okay?

Thanks,
Rashika Kheria


On Sat, Oct 5, 2013 at 7:14 PM, Xenia Ragiadakou <burzalodowa@gmail.com>wrote:

> Hi Rashika,
>
>
> On 10/05/2013 03:40 PM, Rashika wrote:
>
>> The patch fixes the WARNING: unnecessary whitespace before a quoted
>> newline detected via checkpatch.pl
>>
>> Signed-off-by: Rashika <rashika.kheria@gmail.com>
>> ---
>>
>
> One more thing, that i did not notice before is that you do not sign your
> patches with your full name.
> That may be a problem, so etup youn name in git to correspond to your full
> name.
>
> Other than that (and the subject line that doesnot report the driver) the
> last two patches of yours look fine to me.
>
> ksenia
>
>
>    drivers/staging/btmtk_usb/**btmtk_usb.c |    4 ++--
>>   1 file changed, 2 insertions(+), 2 deletions(-)
>>
>> diff --git a/drivers/staging/btmtk_usb/**btmtk_usb.c
>> b/drivers/staging/btmtk_usb/**btmtk_usb.c
>> index 9386b93..1a31f68 100644
>> --- a/drivers/staging/btmtk_usb/**btmtk_usb.c
>> +++ b/drivers/staging/btmtk_usb/**btmtk_usb.c
>> @@ -191,7 +191,7 @@ static void btmtk_usb_cap_init(struct btmtk_usb_data
>> *data)
>>                 ret = request_firmware(&firmware, MT7650_FIRMWARE,
>> &udev->dev);
>>                 if (ret < 0) {
>>                         if (ret == -ENOENT) {
>> -                               BT_ERR("Firmware file \"%s\" not found
>> \n",
>> +                               BT_ERR("Firmware file \"%s\" not found\n",
>>                                                 MT7650_FIRMWARE);
>>                         } else {
>>                                 BT_ERR("Firmware file \"%s\" request
>> failed
>> @@ -199,7 +199,7 @@ static void btmtk_usb_cap_init(struct btmtk_usb_data
>> *data)
>>                                                 ret);
>>                         }
>>                 } else {
>> -                       BT_DBG("Firmware file \"%s\" Found \n",
>> +                       BT_DBG("Firmware file \"%s\" Found\n",
>>                                         MT7650_FIRMWARE);
>>                         /* load firmware here */
>>                         data->firmware = firmware;
>>
>
>

Patch
diff mbox

diff --git a/drivers/staging/btmtk_usb/btmtk_usb.c b/drivers/staging/btmtk_usb/btmtk_usb.c
index 9386b93..1a31f68 100644
--- a/drivers/staging/btmtk_usb/btmtk_usb.c
+++ b/drivers/staging/btmtk_usb/btmtk_usb.c
@@ -191,7 +191,7 @@  static void btmtk_usb_cap_init(struct btmtk_usb_data *data)
 		ret = request_firmware(&firmware, MT7650_FIRMWARE, &udev->dev);
 		if (ret < 0) {
 			if (ret == -ENOENT) {
-				BT_ERR("Firmware file \"%s\" not found \n",
+				BT_ERR("Firmware file \"%s\" not found\n",
 						MT7650_FIRMWARE);
 			} else {
 				BT_ERR("Firmware file \"%s\" request failed
@@ -199,7 +199,7 @@  static void btmtk_usb_cap_init(struct btmtk_usb_data *data)
 						ret);
 			}
 		} else {
-			BT_DBG("Firmware file \"%s\" Found \n",
+			BT_DBG("Firmware file \"%s\" Found\n",
 					MT7650_FIRMWARE);
 			/* load firmware here */
 			data->firmware = firmware;