[OPW,kernel,v2] Fix checkpatch.pl issues with braces {} are not necessary for any arm of this statement in vb_setmode.c
diff mbox

Message ID 1380982570-11747-1-git-send-email-ebru.akagunduz@gmail.com
State Changes Requested
Headers show

Commit Message

Ebru Akagündüz Oct. 5, 2013, 2:16 p.m. UTC
Signed-off-by: Ebru Akagunduz <ebru.akagunduz@gmail.com>
---
 drivers/staging/xgifb/vb_setmode.c | 5 ++---
 1 file changed, 2 insertions(+), 3 deletions(-)

Comments

Xenia Ragiadakou Oct. 5, 2013, 2:26 p.m. UTC | #1
Hi Ebru,

Your other two patches are great! Let 's wait for Greg to review them. 
In this one you have messed the subject line with the changelog. You can 
use $ commit --amend to fix it. Other than that looks fine :)

ksenia

On 10/05/2013 05:16 PM, Ebru Akagunduz wrote:
> Signed-off-by: Ebru Akagunduz <ebru.akagunduz@gmail.com>
> ---
>   drivers/staging/xgifb/vb_setmode.c | 5 ++---
>   1 file changed, 2 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/staging/xgifb/vb_setmode.c b/drivers/staging/xgifb/vb_setmode.c
> index eed58f9..400c726 100644
> --- a/drivers/staging/xgifb/vb_setmode.c
> +++ b/drivers/staging/xgifb/vb_setmode.c
> @@ -845,11 +845,10 @@ static unsigned short XGI_GetVCLK2Ptr(unsigned short ModeIdIndex,
>   			VCLKIndex = TVCLKBASE_315_25 + HiTVVCLK;
>   
>   		if (pVBInfo->SetFlag & TVSimuMode) {
> -			if (modeflag & Charx8Dot) {
> +			if (modeflag & Charx8Dot)
>   				VCLKIndex = TVCLKBASE_315_25 + HiTVSimuVCLK;
> -			} else {
> +			else
>   				VCLKIndex = TVCLKBASE_315_25 + HiTVTextVCLK;
> -			}
>   		}
>   
>   		/* 301lv */
Ebru Akagündüz Oct. 5, 2013, 2:56 p.m. UTC | #2
Thank you for your suggestions.

Best Regards.

Patch
diff mbox

diff --git a/drivers/staging/xgifb/vb_setmode.c b/drivers/staging/xgifb/vb_setmode.c
index eed58f9..400c726 100644
--- a/drivers/staging/xgifb/vb_setmode.c
+++ b/drivers/staging/xgifb/vb_setmode.c
@@ -845,11 +845,10 @@  static unsigned short XGI_GetVCLK2Ptr(unsigned short ModeIdIndex,
 			VCLKIndex = TVCLKBASE_315_25 + HiTVVCLK;
 
 		if (pVBInfo->SetFlag & TVSimuMode) {
-			if (modeflag & Charx8Dot) {
+			if (modeflag & Charx8Dot)
 				VCLKIndex = TVCLKBASE_315_25 + HiTVSimuVCLK;
-			} else {
+			else
 				VCLKIndex = TVCLKBASE_315_25 + HiTVTextVCLK;
-			}
 		}
 
 		/* 301lv */