[OPW,kernel] Re: [PATCH v2] Staging: btmtk_usb: Fix incorrect brace placement
diff mbox

Message ID 9a6c133b-7b44-422a-873f-6e98b6b219a0@googlegroups.com
State Superseded
Headers show

Commit Message

Rashika Oct. 5, 2013, 7:17 p.m. UTC
The patch fixes the following checkpatch.pl warning in btmtk_usb.c
WARNING: braces {} are not necessary for single statement blocks

Signed-off-by: Rashika Kheria <rashika.kheria@gmail.com>
---

This revision fixes the following issues from the previous revision-
Driver Name not mentioned in Subject

 drivers/staging/btmtk_usb/
btmtk_usb.c |   12 ++++--------
 1 file changed, 4 insertions(+), 8 deletions(-)

        return ret;
 }
@@ -691,9 +689,8 @@ loadfw_protect:
                        /* U2M_PDMA descriptor */
                        btmtk_usb_io_write32(data, 0x230, cur_len);

-                       while ((sent_len % 4) != 0) {
+                       while ((sent_len % 4) != 0)
                                sent_len++;
-                       }

                        /* U2M_PDMA length */
                        btmtk_usb_io_write32(data, 0x234, sent_len << 16);
@@ -946,9 +943,8 @@ static void btmtk_usb_bulk_in_complete(struct urb *urb)
        BT_DBG("%s:%s urb %p status %d count %d", __func__, hdev->name,
                                        urb, urb->status, 
urb->actual_length);

-       if (!test_bit(HCI_RUNNING, &hdev->flags)) {
+       if (!test_bit(HCI_RUNNING, &hdev->flags))
                return;
-       }

        if (urb->status == 0) {
                hdev->stat.byte_rx += urb->actual_length;

Patch
diff mbox

diff --git a/drivers/staging/btmtk_usb/btmtk_usb.c 
b/drivers/staging/btmtk_usb/btmtk_usb.c
index 0acd491..3dd83d2 100644
--- a/drivers/staging/btmtk_usb/btmtk_usb.c
+++ b/drivers/staging/btmtk_usb/btmtk_usb.c
@@ -249,9 +249,8 @@  static u16 checksume16(u8 *pData, int len)
        if (len)
                sum += *((u8 *)pData);

-       while (sum >> 16) {
+       while (sum >> 16)
                sum = (sum & 0xFFFF) + (sum >> 16);
-       }

        return ~sum;
 }
@@ -270,9 +269,8 @@  static int btmtk_usb_chk_crc(struct btmtk_usb_data 
*data, u32 checksum_len)
                        DEVICE_VENDOR_REQUEST_IN, 0x20, 0x00, data->io_buf, 
8,
                        CONTROL_TIMEOUT_JIFFIES);

-       if (ret < 0) {
+       if (ret < 0)
                BT_ERR("%s error(%d)\n", __func__, ret);
-       }