[OPW,kernel] Staging: nvec: fix space required before the open parenthesis
diff mbox

Message ID 1381064306-8115-1-git-send-email-ebru.akagunduz@gmail.com
State Not Applicable
Headers show

Commit Message

Ebru Akagündüz Oct. 6, 2013, 12:58 p.m. UTC
Fix checkpatch.pl issues with space required before the open parenthesis '(' in nvec.c

Signed-off-by: Ebru Akagunduz <ebru.akagunduz@gmail.com>
---
 drivers/staging/nvec/nvec.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Josh Triplett Oct. 6, 2013, 9:23 p.m. UTC | #1
On Sun, Oct 06, 2013 at 03:58:26PM +0300, Ebru Akagunduz wrote:
> Fix checkpatch.pl issues with space required before the open parenthesis '(' in nvec.c

You need to word-wrap your commit message.

If you're using vim, try "gqap" (gq is "wrap", ap is "a paragraph").

> Signed-off-by: Ebru Akagunduz <ebru.akagunduz@gmail.com>
> ---
>  drivers/staging/nvec/nvec.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/staging/nvec/nvec.c b/drivers/staging/nvec/nvec.c
> index 5a5c639..3066ee2 100644
> --- a/drivers/staging/nvec/nvec.c
> +++ b/drivers/staging/nvec/nvec.c
> @@ -802,7 +802,7 @@ static int tegra_nvec_probe(struct platform_device *pdev)
>  		unmute_speakers[] = { NVEC_OEM0, 0x10, 0x59, 0x95 },
>  		enable_event[7] = { NVEC_SYS, CNF_EVENT_REPORTING, true };
>  
> -	if(!pdev->dev.of_node) {
> +	if (!pdev->dev.of_node) {
>  		dev_err(&pdev->dev, "must be instantiated using device tree\n");
>  		return -ENODEV;
>  	}
> -- 
> 1.8.1.2
> 
> -- 
> You received this message because you are subscribed to the Google Groups "opw-kernel" group.
> To unsubscribe from this group and stop receiving emails from it, send an email to opw-kernel+unsubscribe@googlegroups.com.
> For more options, visit https://groups.google.com/groups/opt_out.
Greg Kroah-Hartman Oct. 7, 2013, 5:55 a.m. UTC | #2
On Sun, Oct 06, 2013 at 03:58:26PM +0300, Ebru Akagunduz wrote:
> Fix checkpatch.pl issues with space required before the open parenthesis '(' in nvec.c
> 
> Signed-off-by: Ebru Akagunduz <ebru.akagunduz@gmail.com>
> ---
>  drivers/staging/nvec/nvec.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/staging/nvec/nvec.c b/drivers/staging/nvec/nvec.c
> index 5a5c639..3066ee2 100644
> --- a/drivers/staging/nvec/nvec.c
> +++ b/drivers/staging/nvec/nvec.c
> @@ -802,7 +802,7 @@ static int tegra_nvec_probe(struct platform_device *pdev)
>  		unmute_speakers[] = { NVEC_OEM0, 0x10, 0x59, 0x95 },
>  		enable_event[7] = { NVEC_SYS, CNF_EVENT_REPORTING, true };
>  
> -	if(!pdev->dev.of_node) {
> +	if (!pdev->dev.of_node) {

This is correct, but someone beat you to this patch, and I've applied
their version first, sorry about that.

greg k-h

Patch
diff mbox

diff --git a/drivers/staging/nvec/nvec.c b/drivers/staging/nvec/nvec.c
index 5a5c639..3066ee2 100644
--- a/drivers/staging/nvec/nvec.c
+++ b/drivers/staging/nvec/nvec.c
@@ -802,7 +802,7 @@  static int tegra_nvec_probe(struct platform_device *pdev)
 		unmute_speakers[] = { NVEC_OEM0, 0x10, 0x59, 0x95 },
 		enable_event[7] = { NVEC_SYS, CNF_EVENT_REPORTING, true };
 
-	if(!pdev->dev.of_node) {
+	if (!pdev->dev.of_node) {
 		dev_err(&pdev->dev, "must be instantiated using device tree\n");
 		return -ENODEV;
 	}