[OPW,kernel,v2] Staging: btmtk_usb: Removal of Unnecessary white spaces
diff mbox

Message ID 1381145351-26531-1-git-send-email-rashika.kheria@gmail.com
State Accepted
Headers show

Commit Message

Rashika Oct. 7, 2013, 11:29 a.m. UTC
The patch fixes the following checkpatch.pl warning in btmtk_usb.c
WARNING: unnecessary whitespace before a quoted newline

Signed-off-by: Rashika Kheria <rashika.kheria@gmail.com>
---

This revision fixes the following issues from the previous revision-
Driver Name not mentioned in Subject

 drivers/staging/btmtk_usb/btmtk_usb.c |    6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

Comments

Josh Triplett Oct. 7, 2013, 7:28 p.m. UTC | #1
On Mon, Oct 07, 2013 at 04:59:11PM +0530, Rashika Kheria wrote:
> The patch fixes the following checkpatch.pl warning in btmtk_usb.c
> WARNING: unnecessary whitespace before a quoted newline
> 
> Signed-off-by: Rashika Kheria <rashika.kheria@gmail.com>

Reviewed-by: Josh Triplett <josh@joshtriplett.org>

> ---
> 
> This revision fixes the following issues from the previous revision-
> Driver Name not mentioned in Subject
> 
>  drivers/staging/btmtk_usb/btmtk_usb.c |    6 +++---
>  1 file changed, 3 insertions(+), 3 deletions(-)
> 
> diff --git a/drivers/staging/btmtk_usb/btmtk_usb.c b/drivers/staging/btmtk_usb/btmtk_usb.c
> index ffab202..8b39e54 100644
> --- a/drivers/staging/btmtk_usb/btmtk_usb.c
> +++ b/drivers/staging/btmtk_usb/btmtk_usb.c
> @@ -191,14 +191,14 @@ static void btmtk_usb_cap_init(struct btmtk_usb_data *data)
>  		ret = request_firmware(&firmware, MT7650_FIRMWARE, &udev->dev);
>  		if (ret < 0) {
>  			if (ret == -ENOENT) {
> -				BT_ERR("Firmware file \"%s\" not found \n",
> +				BT_ERR("Firmware file \"%s\" not found\n",
>  						MT7650_FIRMWARE);
>  			} else {
> -				BT_ERR("Firmware file \"%s\" request failed (err=%d) \n",
> +				BT_ERR("Firmware file \"%s\" request failed (err=%d)\n",
>  						MT7650_FIRMWARE, ret);
>  			}
>  		} else {
> -			BT_DBG("Firmware file \"%s\" Found \n",
> +			BT_DBG("Firmware file \"%s\" Found\n",
>  					MT7650_FIRMWARE);
>  			/* load firmware here */
>  			data->firmware = firmware;
> -- 
> 1.7.9.5
> 
> -- 
> You received this message because you are subscribed to the Google Groups "opw-kernel" group.
> To unsubscribe from this group and stop receiving emails from it, send an email to opw-kernel+unsubscribe@googlegroups.com.
> For more options, visit https://groups.google.com/groups/opt_out.
Greg Kroah-Hartman Oct. 8, 2013, 1:31 a.m. UTC | #2
On Mon, Oct 07, 2013 at 04:59:11PM +0530, Rashika Kheria wrote:
> The patch fixes the following checkpatch.pl warning in btmtk_usb.c
> WARNING: unnecessary whitespace before a quoted newline
> 
> Signed-off-by: Rashika Kheria <rashika.kheria@gmail.com>

Why did you send 3 different copies of this patch (with one of them a
bit different than the others.)  I think I've picked the right one to
apply, but if not, please let me know.

thanks,

greg k-h
Sarah Sharp Oct. 8, 2013, 8 p.m. UTC | #3
On Mon, Oct 07, 2013 at 06:31:20PM -0700, Greg KH wrote:
> On Mon, Oct 07, 2013 at 04:59:11PM +0530, Rashika Kheria wrote:
> > The patch fixes the following checkpatch.pl warning in btmtk_usb.c
> > WARNING: unnecessary whitespace before a quoted newline
> > 
> > Signed-off-by: Rashika Kheria <rashika.kheria@gmail.com>
> 
> Why did you send 3 different copies of this patch (with one of them a
> bit different than the others.)  I think I've picked the right one to
> apply, but if not, please let me know.

Rashika, if you're changing the content of a patch, please increase the
revision number of the patch.  If you're not changing the contents of a
patch, please wait for mentor review, and don't send the patch again.
If you haven't seen a response in a week, you can resend the patch with
the subject prefix [RESEND] [PATCH v#] where # is the version number.

Sarah Sharp
Rashika Oct. 8, 2013, 8:07 p.m. UTC | #4
On Wed, Oct 9, 2013 at 1:30 AM, Sarah Sharp <sarah.a.sharp@intel.com> wrote:

> On Mon, Oct 07, 2013 at 06:31:20PM -0700, Greg KH wrote:
> > On Mon, Oct 07, 2013 at 04:59:11PM +0530, Rashika Kheria wrote:
> > > The patch fixes the following checkpatch.pl warning in btmtk_usb.c
> > > WARNING: unnecessary whitespace before a quoted newline
> > >
> > > Signed-off-by: Rashika Kheria <rashika.kheria@gmail.com>
> >
> > Why did you send 3 different copies of this patch (with one of them a
> > bit different than the others.)  I think I've picked the right one to
> > apply, but if not, please let me know.
>
> Rashika, if you're changing the content of a patch, please increase the
> revision number of the patch.  If you're not changing the contents of a
> patch, please wait for mentor review, and don't send the patch again.
> If you haven't seen a response in a week, you can resend the patch with
> the subject prefix [RESEND] [PATCH v#] where # is the version number.
>
> Sarah Sharp
>

Thanks for your guidance. I will keep that in mind for future patches.


>
>

Patch
diff mbox

diff --git a/drivers/staging/btmtk_usb/btmtk_usb.c b/drivers/staging/btmtk_usb/btmtk_usb.c
index ffab202..8b39e54 100644
--- a/drivers/staging/btmtk_usb/btmtk_usb.c
+++ b/drivers/staging/btmtk_usb/btmtk_usb.c
@@ -191,14 +191,14 @@  static void btmtk_usb_cap_init(struct btmtk_usb_data *data)
 		ret = request_firmware(&firmware, MT7650_FIRMWARE, &udev->dev);
 		if (ret < 0) {
 			if (ret == -ENOENT) {
-				BT_ERR("Firmware file \"%s\" not found \n",
+				BT_ERR("Firmware file \"%s\" not found\n",
 						MT7650_FIRMWARE);
 			} else {
-				BT_ERR("Firmware file \"%s\" request failed (err=%d) \n",
+				BT_ERR("Firmware file \"%s\" request failed (err=%d)\n",
 						MT7650_FIRMWARE, ret);
 			}
 		} else {
-			BT_DBG("Firmware file \"%s\" Found \n",
+			BT_DBG("Firmware file \"%s\" Found\n",
 					MT7650_FIRMWARE);
 			/* load firmware here */
 			data->firmware = firmware;