[OPW,kernel,v2] Staging: btmtk_usb: Fix indentation for conditional statement
diff mbox

Message ID 1381146239-26831-1-git-send-email-rashika.kheria@gmail.com
State Superseded
Headers show

Commit Message

Rashika Oct. 7, 2013, 11:43 a.m. UTC
The patch fixes the following checkpatch.pl warning in btmtk_usb.c
WARNING: suspect code indent for conditional statements

Signed-off-by: Rashika Kheria <rashika.kheria@gmail.com>
---

This revision fixes the following issues from the previous revision-
Driver Name not mentioned in Subject

 drivers/staging/btmtk_usb/btmtk_usb.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Josh Triplett Oct. 7, 2013, 7:30 p.m. UTC | #1
On Mon, Oct 07, 2013 at 05:13:59PM +0530, Rashika Kheria wrote:
> The patch fixes the following checkpatch.pl warning in btmtk_usb.c
> WARNING: suspect code indent for conditional statements
> 
> Signed-off-by: Rashika Kheria <rashika.kheria@gmail.com>

This isn't a checkpatch warning I'm very familiar with, but the
indentation fix makes sense (switching to just a tab), so:

Reviewed-by: Josh Triplett <josh@joshtriplett.org>

> ---
> 
> This revision fixes the following issues from the previous revision-
> Driver Name not mentioned in Subject
> 
>  drivers/staging/btmtk_usb/btmtk_usb.c |    2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/staging/btmtk_usb/btmtk_usb.c b/drivers/staging/btmtk_usb/btmtk_usb.c
> index 8b39e54..cfdcf96 100644
> --- a/drivers/staging/btmtk_usb/btmtk_usb.c
> +++ b/drivers/staging/btmtk_usb/btmtk_usb.c
> @@ -1517,7 +1517,7 @@ static void btmtk_usb_work(struct work_struct *work)
>  		__set_isoc_interface(hdev, 0);
>  
>  		if (test_and_clear_bit(BTUSB_DID_ISO_RESUME, &data->flags))
> -			 usb_autopm_put_interface(data->isoc ? data->isoc :
> +			usb_autopm_put_interface(data->isoc ? data->isoc :
>  					 data->intf);
>  	}
>  }
> -- 
> 1.7.9.5
> 
> -- 
> You received this message because you are subscribed to the Google Groups "opw-kernel" group.
> To unsubscribe from this group and stop receiving emails from it, send an email to opw-kernel+unsubscribe@googlegroups.com.
> For more options, visit https://groups.google.com/groups/opt_out.

Patch
diff mbox

diff --git a/drivers/staging/btmtk_usb/btmtk_usb.c b/drivers/staging/btmtk_usb/btmtk_usb.c
index 8b39e54..cfdcf96 100644
--- a/drivers/staging/btmtk_usb/btmtk_usb.c
+++ b/drivers/staging/btmtk_usb/btmtk_usb.c
@@ -1517,7 +1517,7 @@  static void btmtk_usb_work(struct work_struct *work)
 		__set_isoc_interface(hdev, 0);
 
 		if (test_and_clear_bit(BTUSB_DID_ISO_RESUME, &data->flags))
-			 usb_autopm_put_interface(data->isoc ? data->isoc :
+			usb_autopm_put_interface(data->isoc ? data->isoc :
 					 data->intf);
 	}
 }