[OPW,kernel,v2,1/6] Staging: iio: fix strict_strtol is obsolete, use kstrtol instead
diff mbox

Message ID 1381150362-4519-1-git-send-email-ebru.akagunduz@gmail.com
State Rejected
Headers show

Commit Message

Ebru Akagündüz Oct. 7, 2013, 12:52 p.m. UTC
Fix checkpatch.pl issues with strict_strtol is obsolete, use kstrtol
instead in sca3000_ring.c

Signed-off-by: Ebru Akagunduz <ebru.akagunduz@gmail.com>
---
 drivers/staging/iio/accel/sca3000_ring.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Greg Kroah-Hartman Oct. 8, 2013, 1:41 a.m. UTC | #1
On Mon, Oct 07, 2013 at 03:52:42PM +0300, Ebru Akagunduz wrote:
> Fix checkpatch.pl issues with strict_strtol is obsolete, use kstrtol
> instead in sca3000_ring.c
> 
> Signed-off-by: Ebru Akagunduz <ebru.akagunduz@gmail.com>

This patch doesn't apply at all to my tree, any idea what went wrong?

confused,

greg k-h
Sarah Sharp Oct. 8, 2013, 8:56 p.m. UTC | #2
On Mon, Oct 07, 2013 at 06:41:07PM -0700, Greg KH wrote:
> On Mon, Oct 07, 2013 at 03:52:42PM +0300, Ebru Akagunduz wrote:
> > Fix checkpatch.pl issues with strict_strtol is obsolete, use kstrtol
> > instead in sca3000_ring.c
> > 
> > Signed-off-by: Ebru Akagunduz <ebru.akagunduz@gmail.com>
> 
> This patch doesn't apply at all to my tree, any idea what went wrong?

Hi Ebru,

You've tried to send this patch three times:

https://patchwork.kernel.org/patch/2992651/
https://patchwork.kernel.org/patch/2992661/
https://patchwork.kernel.org/patch/2997031/

The first time you sent it, Greg mentioned someone else had already made
this change in his staging tree.  That means he can't apply your patch,
because someone else already made the change.

I think you need to refresh your current tree against the latest
staging-next tree, and rebase your patches on top of that.  I've just
sent Rashika a tutorial on how to do that:

https://groups.google.com/forum/#!msg/opw-kernel/l3Fri8pPT6w/5bvvF7eozvkJ

I would suggest you rebase your tree each time before you send any new
patches.  Let me know if you have issues with these directions.  I'll be
on IRC.

Sarah Sharp
Greg Kroah-Hartman Oct. 8, 2013, 9:27 p.m. UTC | #3
On Tue, Oct 08, 2013 at 01:56:04PM -0700, Sarah Sharp wrote:
> On Mon, Oct 07, 2013 at 06:41:07PM -0700, Greg KH wrote:
> > On Mon, Oct 07, 2013 at 03:52:42PM +0300, Ebru Akagunduz wrote:
> > > Fix checkpatch.pl issues with strict_strtol is obsolete, use kstrtol
> > > instead in sca3000_ring.c
> > > 
> > > Signed-off-by: Ebru Akagunduz <ebru.akagunduz@gmail.com>
> > 
> > This patch doesn't apply at all to my tree, any idea what went wrong?
> 
> Hi Ebru,
> 
> You've tried to send this patch three times:
> 
> https://patchwork.kernel.org/patch/2992651/
> https://patchwork.kernel.org/patch/2992661/
> https://patchwork.kernel.org/patch/2997031/
> 
> The first time you sent it, Greg mentioned someone else had already made
> this change in his staging tree.  That means he can't apply your patch,
> because someone else already made the change.

Yes, please remember that I have an _extremely_ short memory and
attention span, given that I receive about 1000 emails a day that
require me to do something with, and I accept, on average, 22 different
patches from people to the kernel every day of the year.  I don't
remember what an individual sent me yesterday, and sometimes don't
remember what they sent a few hours ago (especially given that timezones
are being crossed all the time with my travel, an example being that
right now I am in Korea, but in 12 hours, will be somewhere in the
United States, and in a week, I'll be in Europe.)

Everything about the patch and patch series needs to be contained in the
patch series itself, you can not rely on previous information being
remembered and retained by anyone.

And never assume that a maintainer remembers what they previously said
about a patch set, be it review comments, or answers to questions about
why they don't apply.  Almost all other kernel subsystem maintainers
are as overworked as I am, given the _huge_ rate of change that we are
managing (7.8 patches applied to the kernel last year, per hour, 24
hours a day.)

The top kernel subsystem maintainers accept patches from 500-700
different individuals over a year, so there really can be no way we can
keep track of who is doing what by us in our heads.  So please be
patient with us, and give us tons of descriptive information about what
is going on with your patch series when you send it, as we can't recall
anything.

> I think you need to refresh your current tree against the latest
> staging-next tree, and rebase your patches on top of that.  I've just
> sent Rashika a tutorial on how to do that:
> 
> https://groups.google.com/forum/#!msg/opw-kernel/l3Fri8pPT6w/5bvvF7eozvkJ

Wonderful, thanks Sarah for writing this up.

greg "what timezone am I in right now?" k-h

Patch
diff mbox

diff --git a/drivers/staging/iio/accel/sca3000_ring.c b/drivers/staging/iio/accel/sca3000_ring.c
index 3e5e860..393100b 100644
--- a/drivers/staging/iio/accel/sca3000_ring.c
+++ b/drivers/staging/iio/accel/sca3000_ring.c
@@ -181,7 +181,7 @@  static ssize_t sca3000_set_ring_int(struct device *dev,
 	int ret;
 
 	mutex_lock(&st->lock);
-	ret = strict_strtol(buf, 10, &val);
+	ret = kstrtol(buf, 10, &val);
 	if (ret)
 		goto error_ret;
 	ret = sca3000_read_data_short(st, SCA3000_REG_ADDR_INT_MASK, 1);