[OPW,kernel,v2] Staging: crystalhd: Fix sparse warnings regarding static functions
diff mbox

Message ID 1381176734-27563-1-git-send-email-valentina.manea.m@gmail.com
State Accepted
Headers show

Commit Message

Valentina Manea Oct. 7, 2013, 8:12 p.m. UTC
This fixes the following sparse warnings:
* drivers/staging/crystalhd/crystalhd_lnx.c:78:29: warning:
symbol 'chd_dec_alloc_iodata' was not declared. Should it be static?
* drivers/staging/crystalhd/crystalhd_lnx.c:99:6: warning:
symbol 'chd_dec_free_iodata' was not declared. Should it be static?
* drivers/staging/crystalhd/crystalhd_lnx.c:630:5: warning:
symbol 'chd_dec_pci_suspend' was not declared. Should it be static?
* drivers/staging/crystalhd/crystalhd_lnx.c:664:5: warning:
symbol 'chd_dec_pci_resume' was not declared. Should it be static?

Signed-off-by: Valentina Manea <valentina.manea.m@gmail.com>
---
Changes since v1:
* put return type on the same line as "static" when breaking line
* fix parameter alignment when adding "static"

 drivers/staging/crystalhd/crystalhd_lnx.c | 13 +++++++------
 1 file changed, 7 insertions(+), 6 deletions(-)

Comments

Josh Triplett Oct. 7, 2013, 8:21 p.m. UTC | #1
On Mon, Oct 07, 2013 at 11:12:14PM +0300, Valentina Manea wrote:
> This fixes the following sparse warnings:
> * drivers/staging/crystalhd/crystalhd_lnx.c:78:29: warning:
> symbol 'chd_dec_alloc_iodata' was not declared. Should it be static?
> * drivers/staging/crystalhd/crystalhd_lnx.c:99:6: warning:
> symbol 'chd_dec_free_iodata' was not declared. Should it be static?
> * drivers/staging/crystalhd/crystalhd_lnx.c:630:5: warning:
> symbol 'chd_dec_pci_suspend' was not declared. Should it be static?
> * drivers/staging/crystalhd/crystalhd_lnx.c:664:5: warning:
> symbol 'chd_dec_pci_resume' was not declared. Should it be static?
> 
> Signed-off-by: Valentina Manea <valentina.manea.m@gmail.com>

Reviewed-by: Josh Triplett <josh@joshtriplett.org>

> ---
> Changes since v1:
> * put return type on the same line as "static" when breaking line
> * fix parameter alignment when adding "static"
> 
>  drivers/staging/crystalhd/crystalhd_lnx.c | 13 +++++++------
>  1 file changed, 7 insertions(+), 6 deletions(-)
> 
> diff --git a/drivers/staging/crystalhd/crystalhd_lnx.c b/drivers/staging/crystalhd/crystalhd_lnx.c
> index b17fbf8..a874a29 100644
> --- a/drivers/staging/crystalhd/crystalhd_lnx.c
> +++ b/drivers/staging/crystalhd/crystalhd_lnx.c
> @@ -75,8 +75,9 @@ static int chd_dec_disable_int(struct crystalhd_adp *adp)
>  	return 0;
>  }
>  
> -struct crystalhd_ioctl_data *chd_dec_alloc_iodata(struct crystalhd_adp *adp,
> -					 bool isr)
> +static struct
> +crystalhd_ioctl_data *chd_dec_alloc_iodata(struct crystalhd_adp *adp,
> +					   bool isr)
>  {
>  	unsigned long flags = 0;
>  	struct crystalhd_ioctl_data *temp;
> @@ -96,8 +97,8 @@ struct crystalhd_ioctl_data *chd_dec_alloc_iodata(struct crystalhd_adp *adp,
>  	return temp;
>  }
>  
> -void chd_dec_free_iodata(struct crystalhd_adp *adp,
> -			 struct crystalhd_ioctl_data *iodata, bool isr)
> +static void chd_dec_free_iodata(struct crystalhd_adp *adp,
> +				struct crystalhd_ioctl_data *iodata, bool isr)
>  {
>  	unsigned long flags = 0;
>  
> @@ -627,7 +628,7 @@ err:
>  }
>  
>  #ifdef CONFIG_PM
> -int chd_dec_pci_suspend(struct pci_dev *pdev, pm_message_t state)
> +static int chd_dec_pci_suspend(struct pci_dev *pdev, pm_message_t state)
>  {
>  	struct crystalhd_adp *adp;
>  	struct crystalhd_ioctl_data *temp;
> @@ -661,7 +662,7 @@ int chd_dec_pci_suspend(struct pci_dev *pdev, pm_message_t state)
>  	return 0;
>  }
>  
> -int chd_dec_pci_resume(struct pci_dev *pdev)
> +static int chd_dec_pci_resume(struct pci_dev *pdev)
>  {
>  	struct crystalhd_adp *adp;
>  	enum BC_STATUS sts = BC_STS_SUCCESS;
> -- 
> 1.8.1.2
> 
> -- 
> You received this message because you are subscribed to the Google Groups "opw-kernel" group.
> To unsubscribe from this group and stop receiving emails from it, send an email to opw-kernel+unsubscribe@googlegroups.com.
> For more options, visit https://groups.google.com/groups/opt_out.
Greg Kroah-Hartman Oct. 8, 2013, 1:40 a.m. UTC | #2
On Mon, Oct 07, 2013 at 11:12:14PM +0300, Valentina Manea wrote:
> This fixes the following sparse warnings:
> * drivers/staging/crystalhd/crystalhd_lnx.c:78:29: warning:
> symbol 'chd_dec_alloc_iodata' was not declared. Should it be static?
> * drivers/staging/crystalhd/crystalhd_lnx.c:99:6: warning:
> symbol 'chd_dec_free_iodata' was not declared. Should it be static?
> * drivers/staging/crystalhd/crystalhd_lnx.c:630:5: warning:
> symbol 'chd_dec_pci_suspend' was not declared. Should it be static?
> * drivers/staging/crystalhd/crystalhd_lnx.c:664:5: warning:
> symbol 'chd_dec_pci_resume' was not declared. Should it be static?
> 
> Signed-off-by: Valentina Manea <valentina.manea.m@gmail.com>

Thanks for revising this, nice job, it's now applied.

greg k-h

Patch
diff mbox

diff --git a/drivers/staging/crystalhd/crystalhd_lnx.c b/drivers/staging/crystalhd/crystalhd_lnx.c
index b17fbf8..a874a29 100644
--- a/drivers/staging/crystalhd/crystalhd_lnx.c
+++ b/drivers/staging/crystalhd/crystalhd_lnx.c
@@ -75,8 +75,9 @@  static int chd_dec_disable_int(struct crystalhd_adp *adp)
 	return 0;
 }
 
-struct crystalhd_ioctl_data *chd_dec_alloc_iodata(struct crystalhd_adp *adp,
-					 bool isr)
+static struct
+crystalhd_ioctl_data *chd_dec_alloc_iodata(struct crystalhd_adp *adp,
+					   bool isr)
 {
 	unsigned long flags = 0;
 	struct crystalhd_ioctl_data *temp;
@@ -96,8 +97,8 @@  struct crystalhd_ioctl_data *chd_dec_alloc_iodata(struct crystalhd_adp *adp,
 	return temp;
 }
 
-void chd_dec_free_iodata(struct crystalhd_adp *adp,
-			 struct crystalhd_ioctl_data *iodata, bool isr)
+static void chd_dec_free_iodata(struct crystalhd_adp *adp,
+				struct crystalhd_ioctl_data *iodata, bool isr)
 {
 	unsigned long flags = 0;
 
@@ -627,7 +628,7 @@  err:
 }
 
 #ifdef CONFIG_PM
-int chd_dec_pci_suspend(struct pci_dev *pdev, pm_message_t state)
+static int chd_dec_pci_suspend(struct pci_dev *pdev, pm_message_t state)
 {
 	struct crystalhd_adp *adp;
 	struct crystalhd_ioctl_data *temp;
@@ -661,7 +662,7 @@  int chd_dec_pci_suspend(struct pci_dev *pdev, pm_message_t state)
 	return 0;
 }
 
-int chd_dec_pci_resume(struct pci_dev *pdev)
+static int chd_dec_pci_resume(struct pci_dev *pdev)
 {
 	struct crystalhd_adp *adp;
 	enum BC_STATUS sts = BC_STS_SUCCESS;