[OPW,kernel] staging: gdm724x: Fix sparse warnings regarding static functions/variables
diff mbox

Message ID 1381227686-12467-1-git-send-email-valentina.manea.m@gmail.com
State Awaiting Upstream
Headers show

Commit Message

Valentina Manea Oct. 8, 2013, 10:21 a.m. UTC
This fixes sparse warnings for functions and variables, e.g.:
* drivers/staging/gdm724x/gdm_mux.c:29:25: warning: symbol
'mux_rx_wq' was not declared. Should it be static?

Signed-off-by: Valentina Manea <valentina.manea.m@gmail.com>
---
 drivers/staging/gdm724x/gdm_lte.c | 6 +++---
 drivers/staging/gdm724x/gdm_mux.c | 4 ++--
 2 files changed, 5 insertions(+), 5 deletions(-)

Comments

Valentina Manea Oct. 8, 2013, 8:12 p.m. UTC | #1
+ opw-kernel list

On Tue, Oct 8, 2013 at 8:37 PM, Zach Brown <zab@redhat.com> wrote:
> On Tue, Oct 08, 2013 at 01:21:26PM +0300, Valentina Manea wrote:
>> This fixes sparse warnings for functions and variables, e.g.:
>> * drivers/staging/gdm724x/gdm_mux.c:29:25: warning: symbol
>> 'mux_rx_wq' was not declared. Should it be static?
>>
>> Signed-off-by: Valentina Manea <valentina.manea.m@gmail.com>
>
> Reviewed-by: Zach Brown <zab@redhat.com>
Greg Kroah-Hartman Oct. 11, 2013, 8:12 p.m. UTC | #2
On Tue, Oct 08, 2013 at 01:21:26PM +0300, Valentina Manea wrote:
> This fixes sparse warnings for functions and variables, e.g.:
> * drivers/staging/gdm724x/gdm_mux.c:29:25: warning: symbol
> 'mux_rx_wq' was not declared. Should it be static?
> 
> Signed-off-by: Valentina Manea <valentina.manea.m@gmail.com>

Applied, thanks.

greg k-h

Patch
diff mbox

diff --git a/drivers/staging/gdm724x/gdm_lte.c b/drivers/staging/gdm724x/gdm_lte.c
index bc0d510..c57a6ba 100644
--- a/drivers/staging/gdm724x/gdm_lte.c
+++ b/drivers/staging/gdm724x/gdm_lte.c
@@ -110,7 +110,7 @@  static int gdm_lte_rx(struct sk_buff *skb, struct nic *nic, int nic_type)
 	return 0;
 }
 
-int gdm_lte_emulate_arp(struct sk_buff *skb_in, u32 nic_type)
+static int gdm_lte_emulate_arp(struct sk_buff *skb_in, u32 nic_type)
 {
 	struct nic *nic = netdev_priv(skb_in->dev);
 	struct sk_buff *skb_out;
@@ -186,7 +186,7 @@  int gdm_lte_emulate_arp(struct sk_buff *skb_in, u32 nic_type)
 	return 0;
 }
 
-int icmp6_checksum(struct ipv6hdr *ipv6, u16 *ptr, int len)
+static int icmp6_checksum(struct ipv6hdr *ipv6, u16 *ptr, int len)
 {
 	unsigned short *w = ptr;
 	int sum = 0;
@@ -226,7 +226,7 @@  int icmp6_checksum(struct ipv6hdr *ipv6, u16 *ptr, int len)
 	return sum;
 }
 
-int gdm_lte_emulate_ndp(struct sk_buff *skb_in, u32 nic_type)
+static int gdm_lte_emulate_ndp(struct sk_buff *skb_in, u32 nic_type)
 {
 	struct nic *nic = netdev_priv(skb_in->dev);
 	struct sk_buff *skb_out;
diff --git a/drivers/staging/gdm724x/gdm_mux.c b/drivers/staging/gdm724x/gdm_mux.c
index 5b1ef40..d63517c 100644
--- a/drivers/staging/gdm724x/gdm_mux.c
+++ b/drivers/staging/gdm724x/gdm_mux.c
@@ -26,7 +26,7 @@ 
 
 #include "gdm_mux.h"
 
-struct workqueue_struct *mux_rx_wq;
+static struct workqueue_struct *mux_rx_wq;
 
 static u16 packet_type[TTY_MAX_COUNT] = {0xF011, 0xF010};
 
@@ -51,7 +51,7 @@  static const struct usb_device_id id_table[] = {
 
 MODULE_DEVICE_TABLE(usb, id_table);
 
-int packet_type_to_index(u16 packetType)
+static int packet_type_to_index(u16 packetType)
 {
 	int i;