[OPW,kernel,3/4] Staging: btmtk_usb: Removal of Unnecessary white spaces
diff mbox

Message ID 464758126988af4d63921815aa945ac484c49f90.1381240946.git.rashika.kheria@gmail.com
State Accepted
Headers show

Commit Message

Rashika Oct. 8, 2013, 2:28 p.m. UTC
The patch fixes the following checkpatch.pl warning in btmtk_usb.c
WARNING: unnecessary whitespace before a quoted newline

Signed-off-by: Rashika Kheria <rashika.kheria@gmail.com>
---

This revision fixes the following issues from the previous revision-
Driver Name not mentioned in Subject

 drivers/staging/btmtk_usb/btmtk_usb.c |    6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

Comments

Zach Brown Oct. 8, 2013, 5:39 p.m. UTC | #1
On Tue, Oct 08, 2013 at 07:58:24PM +0530, Rashika Kheria wrote:
> The patch fixes the following checkpatch.pl warning in btmtk_usb.c
> WARNING: unnecessary whitespace before a quoted newline
> 
> Signed-off-by: Rashika Kheria <rashika.kheria@gmail.com>

Reviewed-by: Zach Brown <zab@redhat.com>
Josh Triplett Oct. 8, 2013, 7:25 p.m. UTC | #2
On Tue, Oct 08, 2013 at 07:58:24PM +0530, Rashika Kheria wrote:
> The patch fixes the following checkpatch.pl warning in btmtk_usb.c
> WARNING: unnecessary whitespace before a quoted newline
> 
> Signed-off-by: Rashika Kheria <rashika.kheria@gmail.com>

Reviewed-by: Josh Triplett <josh@joshtriplett.org>

> ---
> 
> This revision fixes the following issues from the previous revision-
> Driver Name not mentioned in Subject
> 
>  drivers/staging/btmtk_usb/btmtk_usb.c |    6 +++---
>  1 file changed, 3 insertions(+), 3 deletions(-)
> 
> diff --git a/drivers/staging/btmtk_usb/btmtk_usb.c b/drivers/staging/btmtk_usb/btmtk_usb.c
> index d8ede3a..5dd8744 100644
> --- a/drivers/staging/btmtk_usb/btmtk_usb.c
> +++ b/drivers/staging/btmtk_usb/btmtk_usb.c
> @@ -191,14 +191,14 @@ static void btmtk_usb_cap_init(struct btmtk_usb_data *data)
>  		ret = request_firmware(&firmware, MT7650_FIRMWARE, &udev->dev);
>  		if (ret < 0) {
>  			if (ret == -ENOENT) {
> -				BT_ERR("Firmware file \"%s\" not found \n",
> +				BT_ERR("Firmware file \"%s\" not found\n",
>  						MT7650_FIRMWARE);
>  			} else {
> -				BT_ERR("Firmware file \"%s\" request failed (err=%d) \n",
> +				BT_ERR("Firmware file \"%s\" request failed (err=%d)\n",
>  					MT7650_FIRMWARE, ret);
>  			}
>  		} else {
> -			BT_DBG("Firmware file \"%s\" Found \n",
> +			BT_DBG("Firmware file \"%s\" Found\n",
>  					MT7650_FIRMWARE);
>  			/* load firmware here */
>  			data->firmware = firmware;
> -- 
> 1.7.9.5
> 
> -- 
> You received this message because you are subscribed to the Google Groups "opw-kernel" group.
> To unsubscribe from this group and stop receiving emails from it, send an email to opw-kernel+unsubscribe@googlegroups.com.
> For more options, visit https://groups.google.com/groups/opt_out.
Sarah Sharp Oct. 8, 2013, 8:05 p.m. UTC | #3
This patch was already applied by Greg, according to patchwork:

https://patchwork.kernel.org/patch/2996291/

Can you please rebase your patches against the staging-next tree, and
resend this numbered patchset?

Thanks,
Sarah Sharp

On Tue, Oct 08, 2013 at 07:58:24PM +0530, Rashika Kheria wrote:
> The patch fixes the following checkpatch.pl warning in btmtk_usb.c
> WARNING: unnecessary whitespace before a quoted newline
> 
> Signed-off-by: Rashika Kheria <rashika.kheria@gmail.com>
> ---
> 
> This revision fixes the following issues from the previous revision-
> Driver Name not mentioned in Subject
> 
>  drivers/staging/btmtk_usb/btmtk_usb.c |    6 +++---
>  1 file changed, 3 insertions(+), 3 deletions(-)
> 
> diff --git a/drivers/staging/btmtk_usb/btmtk_usb.c b/drivers/staging/btmtk_usb/btmtk_usb.c
> index d8ede3a..5dd8744 100644
> --- a/drivers/staging/btmtk_usb/btmtk_usb.c
> +++ b/drivers/staging/btmtk_usb/btmtk_usb.c
> @@ -191,14 +191,14 @@ static void btmtk_usb_cap_init(struct btmtk_usb_data *data)
>  		ret = request_firmware(&firmware, MT7650_FIRMWARE, &udev->dev);
>  		if (ret < 0) {
>  			if (ret == -ENOENT) {
> -				BT_ERR("Firmware file \"%s\" not found \n",
> +				BT_ERR("Firmware file \"%s\" not found\n",
>  						MT7650_FIRMWARE);
>  			} else {
> -				BT_ERR("Firmware file \"%s\" request failed (err=%d) \n",
> +				BT_ERR("Firmware file \"%s\" request failed (err=%d)\n",
>  					MT7650_FIRMWARE, ret);
>  			}
>  		} else {
> -			BT_DBG("Firmware file \"%s\" Found \n",
> +			BT_DBG("Firmware file \"%s\" Found\n",
>  					MT7650_FIRMWARE);
>  			/* load firmware here */
>  			data->firmware = firmware;
> -- 
> 1.7.9.5
> 
> -- 
> You received this message because you are subscribed to the Google Groups "opw-kernel" group.
> To unsubscribe from this group and stop receiving emails from it, send an email to opw-kernel+unsubscribe@googlegroups.com.
> For more options, visit https://groups.google.com/groups/opt_out.
Sarah Sharp Oct. 8, 2013, 9:51 p.m. UTC | #4
On Tue, Oct 08, 2013 at 01:05:15PM -0700, Sarah Sharp wrote:
> This patch was already applied by Greg, according to patchwork:
> 
> https://patchwork.kernel.org/patch/2996291/
> 
> Can you please rebase your patches against the staging-next tree, and
> resend this numbered patchset?

Greg,

You said you accepted this patch, but when Rashika rebased her tree
against staging-next, it wasn't there.  I've double-checked your tree,
and you don't have any patches applied from Rashika.

Can you please try to apply these four patches?  If they don't apply,
let Rashika know, and she'll send you the rebased patches as a version 2
patchset.

Sarah Sharp

> On Tue, Oct 08, 2013 at 07:58:24PM +0530, Rashika Kheria wrote:
> > The patch fixes the following checkpatch.pl warning in btmtk_usb.c
> > WARNING: unnecessary whitespace before a quoted newline
> > 
> > Signed-off-by: Rashika Kheria <rashika.kheria@gmail.com>
> > ---
> > 
> > This revision fixes the following issues from the previous revision-
> > Driver Name not mentioned in Subject
> > 
> >  drivers/staging/btmtk_usb/btmtk_usb.c |    6 +++---
> >  1 file changed, 3 insertions(+), 3 deletions(-)
> > 
> > diff --git a/drivers/staging/btmtk_usb/btmtk_usb.c b/drivers/staging/btmtk_usb/btmtk_usb.c
> > index d8ede3a..5dd8744 100644
> > --- a/drivers/staging/btmtk_usb/btmtk_usb.c
> > +++ b/drivers/staging/btmtk_usb/btmtk_usb.c
> > @@ -191,14 +191,14 @@ static void btmtk_usb_cap_init(struct btmtk_usb_data *data)
> >  		ret = request_firmware(&firmware, MT7650_FIRMWARE, &udev->dev);
> >  		if (ret < 0) {
> >  			if (ret == -ENOENT) {
> > -				BT_ERR("Firmware file \"%s\" not found \n",
> > +				BT_ERR("Firmware file \"%s\" not found\n",
> >  						MT7650_FIRMWARE);
> >  			} else {
> > -				BT_ERR("Firmware file \"%s\" request failed (err=%d) \n",
> > +				BT_ERR("Firmware file \"%s\" request failed (err=%d)\n",
> >  					MT7650_FIRMWARE, ret);
> >  			}
> >  		} else {
> > -			BT_DBG("Firmware file \"%s\" Found \n",
> > +			BT_DBG("Firmware file \"%s\" Found\n",
> >  					MT7650_FIRMWARE);
> >  			/* load firmware here */
> >  			data->firmware = firmware;
> > -- 
> > 1.7.9.5
> > 
> > -- 
> > You received this message because you are subscribed to the Google Groups "opw-kernel" group.
> > To unsubscribe from this group and stop receiving emails from it, send an email to opw-kernel+unsubscribe@googlegroups.com.
> > For more options, visit https://groups.google.com/groups/opt_out.
> 
> -- 
> You received this message because you are subscribed to the Google Groups "opw-kernel" group.
> To unsubscribe from this group and stop receiving emails from it, send an email to opw-kernel+unsubscribe@googlegroups.com.
> For more options, visit https://groups.google.com/groups/opt_out.
Greg KH Oct. 8, 2013, 10:06 p.m. UTC | #5
On Tue, Oct 08, 2013 at 02:51:41PM -0700, Sarah Sharp wrote:
> On Tue, Oct 08, 2013 at 01:05:15PM -0700, Sarah Sharp wrote:
> > This patch was already applied by Greg, according to patchwork:
> > 
> > https://patchwork.kernel.org/patch/2996291/
> > 
> > Can you please rebase your patches against the staging-next tree, and
> > resend this numbered patchset?
> 
> Greg,
> 
> You said you accepted this patch,

I did?  Where did I say that?  I don't see that in the above patchwork
link, or in my local email archives.

Ah, I said "I think I picked the right one", and then later, in reply to
the one I picked, I said it couldn't be applied.  Sorry for the
confusion.

> but when Rashika rebased her tree
> against staging-next, it wasn't there.  I've double-checked your tree,
> and you don't have any patches applied from Rashika.
> 
> Can you please try to apply these four patches?  If they don't apply,
> let Rashika know, and she'll send you the rebased patches as a version 2
> patchset.

I have 4 patches from Rashika in my "todo" queue, and I'll get to them
somewhere over the Pacific ocean later today.  If they apply or not, I
will let everyone know.

thanks,

greg k-h
Greg KH Oct. 11, 2013, 8:19 p.m. UTC | #6
On Tue, Oct 08, 2013 at 07:58:24PM +0530, Rashika Kheria wrote:
> The patch fixes the following checkpatch.pl warning in btmtk_usb.c
> WARNING: unnecessary whitespace before a quoted newline
> 
> Signed-off-by: Rashika Kheria <rashika.kheria@gmail.com>

Applied, thanks.

greg k-h

Patch
diff mbox

diff --git a/drivers/staging/btmtk_usb/btmtk_usb.c b/drivers/staging/btmtk_usb/btmtk_usb.c
index d8ede3a..5dd8744 100644
--- a/drivers/staging/btmtk_usb/btmtk_usb.c
+++ b/drivers/staging/btmtk_usb/btmtk_usb.c
@@ -191,14 +191,14 @@  static void btmtk_usb_cap_init(struct btmtk_usb_data *data)
 		ret = request_firmware(&firmware, MT7650_FIRMWARE, &udev->dev);
 		if (ret < 0) {
 			if (ret == -ENOENT) {
-				BT_ERR("Firmware file \"%s\" not found \n",
+				BT_ERR("Firmware file \"%s\" not found\n",
 						MT7650_FIRMWARE);
 			} else {
-				BT_ERR("Firmware file \"%s\" request failed (err=%d) \n",
+				BT_ERR("Firmware file \"%s\" request failed (err=%d)\n",
 					MT7650_FIRMWARE, ret);
 			}
 		} else {
-			BT_DBG("Firmware file \"%s\" Found \n",
+			BT_DBG("Firmware file \"%s\" Found\n",
 					MT7650_FIRMWARE);
 			/* load firmware here */
 			data->firmware = firmware;