[OPW,kernel,v2,1/1] Staging: tidspbridge: fix quoted string split across lines
diff mbox

Message ID 1381245850-4784-1-git-send-email-ebru.akagunduz@gmail.com
State Rejected
Headers show

Commit Message

Ebru Akagündüz Oct. 8, 2013, 3:24 p.m. UTC
Fix checkpatch.pl issues  quoted string split across lines in mgr.c

Signed-off-by: Ebru Akagunduz <ebru.akagunduz@gmail.com>
---
 drivers/staging/tidspbridge/rmgr/mgr.c | 9 ++++-----
 1 file changed, 4 insertions(+), 5 deletions(-)

Comments

Zach Brown Oct. 8, 2013, 5:36 p.m. UTC | #1
On Tue, Oct 08, 2013 at 06:24:10PM +0300, Ebru Akagunduz wrote:
> Fix checkpatch.pl issues  quoted string split across lines in mgr.c
> 
> Signed-off-by: Ebru Akagunduz <ebru.akagunduz@gmail.com>

Reviewed-by: Zach Brown <zab@redhat.com>
Josh Triplett Oct. 8, 2013, 7:27 p.m. UTC | #2
On Tue, Oct 08, 2013 at 06:24:10PM +0300, Ebru Akagunduz wrote:
> Fix checkpatch.pl issues  quoted string split across lines in mgr.c
> 
> Signed-off-by: Ebru Akagunduz <ebru.akagunduz@gmail.com>

These warnings are actually both false positives.  The strings aren't
split across lines, they're just not on the same line as the "dev_dbg(".

- Josh Triplett

> ---
>  drivers/staging/tidspbridge/rmgr/mgr.c | 9 ++++-----
>  1 file changed, 4 insertions(+), 5 deletions(-)
> 
> diff --git a/drivers/staging/tidspbridge/rmgr/mgr.c b/drivers/staging/tidspbridge/rmgr/mgr.c
> index 158a17c..6f8d629 100644
> --- a/drivers/staging/tidspbridge/rmgr/mgr.c
> +++ b/drivers/staging/tidspbridge/rmgr/mgr.c
> @@ -266,16 +266,15 @@ int mgr_enum_processor_info(u32 processor_id,
>  			 * this is a clumsy overwrite */
>  			processor_info->processor_type = DSPTYPE64;
>  		} else {
> -			dev_dbg(bridge,
> -				"%s: Failed to get DCD processor info %x\n", __func__,
> -				status2);
> +			dev_dbg(bridge, "%s: Failed to get DCD processor info %x\n",
> +				__func__, status2);
>  			status = -EPERM;
>  		}
>  	}
>  	*pu_num_procs = proc_index;
>  	if (proc_detect == false) {
> -		dev_dbg(bridge,
> -			"%s: Failed to get proc info from DCD, so use CFG registry\n", __func__);
> +		dev_dbg(bridge, "%s: Failed to get proc info from DCD, so use CFG registry\n",
> +			__func__);
>  		processor_info->processor_type = DSPTYPE64;
>  	}
>  func_end:
> -- 
> 1.8.1.2
> 
> -- 
> You received this message because you are subscribed to the Google Groups "opw-kernel" group.
> To unsubscribe from this group and stop receiving emails from it, send an email to opw-kernel+unsubscribe@googlegroups.com.
> For more options, visit https://groups.google.com/groups/opt_out.

Patch
diff mbox

diff --git a/drivers/staging/tidspbridge/rmgr/mgr.c b/drivers/staging/tidspbridge/rmgr/mgr.c
index 158a17c..6f8d629 100644
--- a/drivers/staging/tidspbridge/rmgr/mgr.c
+++ b/drivers/staging/tidspbridge/rmgr/mgr.c
@@ -266,16 +266,15 @@  int mgr_enum_processor_info(u32 processor_id,
 			 * this is a clumsy overwrite */
 			processor_info->processor_type = DSPTYPE64;
 		} else {
-			dev_dbg(bridge,
-				"%s: Failed to get DCD processor info %x\n", __func__,
-				status2);
+			dev_dbg(bridge, "%s: Failed to get DCD processor info %x\n",
+				__func__, status2);
 			status = -EPERM;
 		}
 	}
 	*pu_num_procs = proc_index;
 	if (proc_detect == false) {
-		dev_dbg(bridge,
-			"%s: Failed to get proc info from DCD, so use CFG registry\n", __func__);
+		dev_dbg(bridge, "%s: Failed to get proc info from DCD, so use CFG registry\n",
+			__func__);
 		processor_info->processor_type = DSPTYPE64;
 	}
 func_end: