[OPW,kernel,v2] Staging: wlan-ng: fix printk(KERN_DEBUG in p80211wep.c
diff mbox

Message ID 1381247500-5325-1-git-send-email-ebru.akagunduz@gmail.com
State Accepted
Headers show

Commit Message

Ebru Akagündüz Oct. 8, 2013, 3:51 p.m. UTC
Fix checkpatch.pl issues with prefer netdev_dbg(netdev, .. then
dev_dbg(dev, .. then pr_debug(.. to printk(KERN_DEBUG in p80211wep.c

Signed-off-by: Ebru Akagunduz <ebru.akagunduz@gmail.com>
---
 drivers/staging/wlan-ng/p80211wep.c | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

Comments

Sarah Sharp Oct. 8, 2013, 6:25 p.m. UTC | #1
On Tue, Oct 08, 2013 at 06:51:40PM +0300, Ebru Akagunduz wrote:
> Fix checkpatch.pl issues with prefer netdev_dbg(netdev, .. then
> dev_dbg(dev, .. then pr_debug(.. to printk(KERN_DEBUG in p80211wep.c
> 
> Signed-off-by: Ebru Akagunduz <ebru.akagunduz@gmail.com>
> ---
>  drivers/staging/wlan-ng/p80211wep.c | 6 +++---
>  1 file changed, 3 insertions(+), 3 deletions(-)
> 
> diff --git a/drivers/staging/wlan-ng/p80211wep.c b/drivers/staging/wlan-ng/p80211wep.c
> index 77e50a4..c4fabad 100644
> --- a/drivers/staging/wlan-ng/p80211wep.c
> +++ b/drivers/staging/wlan-ng/p80211wep.c

Hi Ebru,

This looks much improved.  One note for your future patches: you don't
need to put the file name in the subject line.  Putting the driver name
is enough, because people can see from the diff stats which files you
modified.

Sarah Sharp
Ebru Akagündüz Oct. 8, 2013, 6:52 p.m. UTC | #2
Hi

> Hi Ebru,
>
> This looks much improved.  One note for your future patches: you don't
> need to put the file name in the subject line.  Putting the driver name
> is enough, because people can see from the diff stats which files you
> modified.
>
> Sarah Sharp
>

Greg said, actual file name specification in subject line, it can be
better. So  I added file name.
Josh Triplett Oct. 8, 2013, 7:28 p.m. UTC | #3
On Tue, Oct 08, 2013 at 06:51:40PM +0300, Ebru Akagunduz wrote:
> Fix checkpatch.pl issues with prefer netdev_dbg(netdev, .. then
> dev_dbg(dev, .. then pr_debug(.. to printk(KERN_DEBUG in p80211wep.c
> 
> Signed-off-by: Ebru Akagunduz <ebru.akagunduz@gmail.com>

Reviewed-by: Josh Triplett <josh@joshtriplett.org>

> ---
>  drivers/staging/wlan-ng/p80211wep.c | 6 +++---
>  1 file changed, 3 insertions(+), 3 deletions(-)
> 
> diff --git a/drivers/staging/wlan-ng/p80211wep.c b/drivers/staging/wlan-ng/p80211wep.c
> index 77e50a4..c4fabad 100644
> --- a/drivers/staging/wlan-ng/p80211wep.c
> +++ b/drivers/staging/wlan-ng/p80211wep.c
> @@ -134,7 +134,7 @@ int wep_change_key(wlandevice_t *wlandev, int keynum, u8 *key, int keylen)
>  		return -1;
>  
>  #ifdef WEP_DEBUG
> -	printk(KERN_DEBUG "WEP key %d len %d = %*phC\n", keynum, keylen,
> +	pr_debug("WEP key %d len %d = %*phC\n", keynum, keylen,
>  			  8, key);
>  #endif
>  
> @@ -182,7 +182,7 @@ int wep_decrypt(wlandevice_t *wlandev, u8 *buf, u32 len, int key_override,
>  	keylen += 3;		/* add in IV bytes */
>  
>  #ifdef WEP_DEBUG
> -	printk(KERN_DEBUG "D %d: %*ph (%d %d) %*phC\n", len, 3, key,
> +	pr_debug("D %d: %*ph (%d %d) %*phC\n", len, 3, key,
>  			  keyidx, keylen, 5, key + 3);
>  #endif
>  
> @@ -259,7 +259,7 @@ int wep_encrypt(wlandevice_t *wlandev, u8 *buf, u8 *dst, u32 len, int keynum,
>  	keylen += 3;		/* add in IV bytes */
>  
>  #ifdef WEP_DEBUG
> -	printk(KERN_DEBUG "E %d (%d/%d %d) %*ph %*phC\n", len,
> +	pr_debug("E %d (%d/%d %d) %*ph %*phC\n", len,
>  			  iv[3], keynum, keylen, 3, key, 5, key + 3);
>  #endif
>  
> -- 
> 1.8.1.2
> 
> -- 
> You received this message because you are subscribed to the Google Groups "opw-kernel" group.
> To unsubscribe from this group and stop receiving emails from it, send an email to opw-kernel+unsubscribe@googlegroups.com.
> For more options, visit https://groups.google.com/groups/opt_out.
Greg Kroah-Hartman Oct. 11, 2013, 8:24 p.m. UTC | #4
On Tue, Oct 08, 2013 at 11:25:49AM -0700, Sarah Sharp wrote:
> On Tue, Oct 08, 2013 at 06:51:40PM +0300, Ebru Akagunduz wrote:
> > Fix checkpatch.pl issues with prefer netdev_dbg(netdev, .. then
> > dev_dbg(dev, .. then pr_debug(.. to printk(KERN_DEBUG in p80211wep.c
> > 
> > Signed-off-by: Ebru Akagunduz <ebru.akagunduz@gmail.com>
> > ---
> >  drivers/staging/wlan-ng/p80211wep.c | 6 +++---
> >  1 file changed, 3 insertions(+), 3 deletions(-)
> > 
> > diff --git a/drivers/staging/wlan-ng/p80211wep.c b/drivers/staging/wlan-ng/p80211wep.c
> > index 77e50a4..c4fabad 100644
> > --- a/drivers/staging/wlan-ng/p80211wep.c
> > +++ b/drivers/staging/wlan-ng/p80211wep.c
> 
> Hi Ebru,
> 
> This looks much improved.  One note for your future patches: you don't
> need to put the file name in the subject line.  Putting the driver name
> is enough, because people can see from the diff stats which files you
> modified.

File name is usually the driver name, but even if not, it's good to have
it, especially when you have a bunch of individual patches that all do
the same thing, to the same driver, yet to different files.

thanks,

greg k-h
Greg KH Oct. 11, 2013, 8:27 p.m. UTC | #5
On Tue, Oct 08, 2013 at 06:51:40PM +0300, Ebru Akagunduz wrote:
> Fix checkpatch.pl issues with prefer netdev_dbg(netdev, .. then
> dev_dbg(dev, .. then pr_debug(.. to printk(KERN_DEBUG in p80211wep.c
> 
> Signed-off-by: Ebru Akagunduz <ebru.akagunduz@gmail.com>

Applied, thanks.

greg k-h

Patch
diff mbox

diff --git a/drivers/staging/wlan-ng/p80211wep.c b/drivers/staging/wlan-ng/p80211wep.c
index 77e50a4..c4fabad 100644
--- a/drivers/staging/wlan-ng/p80211wep.c
+++ b/drivers/staging/wlan-ng/p80211wep.c
@@ -134,7 +134,7 @@  int wep_change_key(wlandevice_t *wlandev, int keynum, u8 *key, int keylen)
 		return -1;
 
 #ifdef WEP_DEBUG
-	printk(KERN_DEBUG "WEP key %d len %d = %*phC\n", keynum, keylen,
+	pr_debug("WEP key %d len %d = %*phC\n", keynum, keylen,
 			  8, key);
 #endif
 
@@ -182,7 +182,7 @@  int wep_decrypt(wlandevice_t *wlandev, u8 *buf, u32 len, int key_override,
 	keylen += 3;		/* add in IV bytes */
 
 #ifdef WEP_DEBUG
-	printk(KERN_DEBUG "D %d: %*ph (%d %d) %*phC\n", len, 3, key,
+	pr_debug("D %d: %*ph (%d %d) %*phC\n", len, 3, key,
 			  keyidx, keylen, 5, key + 3);
 #endif
 
@@ -259,7 +259,7 @@  int wep_encrypt(wlandevice_t *wlandev, u8 *buf, u8 *dst, u32 len, int keynum,
 	keylen += 3;		/* add in IV bytes */
 
 #ifdef WEP_DEBUG
-	printk(KERN_DEBUG "E %d (%d/%d %d) %*ph %*phC\n", len,
+	pr_debug("E %d (%d/%d %d) %*ph %*phC\n", len,
 			  iv[3], keynum, keylen, 3, key, 5, key + 3);
 #endif