[OPW,kernel] staging:media:lirc: quoted string split across lines
diff mbox

Message ID 1381311545-2810-1-git-send-email-archanakumari959@gmail.com
State Changes Requested
Headers show

Commit Message

Archana kumari Oct. 9, 2013, 9:39 a.m. UTC
Fix checkpatch.pl issues with quoted string split across lines in lirc_imon.c

Signed-off-by: Archana kumari <archanakumari959@gmail.com>
---
---
 drivers/staging/media/lirc/lirc_imon.c | 21 ++++++++++++---------
 1 file changed, 12 insertions(+), 9 deletions(-)

Comments

Greg Kroah-Hartman Oct. 11, 2013, 8:41 p.m. UTC | #1
On Wed, Oct 09, 2013 at 03:09:05PM +0530, Archana kumari wrote:
> Fix checkpatch.pl issues with quoted string split across lines in lirc_imon.c
> 
> Signed-off-by: Archana kumari <archanakumari959@gmail.com>

You sent two versions of this patch, without an indication as to which
one I should accept, or the difference between them, making me confused
:(

So, I've dropped them both, can you please resend the version you wish
to have me review and apply?

In the future, please use the "v2" and the like to show which version of
a patch is the latest.

thanks,

greg k-h

Patch
diff mbox

diff --git a/drivers/staging/media/lirc/lirc_imon.c b/drivers/staging/media/lirc/lirc_imon.c
index 4afa7da..8180187 100644
--- a/drivers/staging/media/lirc/lirc_imon.c
+++ b/drivers/staging/media/lirc/lirc_imon.c
@@ -619,8 +619,9 @@  static void imon_incoming_packet(struct imon_context *context,
 		return;
 
 	if (len != 8) {
-		dev_warn(dev, "imon %s: invalid incoming packet "
-			 "size (len = %d, intf%d)\n", __func__, len, intf);
+		dev_warn(dev,
+		 "imon %s: invalid incoming packet size (len = %d, intf%d)\n",
+				__func__, len, intf);
 		return;
 	}
 
@@ -878,8 +879,8 @@  static int imon_probe(struct usb_interface *interface,
 		alloc_status = 7;
 		goto unlock;
 	} else
-		dev_info(dev, "Registered iMON driver "
-			 "(lirc minor: %d)\n", lirc_minor);
+		dev_info(dev, "Registered iMON driver (lirc minor: %d)\n",
+				lirc_minor);
 
 	/* Needed while unregistering! */
 	driver->minor = lirc_minor;
@@ -923,14 +924,16 @@  static int imon_probe(struct usb_interface *interface,
 
 		if (usb_register_dev(interface, &imon_class)) {
 			/* Not a fatal error, so ignore */
-			dev_info(dev, "%s: could not get a minor number for "
-				 "display\n", __func__);
+			dev_info(dev,
+			       "%s: could not get a minor number for display\n"
+						__func__);
 		}
 	}
 
-	dev_info(dev, "iMON device (%04x:%04x, intf%d) on "
-		 "usb<%d:%d> initialized\n", vendor, product, ifnum,
-		 usbdev->bus->busnum, usbdev->devnum);
+	dev_info(dev,
+		"iMON device (%04x:%04x, intf%d) on usb<%d:%d> initialized\n",
+			vendor, product, ifnum, usbdev->bus->busnum,
+					usbdev->devnum);
 
 unlock:
 	mutex_unlock(&context->ctx_lock);