[OPW,kernel,2/2] staging: octeon: Removed space at start of line
diff mbox

Message ID 1381675790-7103-2-git-send-email-nandu.hgowda@gmail.com
State Accepted
Headers show

Commit Message

nandini h Oct. 13, 2013, 2:49 p.m. UTC
Removed unnecessary space at start of line
to fix checkpatch.pl warning.

Signed-off-by: Nandini Hanumanthagowda <nandu.hgowda@gmail.com>
---
 drivers/staging/octeon/ethernet.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Greg KH Oct. 14, 2013, 4:12 p.m. UTC | #1
Where is patch [1/2] in this series, I only see this second one.

On Sun, Oct 13, 2013 at 08:19:50PM +0530, Nandini Hanumanthagowda wrote:
> Removed unnecessary space at start of line
> to fix checkpatch.pl warning.
> 
> Signed-off-by: Nandini Hanumanthagowda <nandu.hgowda@gmail.com>
> ---
>  drivers/staging/octeon/ethernet.c |    2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/staging/octeon/ethernet.c b/drivers/staging/octeon/ethernet.c
> index 8680d70..8aba66e 100644
> --- a/drivers/staging/octeon/ethernet.c
> +++ b/drivers/staging/octeon/ethernet.c
> @@ -169,7 +169,7 @@ static void cvm_oct_periodic_worker(struct work_struct *work)
>  	if (!atomic_read(&cvm_oct_poll_queue_stopping))
>  		queue_delayed_work(cvm_oct_poll_queue,
>  						&priv->port_periodic_work, HZ);
> - }
> +}

This looks fine, and I'll take it as-is, but make sure that the 1/2
patch got sent out properly, as I don't see it anywhere.

thanks,

greg k-h
Greg Kroah-Hartman Oct. 14, 2013, 4:15 p.m. UTC | #2
On Sun, Oct 13, 2013 at 08:19:50PM +0530, Nandini Hanumanthagowda wrote:
> Removed unnecessary space at start of line
> to fix checkpatch.pl warning.
> 
> Signed-off-by: Nandini Hanumanthagowda <nandu.hgowda@gmail.com>
> ---
>  drivers/staging/octeon/ethernet.c |    2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/staging/octeon/ethernet.c b/drivers/staging/octeon/ethernet.c
> index 8680d70..8aba66e 100644
> --- a/drivers/staging/octeon/ethernet.c
> +++ b/drivers/staging/octeon/ethernet.c
> @@ -169,7 +169,7 @@ static void cvm_oct_periodic_worker(struct work_struct *work)
>  	if (!atomic_read(&cvm_oct_poll_queue_stopping))
>  		queue_delayed_work(cvm_oct_poll_queue,
>  						&priv->port_periodic_work, HZ);
> - }
> +}

This patch doesn't apply at all, maybe you made it against an older
kernel tree?

sorry, I can't take it.

greg k-h
Greg KH Oct. 14, 2013, 4:30 p.m. UTC | #3
On Mon, Oct 14, 2013 at 09:12:45AM -0700, Greg KH wrote:
> Where is patch [1/2] in this series, I only see this second one.

Ugh, sorry, I found it now, nevermind, too many patches, sorry, my
fault...

greg k-h
Greg Kroah-Hartman Oct. 14, 2013, 4:32 p.m. UTC | #4
On Sun, Oct 13, 2013 at 08:19:50PM +0530, Nandini Hanumanthagowda wrote:
> Removed unnecessary space at start of line
> to fix checkpatch.pl warning.
> 
> Signed-off-by: Nandini Hanumanthagowda <nandu.hgowda@gmail.com>

Applied, thanks.

greg k-h

Patch
diff mbox

diff --git a/drivers/staging/octeon/ethernet.c b/drivers/staging/octeon/ethernet.c
index 8680d70..8aba66e 100644
--- a/drivers/staging/octeon/ethernet.c
+++ b/drivers/staging/octeon/ethernet.c
@@ -169,7 +169,7 @@  static void cvm_oct_periodic_worker(struct work_struct *work)
 	if (!atomic_read(&cvm_oct_poll_queue_stopping))
 		queue_delayed_work(cvm_oct_poll_queue,
 						&priv->port_periodic_work, HZ);
- }
+}
 
 static void cvm_oct_configure_common_hw(void)
 {