[OPW,kernel] : staging android: binder.c - fix line length
diff mbox

Message ID 20131015013752.GA18973@daenerys
State Changes Requested
Headers show

Commit Message

Melita Mihaljevic Oct. 15, 2013, 1:37 a.m. UTC
Coding style requires that lines should not be over 80 characters.
Split line to follow coding style

Signed-off-by: Melita Mihaljevic <melita.mihaljevic@gmail.com>
---
 drivers/staging/android/binder.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

Comments

Greg Kroah-Hartman Oct. 15, 2013, 4 p.m. UTC | #1
On Mon, Oct 14, 2013 at 06:37:52PM -0700, Melita Mihaljevic wrote:
> Coding style requires that lines should not be over 80 characters.
> Split line to follow coding style
> 
> Signed-off-by: Melita Mihaljevic <melita.mihaljevic@gmail.com>

You sent 8 different emails with patches for this file, most with
different subjects, some with different patches, some with the same one.

All of which is totally confusing, what am I supposed to review and
potentially apply?

As I don't know which patch is in which order, or even which one I
should be looking at, I'm just deleting all of them from my inbox.

Remember "kernel maintainer == brain of a squirrel", you have to be
explicit to us, as we retain no context and get easily confused.

Please resend the patches you want us to review, and apply, in the order
in which they should be applied, all with a correct subject: line.

greg k-h
Melita Mihaljevic Oct. 15, 2013, 4:13 p.m. UTC | #2
Hi Greg,
Thank you for your comments, I will fix that and resend.

Best,
Melita


On Tue, Oct 15, 2013 at 9:00 AM, Greg KH <gregkh@linuxfoundation.org> wrote:

> On Mon, Oct 14, 2013 at 06:37:52PM -0700, Melita Mihaljevic wrote:
> > Coding style requires that lines should not be over 80 characters.
> > Split line to follow coding style
> >
> > Signed-off-by: Melita Mihaljevic <melita.mihaljevic@gmail.com>
>
> You sent 8 different emails with patches for this file, most with
> different subjects, some with different patches, some with the same one.
>
> All of which is totally confusing, what am I supposed to review and
> potentially apply?
>
> As I don't know which patch is in which order, or even which one I
> should be looking at, I'm just deleting all of them from my inbox.
>
> Remember "kernel maintainer == brain of a squirrel", you have to be
> explicit to us, as we retain no context and get easily confused.
>
> Please resend the patches you want us to review, and apply, in the order
> in which they should be applied, all with a correct subject: line.
>
> greg k-h
>

Patch
diff mbox

diff --git a/drivers/staging/android/binder.c b/drivers/staging/android/binder.c
index de25478..c1c8083 100644
--- a/drivers/staging/android/binder.c
+++ b/drivers/staging/android/binder.c
@@ -1269,7 +1269,8 @@  static void binder_transaction_buffer_release(struct binder_proc *proc,
 			binder_debug(BINDER_DEBUG_TRANSACTION,
 				     "        node %d u%p\n",
 				     node->debug_id, node->ptr);
-			binder_dec_node(node, fp->type == BINDER_TYPE_BINDER, 0);
+			binder_dec_node(node,
+					fp->type == BINDER_TYPE_BINDER, 0);
 		} break;
 		case BINDER_TYPE_HANDLE:
 		case BINDER_TYPE_WEAK_HANDLE: {