[OPW,kernel] staging: keucr Fix warning: "do {} while (0) macros should not be semicolon terminated" in scsiglue.c
diff mbox

Message ID 20131015021918.GA19682@daenerys
State Rejected
Headers show

Commit Message

Melita Mihaljevic Oct. 15, 2013, 2:19 a.m. UTC
Fix warning: "do {} while (0) macros should not be semicolon terminated" in scsiglue.c
found with checkpatch.pl

Signed-off-by: Melita Mihaljevic <melita.mihaljevic@gmail.com>
---
 drivers/staging/keucr/scsiglue.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Josh Triplett Oct. 15, 2013, 5:33 a.m. UTC | #1
On Mon, Oct 14, 2013 at 07:19:18PM -0700, Melita Mihaljevic wrote:
> Fix warning: "do {} while (0) macros should not be semicolon terminated" in scsiglue.c
> found with checkpatch.pl
> 
> Signed-off-by: Melita Mihaljevic <melita.mihaljevic@gmail.com>

Reviewed-by: Josh Triplett <josh@joshtriplett.org>

> ---
>  drivers/staging/keucr/scsiglue.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/staging/keucr/scsiglue.c b/drivers/staging/keucr/scsiglue.c
> index ac3d34d..fce19a4 100644
> --- a/drivers/staging/keucr/scsiglue.c
> +++ b/drivers/staging/keucr/scsiglue.c
> @@ -277,7 +277,7 @@ static int show_info(struct seq_file *m, struct Scsi_Host *host)
>  	do { \
>  		if (us->fflags & value) \
>  			SPRINTF(" " #name); \
> -	} while (0);
> +	} while (0)
>  US_DO_ALL_FLAGS
>  #undef US_FLAG
>  	seq_putc(m, '\n');
> -- 
> 1.8.4.rc3
> 
> -- 
> You received this message because you are subscribed to the Google Groups "opw-kernel" group.
> To unsubscribe from this group and stop receiving emails from it, send an email to opw-kernel+unsubscribe@googlegroups.com.
> For more options, visit https://groups.google.com/groups/opt_out.
Greg Kroah-Hartman Oct. 15, 2013, 4:06 p.m. UTC | #2
On Mon, Oct 14, 2013 at 07:19:18PM -0700, Melita Mihaljevic wrote:
> Fix warning: "do {} while (0) macros should not be semicolon terminated"
> in scsiglue.c
> 
> found with checkpatch.pl

You failed to build the driver with this patch applied :(

This patch breaks the build, which isn't ok, sorry, I can't take it.
Please fix this up and resend.

ALWAYS test build your patches, it's the only requirement for testing,
please don't skip it.

greg k-h

Patch
diff mbox

diff --git a/drivers/staging/keucr/scsiglue.c b/drivers/staging/keucr/scsiglue.c
index ac3d34d..fce19a4 100644
--- a/drivers/staging/keucr/scsiglue.c
+++ b/drivers/staging/keucr/scsiglue.c
@@ -277,7 +277,7 @@  static int show_info(struct seq_file *m, struct Scsi_Host *host)
 	do { \
 		if (us->fflags & value) \
 			SPRINTF(" " #name); \
-	} while (0);
+	} while (0)
 US_DO_ALL_FLAGS
 #undef US_FLAG
 	seq_putc(m, '\n');