[OPW,kernel] Staging: keucr: Removing semicolon from while (0) macro
diff mbox

Message ID 20131015143604.GA13666@Ashvini
State Rejected
Headers show

Commit Message

Ashvini Varatharaj Oct. 15, 2013, 2:36 p.m. UTC
Fix checkpatch warning: WARNING: do {} while (0) macros should not be
semicolon terminated

Signed-off-by: Ashvini Varatharaj <ashvinivaratharaj@gmail.com>
---
 drivers/staging/keucr/scsiglue.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Greg KH Oct. 15, 2013, 4:27 p.m. UTC | #1
On Tue, Oct 15, 2013 at 08:06:04PM +0530, Ashvini Varatharaj wrote:
> Fix checkpatch warning: WARNING: do {} while (0) macros should not be
> semicolon terminated
> 
> Signed-off-by: Ashvini Varatharaj <ashvinivaratharaj@gmail.com>
> ---
>  drivers/staging/keucr/scsiglue.c |    2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/staging/keucr/scsiglue.c b/drivers/staging/keucr/scsiglue.c
> index 35bd099..b70206f 100644
> --- a/drivers/staging/keucr/scsiglue.c
> +++ b/drivers/staging/keucr/scsiglue.c
> @@ -277,7 +277,7 @@ static int show_info(struct seq_file *m, struct Scsi_Host *host)
>  	do { \
>  		if (us->fflags & value) \
>  			SPRINTF(" " #name); \
> -	} while (0);
> +	} while (0)

This patch breaks the build :(

As it's obvious you aren't test building your patches, I'm just going to
delete all of the other ones you have sent in my inbox.

Please test build them and resend any that you wish to have reviewed.

thanks,

greg k-h

Patch
diff mbox

diff --git a/drivers/staging/keucr/scsiglue.c b/drivers/staging/keucr/scsiglue.c
index 35bd099..b70206f 100644
--- a/drivers/staging/keucr/scsiglue.c
+++ b/drivers/staging/keucr/scsiglue.c
@@ -277,7 +277,7 @@  static int show_info(struct seq_file *m, struct Scsi_Host *host)
 	do { \
 		if (us->fflags & value) \
 			SPRINTF(" " #name); \
-	} while (0);
+	} while (0)
 US_DO_ALL_FLAGS
 #undef US_FLAG
 	seq_putc(m, '\n');